Skip to content

Update Onfido SDK styles to match our style/brand#5587

Merged
ctkochan22 merged 3 commits into
mainfrom
cmartins-onfidoStyle
Sep 30, 2021
Merged

Update Onfido SDK styles to match our style/brand#5587
ctkochan22 merged 3 commits into
mainfrom
cmartins-onfidoStyle

Conversation

@luacmartins

@luacmartins luacmartins commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

Details

Customizes the Onfido modal UI to look more in line with our brand style.

cc @shawnborton

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/179228

Tests

  1. Log into an account with a Workspace but without a verified bank account.
  2. Navigate to Settings > Select Workspace > Expensify Card > Get started
  3. Use the information in this SO to add a bank account in the VERIFYING state.
  4. When you reach the Onfido step, verify that the style looks like the screenshots below:

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-09-29 at 1 10 18 PM
Screen Shot 2021-09-29 at 1 10 26 PM
Screen Shot 2021-09-29 at 1 10 33 PM
Screen Shot 2021-09-29 at 1 10 55 PM

Mobile Web

Simulator Screen Shot - iPhone 12 - 2021-09-29 at 13 18 40
Simulator Screen Shot - iPhone 12 - 2021-09-29 at 13 18 43
Simulator Screen Shot - iPhone 12 - 2021-09-29 at 14 34 47

Desktop

Screen Shot 2021-09-29 at 1 13 39 PM
Screen Shot 2021-09-29 at 1 13 46 PM
Screen Shot 2021-09-29 at 1 13 53 PM
Screen Shot 2021-09-29 at 1 14 09 PM

iOS

Simulator Screen Shot - iPhone 12 - 2021-09-29 at 14 25 00

Android

Screenshot_1632945745

@luacmartins luacmartins self-assigned this Sep 29, 2021
@luacmartins luacmartins requested a review from a team September 29, 2021 20:36
@luacmartins luacmartins marked this pull request as ready for review September 29, 2021 20:36
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team September 29, 2021 20:37
@ctkochan22 ctkochan22 merged commit a35fac4 into main Sep 30, 2021
@ctkochan22 ctkochan22 deleted the cmartins-onfidoStyle branch September 30, 2021 00:28
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@shawnborton

Copy link
Copy Markdown
Contributor

Looks good!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @ctkochan22 in version: 1.1.3-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

OSBotify commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants