[HOLD] Revert "Add DatePicker component"#5599
Closed
flodnv wants to merge 1 commit into
Closed
Conversation
iwiznia
approved these changes
Sep 30, 2021
flodnv
changed the title
Contributor
Author
|
My alternative proposal is the fix: #5600 |
Contributor
|
Hey sorry and thanks! |
Contributor
|
I think we're good to just close this out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5509
@kidroca @roryabraham @deetergp
As per my testing this morning, this broke
CompanyStep-- entering a valid date results in the following:I traced it down to this line returning false, and I am not sure why this is happening (the moment object is not empty).
I confirmed that reverting this PR fixes the problem.
@kidroca please resubmit it with the needed fixes for this not to happen. 🙇