Skip to content

[CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. "#56052

Merged
cristipaval merged 1 commit into
mainfrom
revert-55329-fix/54731
Jan 30, 2025
Merged

[CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. "#56052
cristipaval merged 1 commit into
mainfrom
revert-55329-fix/54731

Conversation

@cristipaval

@cristipaval cristipaval commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

Reverts #55329

Fixes:
$ #56029
And reintroduces #54731 which is NAB

QA Steps

Verify that the blocker doesn't occur again.

@cristipaval cristipaval self-assigned this Jan 30, 2025
@cristipaval cristipaval requested a review from a team as a code owner January 30, 2025 11:01
@cristipaval cristipaval changed the title Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. " [CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. " Jan 30, 2025
@melvin-bot melvin-bot Bot requested review from MonilBhavsar and removed request for a team January 30, 2025 11:01
@melvin-bot

melvin-bot Bot commented Jan 30, 2025

Copy link
Copy Markdown

@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cristipaval cristipaval merged commit 1b039f6 into main Jan 30, 2025
@cristipaval cristipaval deleted the revert-55329-fix/54731 branch January 30, 2025 11:17
@melvin-bot melvin-bot Bot added the Emergency label Jan 30, 2025
@melvin-bot

melvin-bot Bot commented Jan 30, 2025

Copy link
Copy Markdown

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval

Copy link
Copy Markdown
Contributor Author

Straight revert.

OSBotify pushed a commit that referenced this pull request Jan 30, 2025
[CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. "

(cherry picked from commit 1b039f6)

(CP triggered by mountiny)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Jan 30, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.92-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants