Fix not here page shows up briefly when deleting the expense while it is highlighted by M00rish · Pull Request #56153 · Expensify/App

M00rish · 2025-01-31T11:34:37Z

Explanation of Change

we're replacing isLinkedActionBecomesDeleted logic in reportScreen.tsx, that was added to fix these issues : #50120 and #46600

after adding a fix based on this comment, that fixed it for the not found page blinking problem but not for the other one when user click a deleted action link in this case not found page does not show.

after little bit of testing, I think the most optimal approach here is to check if user is navigating directly to a deleted action only then we show the not found page, basically we want distinguish between user navigating normally to a message and a delete action behavior, where we have last reportActionID param and current param as the same.

and this fixes all three of these issues.

having some issues with mobile testing setup, in the meantime I hope to have your feedback on this.
@roryabraham @brunovjk

thanks.

Fixed Issues

$ #55251

PROPOSAL:
Proposal

Tests

Go to workspace chat.
Create three manual expenses.
Go to transaction thread of any expense.
Click on the header subtitle to return to expense report.
Right click on the previously visited expense report which is now highlighted.
Click Delete expense.
Delete the expense.
Verify not found page does not appear or blink

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

Go to workspace chat.
Create three manual expenses.
Go to transaction thread of any expense.
Click on the header subtitle to return to expense report.
Right click on the previously visited expense report which is now highlighted.
Click Delete expense.
Delete the expense.
Verify not found page does not appear or blink

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android_native.mp4

Android: mWeb Chrome

Androidweb.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOSweb.mp4

MacOS: Chrome / Safari

bandicam.2025-02-02.20-57-41-084.mp4

MacOS: Desktop

Desktop.mp4

melvin-bot · 2025-02-02T21:12:03Z

@tgolen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2025-02-03T11:03:03Z

@M00rish something went wrong with your checklist, it looks like you didn't link the issue or your proposal correctly. @tgolen please ignore the call, @roryabraham and I will review it here. Thanks.

tgolen · 2025-02-03T16:30:37Z

OK, I will unassign myself then!

brunovjk · 2025-02-04T11:37:24Z

Reviewing in a moment.

brunovjk · 2025-02-05T13:05:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

56153_android_web.mov

iOS: Native

56153_ios_native.mov

iOS: mWeb Safari

56153_ios_web.mov

MacOS: Chrome / Safari

56153_web_chrome.mov

MacOS: Desktop

56153_web_desktop.mov

brunovjk

Thank you, @M00rish! I tested #55251, #50120, and #46600, and everything looks good. The fix handles the "Not Here" page issue well in my tests.

@roryabraham, could you confirm if the changes align with your cleanup approach? I tested your suggestion alone, and it does cause some regression related to #50120 and #46600. Also, do you think we should add some JSDoc, or are the added variables clear enough to you? Thank you.

roryabraham

Just curious: if you implement my proposed solution except using useRef instead of useState for isClearingDeletedLinkedAction, do you still see issues?

roryabraham · 2025-02-05T15:50:39Z

    );
-    const prevIsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);
+
+    const previsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);


Suggested change

const previsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);

const prevIsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);

roryabraham · 2025-02-05T15:52:34Z

+
+    const lastReportActionIDFromRoute = usePrevious(reportActionIDFromRoute);
+
+    const [isNavigatingToAction, setIsNavigatingToAction] = useState(false);


isNavigatingToAction sounds more broad than it really is I think? it's only true if we're navigating to a deleted action. So I think a more accurate variable name would be isNavigatingToDeletedAction

you're right, it's updated to isNavigatingToDeletedAction, makes more sense.

roryabraham

This looks good now

OSBotify · 2025-02-05T20:34:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-02-06T22:02:10Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-11T02:13:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.95-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

M00rish added 3 commits January 31, 2025 12:27

fix Not found page blinking

19f0d68

refactor to show not found page only when navigating to a deleted Action

146b89e

improve naming

72da601

M00rish marked this pull request as ready for review February 2, 2025 21:11

M00rish requested a review from a team as a code owner February 2, 2025 21:11

melvin-bot Bot requested a review from tgolen February 2, 2025 21:12

melvin-bot Bot removed the request for review from a team February 2, 2025 21:12

tgolen removed their request for review February 3, 2025 16:30

roryabraham requested review from brunovjk and roryabraham February 4, 2025 06:36

brunovjk reviewed Feb 5, 2025

View reviewed changes

roryabraham reviewed Feb 5, 2025

View reviewed changes

M00rish added 4 commits February 5, 2025 19:53

update based on reviews

cd542fd

lint update

d036c02

fix for reloading notfound does not land on notfound again

259e04c

lint fix

6f20fd0

roryabraham approved these changes Feb 5, 2025

View reviewed changes

roryabraham merged commit dca94b3 into Expensify:main Feb 5, 2025

github-actions Bot mentioned this pull request Feb 6, 2025

Deploy Checklist: New Expensify 2025-02-06 #56482

Closed

M00rish deleted the Exp#55251 branch February 6, 2025 21:21

brunovjk mentioned this pull request Feb 11, 2025

[Hold for payment 2025-02-17][$250] Expense - Not here page shows up briefly when deleting the expense while it is highlighted #55251

Closed

8 tasks

	const previsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);
	const prevIsLinkedActionDeleted = usePrevious(linkedAction ? isLinkedActionDeleted : undefined);


		const lastReportActionIDFromRoute = usePrevious(reportActionIDFromRoute);

		const [isNavigatingToAction, setIsNavigatingToAction] = useState(false);

Conversation

M00rish commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Feb 2, 2025

Uh oh!

brunovjk commented Feb 3, 2025

Uh oh!

tgolen commented Feb 3, 2025

Uh oh!

brunovjk commented Feb 4, 2025

Uh oh!

brunovjk commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

M00rish Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

M00rish Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 5, 2025

Uh oh!

github-actions Bot commented Feb 6, 2025

Uh oh!

github-actions Bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

M00rish commented Jan 31, 2025 •

edited

Loading

brunovjk commented Feb 5, 2025 •

edited

Loading