Set "Delayed submission" to "Manually" by default on new Workspaces by twilight2294 · Pull Request #57676 · Expensify/App

twilight2294 · 2025-03-03T13:18:57Z

Explanation of Change

Fixed Issues

$ #56367
PROPOSAL: #56367 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Test 1:

Sign up as a new user
Choose "Manage my team's expenses" (This create a new Workspace)
Open workspace settings
Open the Workflow tab
Verify that Set "Delayed submission" is set to Manually

Test 2:

As account A, send an expense to account B (Brand new account with no workspaces)
As Account B go to pay the expense with a business bank account

Verify that Set "Delayed submission" is set to Manually when workspace is created

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20250309_170645.mp4

Android: mWeb Chrome

Screen_recording_20250309_170331.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-09.at.17.04.17.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2025-03-09.at.17.05.49.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-09.at.4.58.12.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-09.at.5.02.11.PM.mov

melvin-bot · 2025-03-03T13:19:02Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

twilight2294 · 2025-03-03T13:19:38Z

@abdulrahuman5196 please review this one, i will upload videos shortly

dangrous · 2025-03-05T16:36:50Z

bump on review please @abdulrahuman5196 thank you!

abdulrahuman5196 · 2025-03-10T12:08:14Z

Hi, Checking today. Sorry for delay

dangrous · 2025-03-11T13:49:40Z

bumping this, thanks!

abdulrahuman5196 · 2025-03-16T16:28:22Z

Checking now.

abdulrahuman5196 · 2025-03-16T16:46:43Z

@twilight2294 I don't see any tests added or updated. Can we add/update tests similar to #50391 ?

twilight2294 · 2025-03-17T08:01:31Z

I was OoO most of last week, working on it today!

abdulrahuman5196 · 2025-03-20T08:26:17Z

Hi @twilight2294 , kindly let us know once tests are added. I can review again

twilight2294 · 2025-03-20T13:59:37Z

@abdulrahuman5196 I updated please check

dangrous · 2025-03-20T16:09:49Z

@twilight2294 did you add unit tests as well? If so, maybe they didn't get pushed? I only see the updates to the testing steps in the PR description. We can update PolicyTest in order to confirm these settings.

Thanks!

dangrous · 2025-03-21T15:28:36Z

bump @twilight2294 thanks!

abdulrahuman5196 · 2025-03-23T07:47:44Z

@twilight2294 did you add unit tests as well? If so, maybe they didn't get pushed? I only see the updates to the testing steps in the PR description. We can update PolicyTest in order to confirm these settings.

Thanks!

Gentle ping

twilight2294

@abdulrahuman5196 all yours

twilight2294 · 2025-03-24T07:00:49Z

    callback: (value) => (allTransactionViolations = value),
 });

+let introSelected: OnyxEntry<IntroSelected>;


Had to move this Up to make use of it in createDraftInitialWorkspace

twilight2294 · 2025-03-24T07:01:39Z

                    approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                    reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
                },
+                areWorkflowsEnabled: shouldEnableWorkflowsByDefault,


@dangrous @abdulrahuman5196 The PR #50391 missed to add areWorkflowsEnabled I updated it in our PR.

twilight2294 · 2025-03-24T07:02:20Z

-                    createWorkspace(CARLOS_EMAIL, true, "Carlos's Workspace");
+                    const policyID = generatePolicyID();
+                    createWorkspace(CARLOS_EMAIL, true, "Carlos's Workspace", policyID);
+                    setWorkspaceAutoReportingFrequency(policyID, CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT);


The test was for correctly submits a report with Submit and Close approval mode, so had to change the mode here

twilight2294 · 2025-03-24T07:02:29Z

+                    createWorkspace(CARLOS_EMAIL, true, "Carlos's Workspace", policyID);
+                    setWorkspaceAutoReportingFrequency(policyID, CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT);


twilight2294 · 2025-03-24T07:02:43Z

            expect(onboarding?.hasCompletedGuidedSetupFlow).toBeTruthy();
        });

+        it('create a new workspace with delayed submission set to manually if the onboarding choice is newDotManageTeam or newDotLookingAround', async () => {


This is the new test we added for our changes

I don't think we need a similar case for Looking around, but let me know if we need that too, it's not a big change, so i didn't add it here

danielrvidal · 2025-03-25T00:07:02Z

Awesome, so this should be deployed this week, right?

dangrous · 2025-03-25T19:41:47Z

Should be! @abdulrahuman5196 can you give this its final review so we can keep it moving forward? thank you!

abdulrahuman5196 · 2025-03-26T15:34:11Z

        workspaceName,
    );

+    const shouldEnableWorkflowsByDefault =


nit: It would be good to move this to a common function to avoid duplicate code.
But for now i am fine if this PR is required urgently @dangrous

yeah I think that's okay for now!

abdulrahuman5196 · 2025-03-26T18:22:22Z

Checking now

abdulrahuman5196 · 2025-03-26T19:25:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-27.at.12.50.41.AM.mp4

Android: mWeb Chrome

Screen.Recording.2025-03-27.at.12.31.23.AM.mp4

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-03-27.at.12.28.20.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-03-27.at.12.13.13.AM.mp4

MacOS: Desktop

Screen.Recording.2025-03-27.at.12.17.43.AM.mp4

abdulrahuman5196 · 2025-03-26T19:26:10Z

Hi, I am having trouble in building ios native application alone. But tested in all other platforms and the code looks good as well. So i think it should be fine.

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @dangrous

🎀 👀 🎀
C+ Reviewed

dangrous

I'm going to go ahead and merge this for expediency, but I'd love a quick follow up just adding two things to the tests:

Making sure the settings are set appropriately with no intro choice
Checking the workflows enabled and harvesting enabled as well as the autoreporting frequency

OSBotify · 2025-03-26T23:14:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-27T14:07:08Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

dangrous · 2025-03-28T18:57:59Z

I'm going to go ahead and merge this for expediency, but I'd love a quick follow up just adding two things to the tests:

Making sure the settings are set appropriately with no intro choice

Checking the workflows enabled and harvesting enabled as well as the autoreporting frequency

Bumping this when y'all have a chance to do the followup @twilight2294, thank you!

twilight2294 · 2025-03-31T07:38:44Z

Will work on this today

github-actions · 2025-03-31T10:05:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.20-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

twilight2294 · 2025-04-03T10:29:44Z

@dangrous @abdulrahuman5196 follow up PR is here: #59579

update default to immediate

faa698f

twilight2294 requested a review from a team as a code owner March 3, 2025 13:18

melvin-bot Bot requested a review from abdulrahuman5196 March 3, 2025 13:19

melvin-bot Bot removed the request for review from a team March 3, 2025 13:19

twilight2294 added 2 commits March 6, 2025 20:18

update the delayed submission test

17ba94d

Merge branch 'Expensify:main' into delayedSubmission

15950fe

twilight2294 commented Mar 9, 2025

View reviewed changes

Comment thread src/libs/actions/Policy/Policy.ts Outdated

Comment thread tests/actions/PolicyTest.ts Outdated

Comment thread tests/actions/PolicyTest.ts Outdated

fix disable workflows case

c8a148f

twilight2294 commented Mar 9, 2025

View reviewed changes

Comment thread src/libs/actions/Policy/Policy.ts Outdated

twilight2294 added 2 commits March 9, 2025 15:52

fix prettier

b704544

update condition

13aee24

twilight2294 commented Mar 9, 2025

View reviewed changes

Comment thread src/libs/actions/Policy/Policy.ts Outdated

fix lint

8857f46

twilight2294 added 4 commits March 23, 2025 16:42

add new test for delayed submissions

f4dff7c

Merge branch 'main' into delayedSubmission

d04d112

fix prettier

96d9d5a

Update PolicyTest.ts

0090a24

twilight2294 added 7 commits March 24, 2025 10:25

Merge branch 'Expensify:main' into delayedSubmission

48af552

temp: remove test to see if unit tests get fixed

5ebe36a

update create workspace conditions

f926ca9

define introSelected at the start

809d127

fix IOU unit tests

0887c74

change autoReportingFrequency to IMMEDIATE

bddc345

Add unit test

56dda08

twilight2294 commented Mar 24, 2025

View reviewed changes

abdulrahuman5196 reviewed Mar 26, 2025

View reviewed changes

abdulrahuman5196 approved these changes Mar 26, 2025

View reviewed changes

melvin-bot Bot requested a review from dangrous March 26, 2025 19:26

dangrous approved these changes Mar 26, 2025

View reviewed changes

dangrous merged commit 69f2b25 into Expensify:main Mar 26, 2025

github-actions Bot mentioned this pull request Mar 27, 2025

Deploy Checklist: New Expensify 2025-03-27 #59215

Closed

45 tasks

melvin-bot Bot mentioned this pull request Mar 31, 2025

[Due for payment 2025-04-16] [Due for payment 2025-04-07] Set "Delayed submission" to "Manually" by default on new Workspaces #56367

Closed

8 tasks

twilight2294 mentioned this pull request Apr 3, 2025

[No QA] Set "Delayed submission" to "Manually" by default on new Workspaces Tests #59579

Merged

50 tasks

		createWorkspace(CARLOS_EMAIL, true, "Carlos's Workspace", policyID);
		setWorkspaceAutoReportingFrequency(policyID, CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT);

Conversation

twilight2294 commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 3, 2025

Uh oh!

twilight2294 commented Mar 3, 2025

Uh oh!

dangrous commented Mar 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abdulrahuman5196 commented Mar 10, 2025

Uh oh!

dangrous commented Mar 11, 2025

Uh oh!

abdulrahuman5196 commented Mar 16, 2025

Uh oh!

abdulrahuman5196 commented Mar 16, 2025

Uh oh!

twilight2294 commented Mar 17, 2025

Uh oh!

abdulrahuman5196 commented Mar 20, 2025

Uh oh!

twilight2294 commented Mar 20, 2025

Uh oh!

dangrous commented Mar 20, 2025

Uh oh!

dangrous commented Mar 21, 2025

Uh oh!

abdulrahuman5196 commented Mar 23, 2025

Uh oh!

twilight2294 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielrvidal commented Mar 25, 2025

Uh oh!

dangrous commented Mar 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Mar 26, 2025

Uh oh!

abdulrahuman5196 commented Mar 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 commented Mar 26, 2025

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 26, 2025

twilight2294 commented Mar 3, 2025 •

edited

Loading