Skip to content

Remove text selection hack for Android as FlatList fixes everything! #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcaaron merged 1 commit into from
Oct 5, 2020
Merged

Remove text selection hack for Android as FlatList fixes everything! #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/InvertedFlatList/BaseInvertedFlatList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,11 @@ class BaseInvertedFlatList extends Component {
renderItem={this.renderItem}
getItemLayout={this.getItemLayout}
bounces={false}
removeClippedSubviews
maxToRenderPerBatch={15}
updateCellsBatchingPeriod={40}

// Setting removeClippedSubviews will break text selection on Android
removeClippedSubviews={false}
/>
);
}
Expand Down
16 changes: 4 additions & 12 deletions src/page/home/report/ReportActionItemFragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import HTML from 'react-native-render-html';
import {
Linking, ActivityIndicator, View, Platform, Dimensions
Linking, ActivityIndicator, View, Dimensions
} from 'react-native';
import PropTypes from 'prop-types';
import Str from '../../../lib/Str';
Expand Down Expand Up @@ -86,9 +86,7 @@ class ReportActionItemFragment extends React.PureComponent {
return fragment.html !== fragment.text
? (
<HTML

// HACK - Android selection causes performance issues, temporarily disable it until we fix
textSelectable={Platform.OS !== 'android'}
textSelectable
renderers={this.customRenderers}
baseFontStyle={webViewStyles.baseFontStyle}
tagsStyles={webViewStyles.tagStyles}
Expand All @@ -100,20 +98,14 @@ class ReportActionItemFragment extends React.PureComponent {
/>
)
: (
<Text

// HACK - Android selection causes performance issues, temporarily disable it until we fix
selectable={Platform.OS !== 'android'}
>
<Text selectable>
{Str.htmlDecode(fragment.text)}
</Text>
);
case 'TEXT':
return (
<Text

// HACK - Android selection causes performance issues, temporarily disable it until we fix
selectable={Platform.OS !== 'android'}
selectable
style={[styles.chatItemMessageHeaderSender]}
>
{Str.htmlDecode(fragment.text)}
Expand Down