Skip to content

Introduce setTimeout on ActiveClientManager.init #58012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 11 commits into from
Apr 23, 2025
Merged

Introduce setTimeout on ActiveClientManager.init #58012

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e0c4aa1
Introduce setTimeout to mitigate the issue with iPhone delaying event…
sosek108 Mar 7, 2025
feb199a
Merge branch 'main' into fix/another-login-page-open
sosek108 Apr 14, 2025
8004887
check if application is running of Apple device
sosek108 Apr 14, 2025
653f53e
check for iPhone and iPad only
sosek108 Apr 14, 2025
418f4eb
Write more clear description of why our change
sosek108 Apr 17, 2025
65bcdde
reuse isSafari function
sosek108 Apr 17, 2025
6fcbc12
fix prettier errors
sosek108 Apr 17, 2025
6e63706
Merge branch 'main' into fix/another-login-page-open
sosek108 Apr 17, 2025
6c32c07
Fix lint errors
sosek108 Apr 17, 2025
d7f58fa
cleaner code changes
sosek108 Apr 17, 2025
b41d856
prettier fix
sosek108 Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Expensify.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import * as EmojiPickerAction from './libs/actions/EmojiPickerAction';
import * as Report from './libs/actions/Report';
import * as User from './libs/actions/User';
import * as ActiveClientManager from './libs/ActiveClientManager';
import {isSafari} from './libs/Browser';
import * as Environment from './libs/Environment/Environment';
import FS from './libs/Fullstory';
import * as Growl from './libs/Growl';
Expand Down Expand Up @@ -130,7 +131,14 @@ function Expensify() {
return;
}

ActiveClientManager.init();
// Delay client init to avoid issues with delayed Onyx events on iOS. All iOS browsers use WebKit, which suspends events in background tabs.
// Events are flushed only when the tab becomes active again causing issues with client initialization.
// See: https://stackoverflow.com/questions/54095584/page-becomes-inactive-when-switching-tabs-on-ios
if (isSafari()) {
setTimeout(ActiveClientManager.init, 400);
} else {
ActiveClientManager.init();
}
};

const setNavigationReady = useCallback(() => {
Expand Down