Add Paypal option removed if Paypal already exists

[Santhosh-Sellavel]

Details

If the Paypal option has already been added by the user, will not show add PayPal option now.

Fixed Issues

$ #5418

Tests & QA Steps

1. Go to Settings -> Payments
2. If PayPal username is not added already, add now.
3. Now Payments page, click Add Payment Method option
4. Should not see Paypal.Me in options.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

Looks good to me. See More. Ready for merge after N6 is lifted cc @pecanoro

[Santhosh-Sellavel]

@pecanoro Any update on this?

[Santhosh-Sellavel]

Updated with new screenshots after merging with Main again.

[stitesExpensify]

LGTM!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @stitesExpensify in version: 1.1.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[nazam100]

Accessibility Issue: Focus moving to Hidden Elements. This bug is similar to #5452
Failed WCAG: 2.4.3
Actual Result: The focus is moving to the background elements.
Expected Result: The focus should move to the opened dialogue box.

Attachment:

payment.page.focus.is.moves.hidden.content.mp4

focus.order.mp4

[nazam100]

Accessibility Issue: The element announced without button role. This is similar to issue #5446
Failed WCAG: 4.1.2
Actual Result: The element is announced without a name and role of the button.
Expected Result: Since this is an interactive element, it should be announced with a name and role of the button.

Attachment:

Screen.reader.is.not.announcing.the.Name.and.role.of.button.mp4

[nazam100]

Accessibility Issue: Grey icons against white background fail contrast requirements. This issue is similar to #5506
Failed WCAG: 1.4.11
Actual Result: The grey icons (#C6C9CA) on white background (#FFFFFF) have a color contrast ratio of 1.66:1.
Expected Result: The visual presentation of meaningful graphical objects or interactive components should have a contrast ratio of at least 3.00:1 with the surrounding background color.

Attachments:

[nazam100]

Accessibility Issue: Grey text against white background fail contrast requirements. This issue is similar to #5503
Failed WCAG: 1.4.3
Actual Result: The grey text (#AOABAE) on white background (#FFFFFF) have a color contrast ratio of 2.4:1.
Expected Result: The contrast ratio of the text against the background should be at least 4.50:1 for small text and 3.00:1 for large text (14pt bold or 18 pt+).

Attachment:

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅