Skip to content

Fix originalMessage key names #58520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 1 commit into from
Mar 17, 2025
Merged

Fix originalMessage key names #58520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1184,7 +1184,7 @@ const CONST = {
CARD_ISSUED_VIRTUAL: 'CARDISSUEDVIRTUAL',
CARD_ASSIGNED: 'CARDASSIGNED',
CHANGE_FIELD: 'CHANGEFIELD', // OldDot Action
CHANGE_POLICY: 'CHANGEPOLICY', // OldDot Action
CHANGE_POLICY: 'CHANGEPOLICY',
CHANGE_TYPE: 'CHANGETYPE', // OldDot Action
CHRONOS_OOO_LIST: 'CHRONOSOOOLIST',
CLOSED: 'CLOSED',
Expand Down
6 changes: 3 additions & 3 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5456,7 +5456,7 @@ function getDeletedTransactionMessage(action: ReportAction) {

function getPolicyChangeMessage(action: ReportAction) {
const PolicyChangeOriginalMessage = getOriginalMessage(action as ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.CHANGE_POLICY>) ?? {};
const {fromPolicyID, toPolicyID} = PolicyChangeOriginalMessage as OriginalMessageChangePolicy;
const {fromPolicy: fromPolicyID, toPolicy: toPolicyID} = PolicyChangeOriginalMessage as OriginalMessageChangePolicy;
const message = translateLocal('report.actions.type.changeReportPolicy', {
fromPolicyName: fromPolicyID ? getPolicyNameByID(fromPolicyID) : undefined,
toPolicyName: getPolicyNameByID(toPolicyID),
Expand Down Expand Up @@ -5749,8 +5749,8 @@ function buildOptimisticMovedReportAction(fromPolicyID: string | undefined, toPo
*/
function buildOptimisticChangePolicyReportAction(fromPolicyID: string | undefined, toPolicyID: string): ReportAction {
const originalMessage = {
fromPolicyID,
toPolicyID,
fromPolicy: fromPolicyID,
toPolicy: toPolicyID,
};

const fromPolicy = getPolicy(fromPolicyID);
Expand Down
4 changes: 2 additions & 2 deletions src/types/onyx/OriginalMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,10 @@ type OriginalMessageReimbursementDequeued = {
/** Model of `CHANGEPOLICY` report action */
type OriginalMessageChangePolicy = {
/** ID of the old policy */
fromPolicyID: string | undefined;
fromPolicy: string | undefined;

/** ID of the new policy */
toPolicyID: string;
toPolicy: string;
};

/** Model of `moved` report action */
Expand Down