Skip to content

[No QA] Workaround for hybrid builds not being skipped #58617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 1 commit into from
Mar 18, 2025
Merged

[No QA] Workaround for hybrid builds not being skipped #58617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/testBuildHybrid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ on:
description: Pull Request number from Mobile-Expensify repo for correct placement of OD app. It will take precedence over MOBILE-EXPENSIFY from App's PR description if both specified. If nothing is specified defaults to Mobile-Expensify's main
required: false
default: ''
DISPATCHED_MANUALLY:
description: Do not modify! GH preserves `workflow_dispatch` as event that triggered this workflow even if it was called from `testBuild.yml`. This is workaround for that issue.
type: boolean
default: true
workflow_call:
inputs:
APP_PR_NUMBER:
Expand Down Expand Up @@ -49,14 +53,14 @@ jobs:
uses: actions/checkout@v4

- name: Validate that user is an Expensify employee
if: ${{ inputs.APP_REF == '' }}
if: github.event.inputs.DISPATCHED_MANUALLY
uses: ./.github/actions/composite/validateActor
with:
REQUIRE_APP_DEPLOYER: false
OS_BOTIFY_TOKEN: ${{ secrets.OS_BOTIFY_COMMIT_TOKEN }}

- name: Validate input
if: ${{ inputs.APP_REF == '' }}
if: github.event.inputs.DISPATCHED_MANUALLY
run: |
if [[ -z "${{ github.event.inputs.APP_PULL_REQUEST_NUMBER }}" && -z "${{ github.event.inputs.HYBRIDAPP_PULL_REQUEST_NUMBER }}" ]]; then
echo "Invalid input. You have to pass at least one PR number"
Expand Down Expand Up @@ -153,7 +157,7 @@ jobs:

androidHybrid:
name: Build Android HybridApp
if: ${{ github.event_name == 'workflow_dispatch' || inputs.ANDROID_HYBRID }}
if: ${{ github.event.inputs.DISPATCHED_MANUALLY || inputs.ANDROID_HYBRID }}
needs: [getNewDotRef, getOldDotPR, getOldDotRef]
runs-on: ubuntu-latest-xl
outputs:
Expand Down Expand Up @@ -269,7 +273,7 @@ jobs:

iosHybrid:
name: Build and deploy iOS for testing
if: ${{ github.event_name == 'workflow_dispatch' || inputs.IOS_HYBRID }}
if: ${{ github.event.inputs.DISPATCHED_MANUALLY || inputs.IOS_HYBRID }}
needs: [getNewDotRef, getOldDotPR, getOldDotRef]
env:
DEVELOPER_DIR: /Applications/Xcode_16.2.0.app/Contents/Developer
Expand Down Expand Up @@ -386,7 +390,7 @@ jobs:
postGithubComment:
runs-on: ubuntu-latest
name: Post a GitHub comment with app download links for testing
if: github.event_name == 'workflow_dispatch'
if: github.event.inputs.DISPATCHED_MANUALLY
needs: [getNewDotRef, getOldDotPR, androidHybrid, iosHybrid]
steps:
- name: Checkout
Expand Down