[NO QA] Add three images Maddylewis patch 1#58638
Conversation
title of article changed / updating redirect #45357
Concierge reviewer checklist:
|
|
@neil-marcellini @jliexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
|
This is why the build is failing |
|
🤷♀️ removed the duplicate redirect |
|
A preview of your ExpensifyHelp changes have been deployed to https://078d1fda.helpdot.pages.dev ⚡️ |
neil-marcellini
left a comment
There was a problem hiding this comment.
Looks good. I can see we already display the tax exempt photo. I don't see where the others are displayed but I assume that will come later?
|
No reviewer checklist needed for helpsite changes |
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.1.15-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.15-9 🚀
|
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined