Skip to content

App crashes after viewing card transactions and reporting card fraud #59175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
Mar 31, 2025
+7 −1
Merged

App crashes after viewing card transactions and reporting card fraud #59175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efba21a
App crashes after viewing card transactions and reporting card fraud
nkdengineer Mar 26, 2025
515276a
prettier
nkdengineer Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/components/Modal/BaseModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ function BaseModal(
const safeAreaInsets = useSafeAreaInsets();

const isVisibleRef = useRef(isVisible);
const hideModalCallbackRef = useRef<(callHideCallback: boolean) => void>();

const wasVisible = usePrevious(isVisible);

const uniqueModalId = useMemo(() => modalId ?? ComposerFocusManager.getId(), [modalId]);
Expand Down Expand Up @@ -144,13 +146,17 @@ function BaseModal(
};
}, [isVisible, wasVisible, onClose, type]);

useEffect(() => {
hideModalCallbackRef.current = hideModal;
}, [hideModal]);

useEffect(
() => () => {
// Only trigger onClose and setModalVisibility if the modal is unmounting while visible.
if (!isVisibleRef.current) {
return;
}
hideModal(true);
hideModalCallbackRef.current?.(true);
},
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
[],
Expand Down