Skip to content

fix: call GetAssignedSupportData only on workspace switching #59281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
techievivek merged 2 commits into from
Apr 7, 2025
+8 −12
Merged

fix: call GetAssignedSupportData only on workspace switching #59281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad8d942
fix: call GetAssignedSupportData only on workspace switching
daledah Mar 28, 2025
736baa8
fix: lint
daledah Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/pages/home/HeaderView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {useRoute} from '@react-navigation/native';
import React, {memo, useEffect, useMemo, useState} from 'react';
import React, {memo, useMemo, useState} from 'react';
import {View} from 'react-native';
import type {OnyxEntry} from 'react-native-onyx';
import {useOnyx} from 'react-native-onyx';
Expand Down Expand Up @@ -29,7 +29,6 @@ import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {openExternalLink} from '@libs/actions/Link';
import {initializeOpenAIRealtime, stopConnection} from '@libs/actions/OpenAI';
import {getAssignedSupportData} from '@libs/actions/Policy/Policy';
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
import Navigation from '@libs/Navigation/Navigation';
import {getPersonalDetailsForAccountIDs} from '@libs/OptionsListUtils';
Expand Down Expand Up @@ -147,13 +146,6 @@ function HeaderView({report, parentReportAction, onNavigationMenuButtonClicked,
const policyName = getPolicyName({report, returnEmptyIfNotFound: true});
const policyDescription = getPolicyDescriptionText(policy);
const isPersonalExpenseChat = isPolicyExpenseChat && isCurrentUserSubmitter(report?.reportID);
const policyID = report?.policyID;
useEffect(() => {
if (!policyID) {
return;
}
getAssignedSupportData(policyID);
}, [policyID]);

const shouldShowSubtitle = () => {
if (!subtitle) {
Expand Down
10 changes: 7 additions & 3 deletions src/pages/home/sidebar/SidebarLinksData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import {useOnyx} from 'react-native-onyx';
import type {EdgeInsets} from 'react-native-safe-area-context';
import useActiveWorkspace from '@hooks/useActiveWorkspace';
import useLocalize from '@hooks/useLocalize';
import usePrevious from '@hooks/usePrevious';
import {useReportIDs} from '@hooks/useReportIDs';
import useThemeStyles from '@hooks/useThemeStyles';
import * as Policy from '@userActions/Policy/Policy';
import {getAssignedSupportData, openWorkspace} from '@libs/actions/Policy/Policy';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import SidebarLinks from './SidebarLinks';
Expand All @@ -27,12 +28,15 @@ function SidebarLinksData({insets}: SidebarLinksDataProps) {

const {orderedReportIDs, currentReportID, policyMemberAccountIDs} = useReportIDs();

const previousActiveWorkspaceID = usePrevious(activeWorkspaceID);

useEffect(() => {
if (!activeWorkspaceID) {
if (!activeWorkspaceID || previousActiveWorkspaceID === activeWorkspaceID) {
return;
}

Policy.openWorkspace(activeWorkspaceID, policyMemberAccountIDs);
openWorkspace(activeWorkspaceID, policyMemberAccountIDs);
getAssignedSupportData(activeWorkspaceID);
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [activeWorkspaceID]);

Expand Down