Enable switching from Old Dot to New Dot on web when copiloted in by ZhenjaHorbach · Pull Request #59323 · Expensify/App

ZhenjaHorbach · 2025-03-30T11:37:14Z

Explanation of Change

Enable switching from Old Dot to New Dot on web when copiloted in

Fixed Issues

$ #59306
PROPOSAL:

Tests

Precondition:

Add a copilot to the current account.

Test Steps:

Test case 1

Open the OldDot application
Select a copilot as the active account
Switch to NewDot using one of the following methods:
Support → Concierge
Try New Expensify button
Reports → Random report → Take me there button
Verify that NewDot opens with the copilot as the active account in the correct location

Test case 2

Open the NewDot application
Select a copilot as the active account
Switch to OldDot
Verify that OldDot opens with the copilot as the active account

Verify that no errors appear in the JS console

Offline tests

Precondition:

Add a copilot to the current account.

Test Steps:

Test case 1

Open the OldDot application
Select a copilot as the active account
Switch to NewDot using one of the following methods:
Support → Concierge
Try New Expensify button
Reports → Random report → Take me there button
Verify that NewDot opens with the copilot as the active account in the correct location

Test case 2

Open the NewDot application
Select a copilot as the active account
Switch to OldDot
Verify that OldDot opens with the copilot as the active account

QA Steps

Note: Please ping @dangrous if this doesn't seem to be working, we may have to add additional test emails to the beta; I added the applause.expensifail.com domain. Also, this is specifically for desktop web; this should already work on hybrid app.

Precondition:

Add a copilot to the current account.

Test Steps:

Test case 1

Open the OldDot application
Select a copilot as the active account
Switch to NewDot using one of the following methods:
Support → Concierge
Try New Expensify button
Reports → Random report → Take me there button
Verify that NewDot opens with the copilot as the active account in the correct location

Test case 2

Open the NewDot application
Select a copilot as the active account
Switch to OldDot
Verify that OldDot opens with the copilot as the active account

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

2025-03-31.13.43.39.mov

iOS: Native

NA

iOS: mWeb Safari

2025-03-31.13.35.28.mov

MacOS: Chrome / Safari

2025-03-30.19.11.18.mov

MacOS: Desktop

NA

dangrous · 2025-03-31T17:53:53Z

This is looking great! The loading screen is a little long, but I think that's way better than seeing all the work behind the scenes. I think it's ready to go into review, we can grab another C+ to do some additional testing.

Only things to note:

The updated Old Dot behavior is now live on staging, so all New Dot links should open in a new tab
Can you add a testing step to confirm that going from New Dot to Old Dot works? (It seems to, just need to add it for QA)
I noticed a separate bug - when you go from Old Dot to New Dot normally (i.e. no copilot) and you're already logged into ND with that account, it won't actually load a chat until you click somewhere else and back. But, it happens on main too so it's not our concern here.

Thank you for tackling this!

melvin-bot · 2025-03-31T18:00:23Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous · 2025-03-31T20:59:47Z

@suneox let me know some test emails you'll want to use and I can add them to the beta!

suneox · 2025-04-01T13:49:00Z

@suneox let me know some test emails you'll want to use and I can add them to the beta!

Could you please add the emailscongpt.dev+bank@gmail.com and congpt.dev+59306@gmail.com? Thanks!

dangrous · 2025-04-01T14:01:40Z

@suneox those are added; it may take up to an hour but it should be ready to go after that

suneox · 2025-04-01T14:07:14Z

@suneox those are added; it may take up to an hour but it should be ready to go after that

Got it! I will review the code changes and complete the checklist after an hour

dangrous · 2025-04-02T14:50:48Z

bump on review @suneox thanks!

suneox · 2025-04-02T15:09:53Z

bump on review @suneox thanks!

I'm still testing, but when switching from oldDot to newDot both emails I've provided don't have the delegatorEmail parameter in the /transition route from oldDot. Should I manually add this parameter?

Screen.Recording.2025-04-02.at.21.52.08.mp4

suneox · 2025-04-02T15:55:26Z

I'm still testing, but when switching from oldDot to newDot both emails I've provided don't have the delegatorEmail parameter in the /transition route from oldDot. Should I manually add this parameter?

It looks like oldDot doesn't yet support switching Copilot accounts, so I'll continue the checklist by manually adding the delegatorEmail parameter.

dangrous · 2025-04-02T16:01:13Z

Hrm so it should work with the emails that you shared with me before - the changes to send delegatorEmail were the same ones that added the Try New Expensify button to the copilot view in Old Dot. @ZhenjaHorbach can you share any steps that you did that might help set this up for testing?

From what I understand, I think you'll need to:

Click on a link (like the Concierge link) in Old Dot.
Immediately stop the link from loading
change staging.new.expensify.com to dev.new.expensify.com:8082 in that URL
Allow the page to load

suneox · 2025-04-02T16:54:56Z

Hrm so it should work with the emails that you shared with me before - the changes to send delegatorEmail were the same ones that added the Try New Expensify button to the copilot view in Old Dot
From what I understand, I think you'll need to:

I also used the emails I shared with you earlier and followed the same steps, but the delegatorEmail parameter wasn’t included in the transition route. When I manually added delegatorEmail it will be navigate to sign-in page

Screen.Recording.2025-04-02.at.23.45.28.mp4

suneox · 2025-04-02T17:11:39Z

+ * @param setIsDelegatorFromOldDotIsReady - An optional callback function that is called
+ * when the delegator is authenticated (used in case of switching from OldDot to NewDot).
+ */
+function connect(email: string, setIsDelegatorFromOldDotIsReady?: (isReady: boolean) => void) {


NAB: What do you think about making this function return a promise at API.makeRequestWithSideEffects? This way, we can handle the business logic for setIsDelegatorFromOldDotIsReady in AuthScreens, allowing us to separate it from the action logic.

suneox · 2025-04-02T17:21:03Z

+            // or returning from background. If so, we'll assume they have some app data already and we can call reconnectApp() instead of openApp() and connect() for delegator from OldDot.
+            if (SessionUtils.didUserLogInDuringSession() || delegatorEmail) {
+                if (delegatorEmail) {
+                    connect(delegatorEmail, setIsDelegatorFromOldDotIsReady);


NAB: if we want to return the connect function as a promise func

connect(delegatorEmail).then(() => { setIsDelegatorFromOldDotIsReady(true); })

Hmmm
Actually good idea
I will check tomorrow

ZhenjaHorbach · 2025-04-02T20:00:17Z

Hrm so it should work with the emails that you shared with me before - the changes to send delegatorEmail were the same ones that added the Try New Expensify button to the copilot view in Old Dot. @ZhenjaHorbach can you share any steps that you did that might help set this up for testing?

From what I understand, I think you'll need to:

Click on a link (like the Concierge link) in Old Dot.

Immediately stop the link from loading

change staging.new.expensify.com to dev.new.expensify.com:8082 in that URL

Allow the page to load

Strange 🧐
Surprisingly I had no problems with testing at all
And delegatorEmail was always passed 😅

ZhenjaHorbach · 2025-04-02T20:02:56Z

But wait
@suneox
Try to use prod OD instead of staging OD

dangrous · 2025-04-03T13:39:36Z

Hm it shoudl work either way? But as long as it works on production I guess that's fine (all related code is on prod now)

ZhenjaHorbach · 2025-04-03T13:50:59Z

Hm it shoudl work either way? But as long as it works on production I guess that's fine (all related code is on prod now)

Yeah

In theory, the functionality should work on all environments
but I have always used the prod

suneox · 2025-04-03T15:06:22Z

But wait @suneox Try to use prod OD instead of staging OD

I still can't get delegatorEmail on production using the email congpt.dev+bank@gmail.com

Screen.Recording.2025-04-03.at.21.47.37.mp4

suneox · 2025-04-03T15:13:04Z

But on the video you redirected to the main account on OD And then from main account on OD to ND

Yes on my account is always switching to the main account when chose Take me there or Try New Expensify

ZhenjaHorbach · 2025-04-03T16:49:00Z

But on the video you redirected to the main account on OD And then from main account on OD to ND

Yes on my account is always switching to the main account when chose Take me there or Try New Expensify

Yeah
I deleted the comment 😅
In that case I don't have ideas why it doesn't work 😔
Maybe we should try to add another account to beta ?

dangrous · 2025-04-03T17:27:08Z

@suneox are you able to allow popups from expensify in your Safari (alternately try Chrome or another browser)? I'm wondering if it's some timing issue with the api commands that it's doing on the back end (for example, it should stay copiloted in in Old Dot now.

I just tried on my computer with Chrome and Safari on staging. Chrome works fine, Safari does NOT work until after you allow pop ups, but once it opens the link automatically it includes delegatorEmail

ZhenjaHorbach · 2025-04-03T17:33:11Z

@suneox are you able to allow popups from expensify in your Safari (alternately try Chrome or another browser)? I'm wondering if it's some timing issue with the api commands that it's doing on the back end (for example, it should stay copiloted in in Old Dot now.

I just tried on my computer with Chrome and Safari on staging. Chrome works fine, Safari does NOT work until after you allow pop ups, but once it opens the link automatically it includes delegatorEmail

Oh
Good point !
I always tested with chrome

suneox · 2025-04-03T17:56:53Z

@suneox are you able to allow popups from expensify in your Safari (alternately try Chrome or another browser)? I'm wondering if it's some timing issue with the api commands that it's doing on the back end (for example, it should stay copiloted in in Old Dot now.

I just tried on my computer with Chrome and Safari on staging. Chrome works fine, Safari does NOT work until after you allow pop ups, but once it opens the link automatically it includes delegatorEmail

I was using the default Safari settings and wasn't aware of the popup permission. Now it works for me after allow the pop-up.

suneox · 2025-04-04T12:46:00Z

-        .catch((error) => {
-            Log.alert('[Delegate] Error connecting as delegate', {error});
-            Onyx.update(failureData);
-        });


I think we need to revert this change to keep updating failureData we can return false after update failureData to handle update on AuthScreen

Oh
Yeah
I was a bit hasty with the changes and didn't notice that I deleted this 😅
I'll fix it now

@suneox
Done !

suneox · 2025-04-04T15:55:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: mWeb Chrome

Test case 1:

Screen.Recording.2025-04-04.at.22.46.47.mp4

Test case 2:

Screen.Recording.2025-04-04.at.22.49.15.mp4

iOS: mWeb Safari

Test case 1:

Screen.Recording.2025-04-04.at.20.21.32.mp4

Test case 2:

Screen.Recording.2025-04-04.at.22.42.12.mp4

MacOS: Chrome / Safari

Test case 1:

Copilot account

Screen.Recording.2025-04-02.at.22.43.50.mp4

Original account

Screen.Recording.2025-04-04.at.23.00.29.mp4

Test case 2:

Screen.Recording.2025-04-04.at.20.11.26.mp4

Android: Native

Screen.Recording.2025-04-04.at.23.28.52.mp4

iOS: Native

Screen.Recording.2025-04-04.at.23.09.08.mp4

MacOS: Desktop

Screen.Recording.2025-04-04.at.23.16.02.mp4

suneox

Works as expected

dangrous

Thank you both!

OSBotify · 2025-04-04T19:38:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:08:52Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:14:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:29Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

ZhenjaHorbach added 13 commits March 30, 2025 13:35

Add main logic for switching from OldDot to NewDot for delegator

5755f48

Update PriorityMode.autoSwitchToFocusMode for delegator

d6095f4

Fix imports

b25096a

Update condition

29c18bf

Update condition x2

ab3a2b4

Improve connect logic

406af66

Improve connect logic x2

7dc27ed

Make changes after running prettier

5b5a979

Rename constants

32e85e7

Refactor LogInWithShortLivedAuthTokenPage

b6db01a

Refactor LogInWithShortLivedAuthTokenPage x2

382972f

Move autoSwitchToFocusMode

3b6eccd

Fix tests

64ebaa8

dangrous self-requested a review March 31, 2025 14:29

ZhenjaHorbach marked this pull request as ready for review March 31, 2025 18:00

ZhenjaHorbach requested a review from a team as a code owner March 31, 2025 18:00

melvin-bot Bot requested review from suneox and removed request for a team March 31, 2025 18:00

suneox reviewed Apr 2, 2025

View reviewed changes

Fix conflicts

63b404a

ZhenjaHorbach force-pushed the allow-old-dot-copilot branch from 1b3abed to 63b404a Compare April 3, 2025 16:58

Refactor new changes

5f9f70b

Remove unnecessary ?.

011a444

suneox reviewed Apr 4, 2025

View reviewed changes

Update connect to return success state

7a36f1d

suneox approved these changes Apr 4, 2025

View reviewed changes

dangrous approved these changes Apr 4, 2025

View reviewed changes

dangrous merged commit 7ade8d5 into Expensify:main Apr 4, 2025

dangrous mentioned this pull request Apr 7, 2025

[HOLD] Allow transfer to Old Dot as copilot #56437

Closed

50 tasks

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot Bot mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-16] Enable switching from New to Old Dot on web when copiloted in #59306

Closed

mitarachim mentioned this pull request Apr 9, 2025

[$250] [Hold for Payment 4/23] Copilot - No sign in when switching from OD to ND #59891

Closed

8 tasks

Conversation

ZhenjaHorbach commented Mar 30, 2025 • edited by dangrous Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

dangrous commented Mar 31, 2025

Uh oh!

melvin-bot Bot commented Mar 31, 2025

Uh oh!

dangrous commented Mar 31, 2025

Uh oh!

suneox commented Apr 1, 2025

Uh oh!

dangrous commented Apr 1, 2025

Uh oh!

suneox commented Apr 1, 2025

Uh oh!

dangrous commented Apr 2, 2025

Uh oh!

suneox commented Apr 2, 2025

Uh oh!

suneox commented Apr 2, 2025

Uh oh!

dangrous commented Apr 2, 2025

Uh oh!

suneox commented Apr 2, 2025

Uh oh!

suneox Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

suneox Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Apr 2, 2025

Uh oh!

ZhenjaHorbach commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Apr 3, 2025

Uh oh!

ZhenjaHorbach commented Apr 3, 2025

Uh oh!

suneox commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suneox commented Apr 3, 2025

Uh oh!

ZhenjaHorbach commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dangrous commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Apr 3, 2025

Uh oh!

suneox commented Apr 3, 2025

Uh oh!

suneox Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

suneox commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

ZhenjaHorbach commented Mar 30, 2025 •

edited by dangrous

Loading

ZhenjaHorbach Apr 2, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 2, 2025 •

edited

Loading

suneox commented Apr 3, 2025 •

edited

Loading

ZhenjaHorbach commented Apr 3, 2025 •

edited

Loading

dangrous commented Apr 3, 2025 •

edited

Loading

suneox commented Apr 4, 2025 •

edited

Loading