Fix closing the expensify card bank account page shows a verify animation by bernhardoj · Pull Request #59351 · Expensify/App

bernhardoj · 2025-03-31T12:50:53Z

Explanation of Change

Fixed Issues

$ #59048
PROPOSAL: #59048 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Log in with an account that is an admin of a WS with "Expensify Card" enabled
Navigate to Settings - Workspaces - WS with "Expensify Card" enabled - Expensify Card - Issue new card
Dismiss the RHP
Verify there is no verifying animation shows

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…tion

melvin-bot · 2025-03-31T12:50:59Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2025-04-01T09:35:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-01.at.3.15.51.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-01.at.3.17.15.PM.mov

iOS: Native

Screen.Recording.2025-04-01.at.3.10.23.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-01.at.3.11.29.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-01.at.3.06.43.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-01.at.3.07.29.PM.mov

MariaHCD · 2025-04-01T10:42:56Z

+        /** Expensify cards bank account settings */
+        PRIVATE_EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'private_expensifyCardBankAccountSettings_',


This key doesn't need to follow this naming convention because it doesn't exist on the BE. So it might confuse other engineers who might think this is directly co-related to a NVP that we store in the BE. Thoughts? Do we have other Onyx keys that are solely used on the FE?

Suggested change

/** Expensify cards bank account settings */

PRIVATE_EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'private_expensifyCardBankAccountSettings_',

/** Expensify cards bank account settings */

EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'expensifyCardBankAccountSettings_',

Make sense.

These 3 are FE only keys.

App/src/ONYXKEYS.ts

Lines 517 to 521 in 1303cc0

REPORT_DRAFT: 'reportDraft_',

// REPORT_METADATA is a perf optimization used to hold loading states (isLoadingInitialReportActions, isLoadingOlderReportActions, isLoadingNewerReportActions).

// A lot of components are connected to the Report entity and do not care about the actions. Setting the loading state

// directly on the report caused a lot of unnecessary re-renders

REPORT_METADATA: 'reportMetadata_',

App/src/ONYXKEYS.ts

Line 496 in 1303cc0

DOWNLOAD: 'download_',

I think EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS looks good.

@MariaHCD updated.

…g-expensify-card-ba-page

MariaHCD · 2025-04-04T08:19:16Z

+/** Model of Expensify card bank account settings for a workspace */
+type ExpensifyCardBankAccountSettings = {


Suggested change

/** Model of Expensify card bank account settings for a workspace */

type ExpensifyCardBankAccountSettings = {

/** Model of Expensify card bank account for a workspace */

type ExpensifyCardBankAccount = {

MariaHCD · 2025-04-04T08:27:34Z

+        /** Expensify cards bank account settings */
+        EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'expensifyCardBankAccountSettings_',
+


Suggested change

/** Expensify cards bank account settings */

EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'expensifyCardBankAccountSettings_',

/** Expensify cards bank account for a given workspace */

EXPENSIFY_CARD_BANK_ACCOUNT: 'expensifyCardBankAccountSettings_',

I think EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS gives the incorrect impression that we are storing bank account settings. But all we're doing is tracking whether the bank account is loading and if it was successfully added.

Yeah, make sense. Maybe we can use METADATA like REPORT_METADATA?

EXPENSIFY_CARD_BANK_ACCOUNT_METADATA

Nice, yeah, that would be better! 👍🏼

…g-expensify-card-ba-page

OSBotify · 2025-04-07T08:31:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:08:58Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:14:14Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:35Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

fix closing the expensify card bank account page shows a verify anima…

7a917f3

…tion

bernhardoj requested a review from a team as a code owner March 31, 2025 12:50

melvin-bot Bot requested review from allgandalf and removed request for a team March 31, 2025 12:50

prettier

2d5d0d5

allgandalf approved these changes Apr 1, 2025

View reviewed changes

melvin-bot Bot requested a review from MariaHCD April 1, 2025 09:48

MariaHCD requested changes Apr 1, 2025

View reviewed changes

bernhardoj added 2 commits April 3, 2025 21:10

Merge branch 'main' into fix/59048-verify-animation-shows-when-closin…

0416eab

…g-expensify-card-ba-page

update onyxkeys name

e5c79e2

allgandalf approved these changes Apr 4, 2025

View reviewed changes

melvin-bot Bot requested a review from MariaHCD April 4, 2025 06:53

MariaHCD requested changes Apr 4, 2025

View reviewed changes

bernhardoj added 3 commits April 5, 2025 11:20

Merge branch 'main' into fix/59048-verify-animation-shows-when-closin…

c2616de

…g-expensify-card-ba-page

update comment

3d0b421

rename onyx keys

1dca4c5

allgandalf approved these changes Apr 6, 2025

View reviewed changes

melvin-bot Bot requested a review from MariaHCD April 6, 2025 07:03

MariaHCD approved these changes Apr 7, 2025

View reviewed changes

MariaHCD merged commit 1e8c98d into Expensify:main Apr 7, 2025

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot Bot mentioned this pull request Apr 9, 2025

[COMPLETE] [$250] Expensify Card - "Verifying bank account" message appears while closing the BA RHP #59048

Closed

8 tasks

		/** Expensify cards bank account settings */
		PRIVATE_EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'private_expensifyCardBankAccountSettings_',

	REPORT_DRAFT: 'reportDraft_',
	// REPORT_METADATA is a perf optimization used to hold loading states (isLoadingInitialReportActions, isLoadingOlderReportActions, isLoadingNewerReportActions).
	// A lot of components are connected to the Report entity and do not care about the actions. Setting the loading state
	// directly on the report caused a lot of unnecessary re-renders
	REPORT_METADATA: 'reportMetadata_',

		/** Model of Expensify card bank account settings for a workspace */
		type ExpensifyCardBankAccountSettings = {

		/** Expensify cards bank account settings */
		EXPENSIFY_CARD_BANK_ACCOUNT_SETTINGS: 'expensifyCardBankAccountSettings_',

Conversation

bernhardoj commented Mar 31, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 31, 2025

Uh oh!

allgandalf commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MariaHCD Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

MariaHCD Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

MariaHCD Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MariaHCD Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allgandalf commented Apr 1, 2025 •

edited

Loading

bernhardoj Apr 4, 2025 •

edited

Loading