Workspace chats and rooms disappear from the LHN after being deleted by narefyev91 · Pull Request #59360 · Expensify/App

narefyev91 · 2025-03-31T13:56:01Z

Explanation of Change

Workspace chats and rooms disappear from the LHN after being deleted

Fixed Issues

$ #56967
PROPOSAL: #56967 (comment)

Tests

Navigate to NewDot
Create a workspace
Delete the created workspace
Verify that in LHN all charts related to delete workspace are shown as archived

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Navigate to NewDot
Create a workspace
Delete the created workspace
Verify that in LHN all charts related to delete workspace are shown as archived

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-04-01T11:01:45Z

@rayane-d Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…r-removing-workspace

narefyev91 · 2025-04-03T08:04:11Z

@rayane-d friendly bump here

rayane-d · 2025-04-04T11:38:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-15.at.5.17.10.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-04-15.at.5.13.11.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-04-15.at.17.10.29.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-04-15.at.17.15.43.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-04-15.at.5.05.22.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-15.at.5.07.42.PM.mov

narefyev91 · 2025-04-07T08:25:49Z

hey @rayane-d any updates 😄

rayane-d · 2025-04-07T10:07:27Z

@narefyev91 I see two issues:

The #announce and #admins chats and threads do not include "(archived)" in their titles.
The chats disappear after clicking "Clear cache and restart" in settings.

Screen.Recording.2025-04-07.at.10.55.26.AM.mov

narefyev91 · 2025-04-07T11:02:56Z

@narefyev91 I see two issues:

The #announce and #admins chats and threads do not include "(archived)" in their titles.

The chats disappear after clicking "Clear cache and restart" in settings.

Screen.Recording.2025-04-07.at.10.55.26.AM.mov

Regarding the second one - Reports are not coming from BE. Probably it's the same check which we have on FE (that user notification is set to hidden). I think we need to trigger here BE dev to check - why after refresh - data is not coming from API side

…r-removing-workspace

rayane-d · 2025-04-07T11:16:19Z

Regarding the second one - Reports are not coming from BE. Probably it's the same check which we have on FE (that user notification is set to hidden). I think we need to trigger here BE dev to check - why after refresh - data is not coming from API side

Yeah, it seems that OpenApp is not returning reports with hidden notifications preference, and we should make an exception for archived reports when the app is in "most recent" mode. @mountiny, Could you please take a look at this?

narefyev91 · 2025-04-07T11:24:14Z

For the first point - yeah - for some reason code was not checking for specific workspace rooms like admin and announcement. Push one more if with correct flow

…r-removing-workspace

mountiny · 2025-04-07T16:04:17Z

Yeah, it seems that OpenApp is not returning reports with hidden notifications preference, and we should make an exception for archived reports when the app is in "most recent" mode. @mountiny, Could you please take a look at this?

That is on purpose, we do not return chat reports with hidden notification preference. This is intentional.

Right now because of UX we do not return the hidden reports in Search, but that will change - then the users will be able to search for the reports with hidden preference

mountiny · 2025-04-07T17:00:38Z

@narefyev91 @rayane-d users should be able to find the archived rooms in Search even if the notification preference is hidden so we should be good

narefyev91 · 2025-04-14T08:24:09Z

@rayane-d ready for re-review

rayane-d · 2025-04-15T15:18:26Z

@narefyev91 We got conflicts

…r-removing-workspace

…r-removing-workspace # Conflicts: # src/libs/ReportUtils.ts

narefyev91 · 2025-04-15T16:09:17Z

@rayane-d updated

rayane-d

LGTM and tests well 👍

melvin-bot · 2025-04-15T16:18:47Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #56967 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Valforte

LGTM

OSBotify · 2025-04-15T21:45:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:39:11Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-18T20:31:06Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

ishpaul777 · 2025-07-15T20:02:36Z

            isSystemChat ||
            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
            report.isPinned ||
+            (!isInFocusMode && isArchivedReportWithID(report.reportID)) ||


{BZ CHECKLIST} from #64363, we remove this conditional to always hide archived report from LHN regardless isInFocusMode

Workspace chats and rooms disappear from the LHN after being deleted

9abb573

narefyev91 marked this pull request as ready for review April 1, 2025 11:01

narefyev91 requested a review from a team as a code owner April 1, 2025 11:01

melvin-bot Bot requested review from rayane-d and removed request for a team April 1, 2025 11:01

Merge branch 'refs/heads/main' into fix-room-and-chat-visibility-afte…

8dc09d3

…r-removing-workspace

Merge branch 'refs/heads/main' into fix-room-and-chat-visibility-afte…

2047259

…r-removing-workspace

add archived to admin and announce room

400be80

rayane-d reviewed Apr 7, 2025

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

narefyev91 added 2 commits April 7, 2025 17:42

Merge branch 'refs/heads/main' into fix-room-and-chat-visibility-afte…

e1b0285

…r-removing-workspace

remove condition

5f72b33

mountiny assigned narefyev91 Apr 7, 2025

Christinadobrzyn mentioned this pull request Apr 7, 2025

[Due for payment 2025-04-25] [$250] LHN - Workspace chats and rooms disappear from the LHN after being deleted #56967

Closed

8 tasks

narefyev91 added 2 commits April 8, 2025 09:55

fix reserved names visibility

b80f9b6

prettier

6757cc6

narefyev91 requested a review from rayane-d April 8, 2025 07:13

narefyev91 added 2 commits April 15, 2025 18:29

Merge branch 'refs/heads/main' into fix-room-and-chat-visibility-afte…

ea88cc9

…r-removing-workspace

Merge branch 'refs/heads/main' into fix-room-and-chat-visibility-afte…

184d51e

…r-removing-workspace # Conflicts: # src/libs/ReportUtils.ts

clean up

9d3feef

rayane-d approved these changes Apr 15, 2025

View reviewed changes

melvin-bot Bot requested a review from Valforte April 15, 2025 16:18

Valforte approved these changes Apr 15, 2025

View reviewed changes

Valforte merged commit 238dcab into Expensify:main Apr 15, 2025

github-actions Bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

ishpaul777 reviewed Jul 15, 2025

View reviewed changes

Conversation

narefyev91 commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 1, 2025

Uh oh!

narefyev91 commented Apr 3, 2025

Uh oh!

rayane-d commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 commented Apr 7, 2025

Uh oh!

rayane-d commented Apr 7, 2025

Uh oh!

narefyev91 commented Apr 7, 2025

Uh oh!

rayane-d commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

narefyev91 commented Apr 7, 2025

Uh oh!

Uh oh!

mountiny commented Apr 7, 2025

Uh oh!

mountiny commented Apr 7, 2025

Uh oh!

narefyev91 commented Apr 14, 2025

Uh oh!

rayane-d commented Apr 15, 2025

Uh oh!

narefyev91 commented Apr 15, 2025

Uh oh!

rayane-d left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Apr 15, 2025

Uh oh!

Valforte left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

ishpaul777 Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

narefyev91 commented Mar 31, 2025 •

edited

Loading

rayane-d commented Apr 4, 2025 •

edited

Loading

rayane-d commented Apr 7, 2025 •

edited

Loading