Upgrade Expo to fix Android Hybrid app crash by VickyStash · Pull Request #59377 · Expensify/App

VickyStash · 2025-03-31T15:05:41Z

Explanation of Change

Upgrade Expo to fix Android Hybrid app crash

Fixed Issues

$ #59335
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13513

Tests

Verify that no errors appear in the JS console

Open the app and log in.
Test basic app functionality:
2.1 send a message
2.2 create an expense
2.3 send a photo attachment

Offline tests

Same, as in the Tests section.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as in the Tests section.

PR Author Checklist

Screenshots/Videos

Android: Native

android_standalone.mp4

Android: mWeb Chrome

android_web.mp4

iOS: Native

ios_standalone.mp4

iOS: mWeb Safari

ios_web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

github-actions · 2025-03-31T15:05:53Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-01T08:54:21Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…-expo-upgrade # Conflicts: # package-lock.json # package.json

github-actions · 2025-04-01T09:09:47Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-01T09:14:38Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2025-04-01T13:52:14Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in

LGTM, just one comment

war-in · 2025-04-01T13:57:19Z

Is that included in the new version? Just making sure it's not removed by mistake

Yep, necessary updates were merged to the expo around one month ago: https://github.com/expo/expo/pull/35243/files

mountiny · 2025-04-01T21:49:47Z

@hungvu193 Can you please test and do the checklist on this one and the linked mobile-expensify PR? Thanks!

github-actions · 2025-04-01T21:50:02Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

hungvu193 · 2025-04-02T01:20:05Z

@hungvu193 Can you please test and do the checklist on this one and the linked mobile-expensify PR? Thanks!

Sure

hungvu193 · 2025-04-02T10:45:57Z

@VickyStash Oh wait, how can I set up my hybrid submodule to use your https://github.com/Expensify/Mobile-Expensify/pull/13513 here?

I tried to fetch it to my submodule but callstack fork of MobileExpensify is private repo

mountiny · 2025-04-02T10:51:09Z

Seems like the build failed https://github.com/Expensify/App/actions/runs/14206731710/job/39806042134 retrying

@hungvu193 You could pull the branch to your locally Mobile-Expensify dir in App I think

github-actions · 2025-04-02T10:51:19Z

🚧 @mountiny has triggered a test app build. You can view the workflow run here.

hungvu193 · 2025-04-02T10:54:12Z

@hungvu193 You could pull the branch to your locally Mobile-Expensify dir in App I think

I realized the changes from https://github.com/Expensify/Mobile-Expensify/pull/13513 are only podlock.file, so I don't need to pull it. I can just do it myself. I'll start to test it now

hungvu193 · 2025-04-02T13:49:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-02.at.19.12.47.mov

Screen.Recording.2025-04-02.at.19.14.26.mov

Android: mWeb Chrome

Screen.Recording.2025-04-02.at.20.14.02.mov

iOS: Native

Screen.Recording.2025-04-02.at.20.47.35.mov

iOS: mWeb Safari

Screen.Recording.2025-04-02.at.20.16.41.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-02.at.20.12.51.mov

MacOS: Desktop

Screen.Recording.2025-04-02.at.20.17.17.mov

hungvu193

Tests well!

VickyStash · 2025-04-03T13:07:54Z

@mountiny all yours!

mountiny

Thanks!

OSBotify · 2025-04-04T08:53:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-07T23:09:04Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T02:14:20Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:32:41Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

Upgrade expo to 52.0.41

b7544f4

VickyStash mentioned this pull request Mar 31, 2025

[Due for payment 2025-04-16] Investigate Android Hybrid app crash java.lang.IllegalStateException #59335

Closed

Podfile.lock updates

6b340b1

VickyStash added 2 commits April 1, 2025 10:58

Merge branch 'refs/heads/main' into VickyStash/bugfix/59335-fix-crash…

ec58f21

…-expo-upgrade # Conflicts: # package-lock.json # package.json

package-lock.json updates

a84e41c

gh actions updates

fec435f

VickyStash marked this pull request as ready for review April 1, 2025 13:52

VickyStash requested a review from a team as a code owner April 1, 2025 13:52

melvin-bot Bot requested review from hungvu193 and removed request for a team April 1, 2025 13:52

war-in approved these changes Apr 1, 2025

View reviewed changes

mountiny assigned VickyStash Apr 1, 2025

hungvu193 approved these changes Apr 2, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 2, 2025 13:50

mountiny approved these changes Apr 4, 2025

View reviewed changes

mountiny merged commit 1190a9e into Expensify:main Apr 4, 2025

github-actions Bot mentioned this pull request Apr 7, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

Conversation

VickyStash commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Mar 31, 2025

Uh oh!

github-actions Bot commented Apr 1, 2025

Uh oh!

github-actions Bot commented Apr 1, 2025

Uh oh!

github-actions Bot commented Apr 1, 2025

Uh oh!

melvin-bot Bot commented Apr 1, 2025

Uh oh!

war-in left a comment

Choose a reason for hiding this comment

Uh oh!

war-in Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

VickyStash Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny commented Apr 1, 2025

Uh oh!

github-actions Bot commented Apr 1, 2025

Uh oh!

hungvu193 commented Apr 2, 2025

Uh oh!

hungvu193 commented Apr 2, 2025

Uh oh!

mountiny commented Apr 2, 2025

Uh oh!

github-actions Bot commented Apr 2, 2025

Uh oh!

hungvu193 commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Apr 2, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 left a comment

Choose a reason for hiding this comment

Uh oh!

VickyStash commented Apr 3, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 4, 2025

Uh oh!

github-actions Bot commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VickyStash commented Mar 31, 2025 •

edited

Loading

hungvu193 commented Apr 2, 2025 •

edited

Loading