feature: Background updates on mobile by mananjadhav · Pull Request #5953 · Expensify/App

mananjadhav · 2021-10-19T22:19:32Z

cc - @Julesssss

Details

Fixed Issues

$ #4264

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

mananjadhav · 2021-10-19T22:21:09Z

@Julesssss I need a little help with testing this in iOS. I am stuck where I am able to run basic console.log etc but not able to do the API call. The job always times out and then onTimeout gets called. Will you be able to test this against iOS and help me with the results?

Julesssss · 2021-10-22T16:33:46Z

Sorry @mananjadhav, I didn't get to this task this week. I'd be happy to investigate next week though!

mananjadhav · 2021-10-29T15:07:44Z

@Julesssss Bump

Julesssss · 2021-10-29T15:17:20Z

Thanks for the bump, I've been pretty busy this week and didn't manage to get to this. But I'll definitely be able to review next week.

mananjadhav · 2021-10-29T15:49:25Z

Sure. Quick question outside the PR, do we have a process where if contributors want to go on vacation they can notify?

Julesssss · 2021-11-07T14:35:48Z

Sure. Quick question outside the PR, do we have a process where if contributors want to go on vacation they can notify?

We don't at the moment, but I don't think it's a problem here as I've caused some delays here myself.

Julesssss · 2021-12-09T11:59:49Z

Hey @mananjadhav. Once again, sorry for my long delay here. Now that I'm back and caught up I will make sure not to delay us again.

Do you remember what exactly was failing? I'm seeing a lot of these errors in both iOS and Android:

mananjadhav · 2021-12-09T12:26:30Z

I'll check and get back to you. But as far as I remember the task was getting initialized but was getting timed out.

kidroca

Left some notes mostly on changes that shouldn't have been committed

kidroca · 2021-12-10T19:35:28Z

+const headlessTask = async (event) => { // eslint-disable-line
+
+    // Get task id from event {}:


The task should not be defined here in index.js
It should be defined in libs and then registered during setup or in Expensify.js didMount phase

I see this is already done, and there's a lib about this, so the code here seems like a leftover that should be removed

kidroca · 2021-12-10T19:37:59Z

-						DevelopmentTeam = 368M544MTT;
+						DevelopmentTeam = 72TRNPHV7D;
 						LastSwiftMigration = 1230;
-						ProvisioningStyle = Manual;
+						ProvisioningStyle = Automatic;


This should probably be reverted

kidroca · 2021-12-10T19:38:21Z

-				CODE_SIGN_IDENTITY = "iPhone Distribution";
-				CODE_SIGN_STYLE = Manual;
+				CODE_SIGN_IDENTITY = "Apple Development";
+				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 3;
-				DEVELOPMENT_TEAM = 368M544MTT;
+				DEVELOPMENT_TEAM = 72TRNPHV7D;


This should definitely be reverted

kidroca · 2021-12-10T19:38:37Z

-				PROVISIONING_PROFILE_SPECIFIER = chat_expensify_appstore;
+				PROVISIONING_PROFILE_SPECIFIER = "";


This should definitely be reverted

kidroca · 2021-12-10T19:38:45Z

-				CODE_SIGN_IDENTITY = "iPhone Distribution";
-				CODE_SIGN_STYLE = Manual;
+				CODE_SIGN_IDENTITY = "Apple Development";
+				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 3;
-				DEVELOPMENT_TEAM = 368M544MTT;
+				DEVELOPMENT_TEAM = 72TRNPHV7D;


This should definitely be reverted

kidroca · 2021-12-10T19:38:52Z

-				PROVISIONING_PROFILE_SPECIFIER = chat_expensify_appstore;
+				PROVISIONING_PROFILE_SPECIFIER = "";


This should definitely be reverted

botify · 2022-01-11T10:43:50Z

@robertjchen looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

robertjchen · 2022-01-11T10:47:56Z

Wait, what happened here? I merged #6641 but somehow this was merged as well? 🤔

robertjchen · 2022-01-11T10:48:50Z

I'm going to revert this- this was not supposed to be merged.

Julesssss · 2022-01-11T10:52:25Z

Wow, that was unexpected!

It's my fault, as my PR accidentally branched from this PR. I made a lot of changes and rebased a couple of times, which made removing these commits very time-consuming (I didn't notice this immediately).

~~I'll get this PR reverted~~ No need to revert actually, the code is NOT on main, but the commits are a part of git history

mananjadhav · 2022-01-11T10:53:32Z

Wooahh, let me close this PR and raise one more as draft that shouldn't have allow merging?

Julesssss · 2022-01-11T11:02:02Z

Hi @mananjadhav. Don't worry, I think you can just create a new PR. You might need to cherry-pick the commits though, so they have a new commit ID.

I had a large PR that accidentally branched from yours, I tried to rebase them away but was unsuccessful as it was such a large PR with many conflicts over the last month.

I think the draft status was ignored by Github as technically your commits are now in main -- but they are not aware that I reverted in my later commits

mananjadhav · 2022-01-11T11:04:35Z

I'll cherry-pick or move the commits as a fresh set of changes. Tracking my branch separately.

Julesssss · 2022-01-11T11:13:23Z

Thanks, @mananjadhav. Sorry for the confusion.

mananjadhav added 2 commits September 14, 2021 01:32

feat(periodic-background-updates): Initial setup for background fetch

c0eb6d8

fix(background-fetch): WIP Adding headless task

b17d2ca

Christinadobrzyn mentioned this pull request Nov 8, 2021

[HOLD][Expensify/#219254][$2000] Implement periodic background updates on mobile, keeping Onyx in sync #4264

Closed

5 tasks

kidroca suggested changes Dec 10, 2021

View reviewed changes

robertjchen merged commit 11e9f17 into Expensify:main Jan 11, 2022

botify added the Emergency label Jan 11, 2022

robertjchen removed the Emergency label Jan 11, 2022

		const headlessTask = async (event) => { // eslint-disable-line

		// Get task id from event {}:

		PROVISIONING_PROFILE_SPECIFIER = chat_expensify_appstore;
		PROVISIONING_PROFILE_SPECIFIER = "";

Conversation

mananjadhav commented Oct 19, 2021

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Uh oh!

mananjadhav commented Oct 19, 2021

Uh oh!

Julesssss commented Oct 22, 2021

Uh oh!

mananjadhav commented Oct 29, 2021

Uh oh!

Julesssss commented Oct 29, 2021

Uh oh!

mananjadhav commented Oct 29, 2021

Uh oh!

Julesssss commented Nov 7, 2021

Uh oh!

Julesssss commented Dec 9, 2021

Uh oh!

mananjadhav commented Dec 9, 2021

Uh oh!

kidroca left a comment

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

kidroca Dec 10, 2021

Choose a reason for hiding this comment

Uh oh!

botify commented Jan 11, 2022

Uh oh!

robertjchen commented Jan 11, 2022

Uh oh!

robertjchen commented Jan 11, 2022

Uh oh!

Julesssss commented Jan 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Jan 11, 2022

Uh oh!

Julesssss commented Jan 11, 2022

Uh oh!

mananjadhav commented Jan 11, 2022

Uh oh!

Julesssss commented Jan 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Julesssss commented Jan 11, 2022 •

edited

Loading