Skip to content

Hide distance menu items if no waypoints are available #59581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neil-marcellini merged 3 commits into from
Apr 4, 2025
Merged

Hide distance menu items if no waypoints are available #59581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f84e5ad
Hide distance menu items if no waypoints are available
narefyev91 Apr 3, 2025
a1ac576
Show not found page if user tries to open distance page directly
narefyev91 Apr 3, 2025
4eaeba6
Merge branch 'refs/heads/main' into hide-distance-fields-if-no-waypoi…
narefyev91 Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/MoneyRequestView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ function MoneyRequestView({report, shouldShowAnimatedBackground, readonly = fals
numberOfLinesTitle={0}
/>
</OfflineWithFeedback>
{isDistanceRequest ? (
{isDistanceRequest && transaction?.comment?.waypoints ? (
distanceRequestFields
) : (
<OfflineWithFeedback pendingAction={getPendingFieldAction('merchant')}>
Expand Down
1 change: 1 addition & 0 deletions src/pages/iou/request/step/IOURequestStepDistance.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,7 @@ function IOURequestStepDistance({
headerTitle={translate('common.distance')}
onBackButtonPress={navigateBack}
testID={IOURequestStepDistance.displayName}
shouldShowNotFoundPage={isEditing && !transaction?.comment?.waypoints}

@dukenv0307 dukenv0307 Aug 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from #67142, we also should show not found page if users can't edit

shouldShowWrapper={!isCreatingNewRequest}
>
<>
Expand Down