Skip to content

Existing connections is not scrollable #59593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 5 commits into from
Apr 7, 2025
+4 −7
Merged

Existing connections is not scrollable #59593

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00069db
Existing connections is not scrollable
nkdengineer Apr 3, 2025
ce259b0
remove View
nkdengineer Apr 4, 2025
5b3e2c4
remove unused View
nkdengineer Apr 4, 2025
5ec55f1
fix background
nkdengineer Apr 4, 2025
146cd00
lint fix
nkdengineer Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/pages/workspace/accounting/intacct/ExistingConnectionsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import React from 'react';
import {View} from 'react-native';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import {LinkCopy} from '@components/Icon/Expensicons';
import MenuItem from '@components/MenuItem';
import MenuItemList from '@components/MenuItemList';
import ScreenWrapper from '@components/ScreenWrapper';
import ScrollView from '@components/ScrollView';
import Text from '@components/Text';
import useLocalize from '@hooks/useLocalize';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {copyExistingPolicyConnection} from '@libs/actions/connections';
import {getAdminPoliciesConnectedToSageIntacct} from '@libs/actions/Policy/Policy';
Expand All @@ -25,7 +24,6 @@ type ExistingConnectionsPageProps = PlatformStackScreenProps<SettingsNavigatorPa
function ExistingConnectionsPage({route}: ExistingConnectionsPageProps) {
const {translate, datetimeToRelative} = useLocalize();
const styles = useThemeStyles();
const theme = useTheme();
const policiesConnectedToSageIntacct = getAdminPoliciesConnectedToSageIntacct();
const policyID: string = route.params.policyID;

Expand Down Expand Up @@ -63,13 +61,12 @@ function ExistingConnectionsPage({route}: ExistingConnectionsPageProps) {
shouldShowBackButton
onBackButtonPress={() => Navigation.goBack()}
/>
<View style={[styles.flex1]}>
<ScrollView style={[styles.flex1]}>
<Text style={[styles.mh5, styles.mb4]}>{translate('workspace.common.existingConnectionsDescription', {connectionName: CONST.POLICY.CONNECTIONS.NAME.SAGE_INTACCT})}</Text>
<MenuItem
title={translate('workspace.common.createNewConnection')}
icon={LinkCopy}
iconFill={theme.white}
iconStyles={{borderRadius: variables.componentBorderRadiusNormal, backgroundColor: theme.icon}}
iconStyles={{borderRadius: variables.componentBorderRadiusNormal}}
shouldShowRightIcon
onPress={() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_SAGE_INTACCT_PREREQUISITES.getRoute(policyID, Navigation.getActiveRoute()))}
/>
Expand All @@ -78,7 +75,7 @@ function ExistingConnectionsPage({route}: ExistingConnectionsPageProps) {
menuItems={menuItems}
shouldUseSingleExecution
/>
</View>
</ScrollView>
</ScreenWrapper>
);
}
Expand Down