Use react-native-airship 21.4.0 by arosiclair · Pull Request #59662 · Expensify/App

arosiclair · 2025-04-04T13:49:48Z

HELD on https://github.com/Expensify/Mobile-Expensify/pull/13520

Explanation of Change

Upgrades react-native-airship so we can use a new option to switch foreground notification presentation control between native and JS code

Fixed Issues

Part of #58126

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13533

Tests

Classic push notification

Log into iOS/Android
Accept push notification permission
Switch to Classic
Send yourself a DM
Verify a push notification is received for the message
Select the push notification
Verify it opens in the new experience
- Note: there's an existing bug where this only navigates to the homescreen instead of directly to the chat

New experience push notification

Log into iOS/Android
Accept push notification permission
Switch to the new experience
Send yourself a DM
Verify a push notification displays
Select the push notification
Verify it navigates to the chat

Offline tests

None

QA Steps

None

PR Author Checklist

Screenshots/Videos

Android: Native

iOS: Native

ScreenRecording_04-09-2025.15-20-35_1.mov

ScreenRecording_04-09-2025.15-23-44_1.mov

stops importing airship lib in the mock which causes errors

github-actions · 2025-04-04T15:39:37Z

🚧 @arosiclair has triggered a test app build. You can view the workflow run here.

…ip-21-4

github-actions · 2025-04-09T19:26:52Z

🚧 @arosiclair has triggered a test app build. You can view the workflow run here.

melvin-bot · 2025-04-09T20:12:57Z

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2025-04-09T20:13:55Z

HybridApp builds won't pass in GH actions until we merge the Mobile-Expensify PR. First let's get C+ tests done and then we'll review and merge both PR's together @jayeshmangwani

jayeshmangwani · 2025-04-10T07:37:43Z

@arosiclair, something seems off with the ad hoc build. I was able to get the notification once only, but after that, I'm not receiving any notifications on Android.

jayeshmangwani · 2025-04-10T10:28:00Z

I think notifications aren't working on ad-hoc builds. Tested another ad-hoc on Android, and still not receiving any notifications.

arosiclair · 2025-04-10T15:00:58Z

I think notifications aren't working on ad-hoc builds. Tested another ad-hoc on Android, and still not receiving any notifications.

Ah yeah you're right. Push notifications aren't configured for adhoc builds. I'll have these reviewed internally.

jayeshmangwani · 2025-04-10T15:01:51Z

Thanks

war-in · 2025-04-14T10:52:51Z

Hi 👋 It looks like the OD PR has been merged, but it requires changes from this PR, so the iOS dev builds from both App main and Mobile-Expensify main branches are failing.
Would be nice to merge both PRs at the same time to avoid such situations 🙏

cc @arosiclair

war-in · 2025-04-14T11:27:34Z

FYI, we're reverting the Mobile-Expensify PR here

arosiclair · 2025-04-14T14:17:45Z

@jasperhuangg can you review and do the checklist? We just need to test Android and iOS.

github-actions · 2025-04-14T20:48:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59662/NewExpensify.dmg	https://59662.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

jasperhuangg · 2025-04-14T21:06:30Z

@arosiclair Do you mind pulling main? It seems the build is failing because a patch is outdated.

arosiclair · 2025-04-15T13:00:40Z

@arosiclair Do you mind pulling main? It seems the build is failing because a patch is outdated.

I'll pull main, but you also need to checkout the Mobile-E branch in your submodule to fix that

…ip-21-4

jasperhuangg

I'm going to approve first so it's not held on me, but I'm having trouble building this locally (I think it is unrelated to the changes from this PR) so I'm unable to complete the checklist as of now

jasperhuangg · 2025-04-15T19:24:48Z

@inimaga you were assigned on the associated Mobile-Expensify PR, can you see if you can build this with those changes and complete this review please?

Julesssss · 2025-04-15T20:05:11Z

@arosiclair can you just make sure we internalQA these PRs on staging please

Julesssss · 2025-04-15T20:56:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

arosiclair · 2025-04-15T21:19:21Z

I don't know why but I can't restart the GH action for the Android build 😕

arosiclair · 2025-04-15T21:30:52Z

The HybridApp build actions don't seem to be using the latest changes in main. I'm just gonna run an AdHoc build and if it works I'll merge.

Julesssss · 2025-04-15T21:34:10Z

Might merging main resolve this, assuming main points to the latest Mobile-Expensify commit now?

github-actions · 2025-04-15T21:36:24Z

🚧 @arosiclair has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-15T22:18:10Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59662-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59662-hybrid/index.html

Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

melvin-bot · 2025-04-15T22:19:11Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

arosiclair · 2025-04-15T22:19:46Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

The HybridApp build checks failed so I tested with an AdHoc build instead

OSBotify · 2025-04-15T22:29:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:39:26Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

arosiclair · 2025-04-17T16:42:07Z

Internal QA ✅

iOS

ScreenRecording_04-17-2025.12-22-07_1.MP4

Android

screen-20250417-123518.mp4

github-actions · 2025-04-18T20:31:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

rayane-d · 2025-04-25T11:32:51Z

Hi! Just so you know, I needed to revert this PR locally to build the app on Xcode 15.3. Apparently, this is because Airship and AirshipFrameworkProxy Pods for this react-native-airship version require Swift v6.

arosiclair · 2025-04-25T13:53:45Z

Thanks for the heads up. Looks like Xcode 16+ is needed for Swift v6

use react-native-airship 21.4.0

e834868

arosiclair self-assigned this Apr 4, 2025

fix tests

68a6b22

stops importing airship lib in the mock which causes errors

arosiclair force-pushed the arosiclair-airship-21-4 branch from 1b9019a to 68a6b22 Compare April 4, 2025 14:48

update pods

8cc9a67

arosiclair added the Ready To Build label Apr 4, 2025

arosiclair mentioned this pull request Apr 4, 2025

[HIGH] Android - Switching to Classic breaks foreground push notifications in the new experience #58126

Closed

8 tasks

arosiclair added 4 commits April 9, 2025 11:38

use react-native-airship 21.4.1

3c8144b

Merge branch 'main' of github.com:Expensify/App into arosiclair-airsh…

a5c64f8

…ip-21-4

Merge branch 'main' of github.com:Expensify/App into arosiclair-airsh…

307d7d6

…ip-21-4

package-lock diff

8e65875

This comment has been minimized.

Sign in to view

arosiclair marked this pull request as ready for review April 9, 2025 20:12

arosiclair requested a review from a team as a code owner April 9, 2025 20:12

melvin-bot Bot requested review from jasperhuangg and removed request for a team April 9, 2025 20:12

arosiclair requested a review from jayeshmangwani April 9, 2025 20:13

jayeshmangwani mentioned this pull request Apr 13, 2025

[ON HOLD for #13533] [$250] iOS Hybrid - iOS 15.8.3 - The app crashes after opening #58782

Closed

8 tasks

arosiclair removed the request for review from jayeshmangwani April 14, 2025 14:15

Merge branch 'main' of github.com:Expensify/App into arosiclair-airsh…

307b5dc

…ip-21-4

war-in mentioned this pull request Apr 15, 2025

[Due for payment 2025-07-04] [Due for payment 2025-06-18] Upgrade React Native to 0.79 #57511

Closed

jasperhuangg approved these changes Apr 15, 2025

View reviewed changes

Julesssss reviewed Apr 15, 2025

View reviewed changes

Comment thread __mocks__/@ua/react-native-airship.ts

Julesssss approved these changes Apr 15, 2025

View reviewed changes

arosiclair added the InternalQA This pull request required internal QA label Apr 15, 2025

arosiclair merged commit c408101 into main Apr 15, 2025

arosiclair deleted the arosiclair-airship-21-4 branch April 15, 2025 22:19

melvin-bot Bot added the Emergency label Apr 15, 2025

arosiclair removed the Emergency label Apr 15, 2025

github-actions Bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

Conversation

arosiclair commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 4, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

This comment has been minimized.

melvin-bot Bot commented Apr 9, 2025

Uh oh!

arosiclair commented Apr 9, 2025

Uh oh!

jayeshmangwani commented Apr 10, 2025

Uh oh!

jayeshmangwani commented Apr 10, 2025

Uh oh!

arosiclair commented Apr 10, 2025

Uh oh!

jayeshmangwani commented Apr 10, 2025

Uh oh!

war-in commented Apr 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

war-in commented Apr 14, 2025

Uh oh!

arosiclair commented Apr 14, 2025

Uh oh!

github-actions Bot commented Apr 14, 2025

Uh oh!

jasperhuangg commented Apr 14, 2025

Uh oh!

arosiclair commented Apr 15, 2025

Uh oh!

jasperhuangg left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg commented Apr 15, 2025

Uh oh!

Uh oh!

Julesssss commented Apr 15, 2025

Uh oh!

Julesssss commented Apr 15, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

arosiclair commented Apr 15, 2025

Uh oh!

arosiclair commented Apr 15, 2025

Uh oh!

Julesssss commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 15, 2025

Uh oh!

melvin-bot Bot commented Apr 15, 2025

Uh oh!

arosiclair commented Apr 15, 2025

Uh oh!

OSBotify commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

arosiclair commented Apr 17, 2025

Internal QA ✅

Uh oh!

github-actions Bot commented Apr 18, 2025

Uh oh!

rayane-d commented Apr 25, 2025

Uh oh!

arosiclair commented Apr 25, 2025

Uh oh!

arosiclair commented Apr 4, 2025 •

edited

Loading

war-in commented Apr 14, 2025 •

edited

Loading