Feat: Identify and update all read-only push rows to be copiable via long-press or right click by sosek108 · Pull Request #59731 · Expensify/App

sosek108 · 2025-04-07T12:40:49Z

Explanation of Change

Across whole application users sees plenty of information which he could want to use outside of the application. To ensure seamingless experience it’s in best interest that important data is easy to copy and user has the same way to do so across whole application. To do so we’ve implemented mobile „long press to copy” or desktop „right click to copy” functionality on several application’s views.
1. Profile details
We can add this functionality to email field.
2. Preview of expense report
We can add this functionality to merchant and distance.
3. Workspace overview
We can add this functionality to company address
4. Card details
We can add this functionality to card number field.
5. Wallet page
We can add this functionality to balance field.

Fixed Issues

$ #58234
PROPOSAL: #58234 (comment)

Tests

Profile page

Open application
Go to any workspace -> members
Click on one of members and then click „Profile”
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on email
2. Desktop: right click on email
Perform the same test on account with only mobile phone login

Workspace overview

Open application
Go to any workspace not owned by the user -> Overview
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on address
2. Desktop: right click on address

Workspace members page

Open application
Go to any workspace -> Members -> Click on any member
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on email
2. Desktop: right click on email

Expense report preview

Open application
Open any paid report with merchant provided
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on merchant
2. Desktop: right click on merchant
Open any paid report with distance provided
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on distance
2. Desktop: right click on distance

Card details

Open application
Go to the Workspace settings->More features and enable Expensify Card.
Open the Expensify Card option in LHN.
Follow the instructions to issue a new card to some user B.
Login as user B.
Go to Settings -> Wallet, and open the card under Assigned cards.
Tap reveal details to get the card number to show.
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on card number
2. Desktop: right click on card number

Wallet page

Open application with user that has Wallet functionality setted up
Go to settings -> Wallet
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on balance
2. Desktop: right click on balance

Offline tests

N/A

QA Steps

Profile page

Open application
Go to any workspace -> members
Click on one of members and then click „Profile”
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on email
2. Desktop: right click on email
Perform the same test on account with only mobile phone login

Workspace overview

Open application
Go to any workspace not owned by the user -> Overview
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on address
2. Desktop: right click on address

Workspace members page

Open application
Go to any workspace -> Members -> Click on any member
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on email
2. Desktop: right click on email

Expense report preview

Open application
Open any paid report with merchant provided
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on merchant
2. Desktop: right click on merchant
Open any paid report with distance provided
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on distance
2. Desktop: right click on distance

Card details

Open application
Go to the Workspace settings->More features and enable Expensify Card.
Open the Expensify Card option in LHN.
Follow the instructions to issue a new card to some user B.
Login as user B.
Go to Settings -> Wallet, and open the card under Assigned cards.
Tap reveal details to get the card number to show.
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on card number
2. Desktop: right click on card number

Wallet page

Open application with user that has Wallet functionality setted up
Go to settings -> Wallet
Verify if copy functionality is available and copied value is proper
1. Mobile: Long press on balance
2. Desktop: right click on balance

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

![ios-workspace_members](https://github.com/user-attachments/assets/4f5ef5a3-b554-4404-aad2-537d4a3165a3) ![ios-profile_page](https://github.com/user-attachments/assets/4d0091e0-6872-49cb-ac1d-a4b150a1dba1) ![ios-worskpace_overview](https://github.com/user-attachments/assets/8bdcd696-b841-49d1-ada1-0ea6b8283823) ![ios-expense-merchant](https://github.com/user-attachments/assets/92c15e1b-c806-4ba2-adfc-d79b276e9531) ![ios-expense-distance](https://github.com/user-attachments/assets/c35421f0-4219-4f6e-b31b-0d59cd26b063)

iOS: mWeb Safari

MacOS: Chrome / Safari

![desktop-workspace_overview](https://github.com/user-attachments/assets/bc98add1-ca59-4322-a9bf-b74946e6dee7) ![desktop-workspace_members](https://github.com/user-attachments/assets/7d872f31-4547-46de-b07f-6046b350c7fc) ![desktop-profile](https://github.com/user-attachments/assets/c9b5ab76-a5c7-44f3-8899-d0c25da1b380) ![desktop-distance](https://github.com/user-attachments/assets/8c8b53cb-ba79-4035-918d-b650f5cb52d4) ![desktop-merchant](https://github.com/user-attachments/assets/b88d076d-72cb-41e6-899b-26a2fd6212a5)

MacOS: Desktop

melvin-bot · 2025-04-07T12:40:54Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jjcoffee · 2025-04-07T14:54:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2025-04-10_15.44.58.mp4

Android: mWeb Chrome

android-chrome-2025-04-10_15.49.41.mp4

iOS: Native

ios-app-2025-04-10_15.54.27.mp4

iOS: mWeb Safari

ios-safari-2025-04-10_15.56.42.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-04-10_14.46.25.mp4

MacOS: Desktop

desktop-app-2025-04-10_15.36.35.mp4

jjcoffee · 2025-04-08T09:33:43Z

@sosek108 Sorry for not bringing this up earlier, but why are we adding copy functionality to Company address (Workspace -> Overview) if it's not a read-only row?

jjcoffee · 2025-04-08T09:37:06Z

Go to preview of any submitted card

@sosek108 Could you clarify what this means? I don't see any copy functionality here, for example:

sosek108 · 2025-04-09T08:36:30Z

@sosek108 Could you also update the test steps to identify which field should be copyable?

Fields were already listed. I bolded them for visibility

sosek108 · 2025-04-09T08:37:26Z

@sosek108 Sorry for not bringing this up earlier, but why are we adding copy functionality to Company address (Workspace -> Overview) if it's not a read-only row?

This field is read only if workspace is not owned by you. Updated test steps

sosek108 · 2025-04-09T09:10:42Z

BUG: Copy icon shows next to email field on the member details screen that shows (before you click Profile) in the test steps.

Yeah, I've missed that one. I've updated that and created new entry in test steps Workspace members page.

After this commit a component CommunicationsLink is not used anymore. Should I delete it?

sosek108 · 2025-04-09T09:55:10Z

Go to preview of any submitted card

@sosek108 Could you clarify what this means? I don't see any copy functionality here, for example:

Honestly this one I had to guess as I have no access to Expensify Cards page. These information you are looking for should be hidden somewhere under button: Reveal details which is available on Expensify page.

I am more than happy to update test steps for that but can you help me with clarifing them?

sosek108 · 2025-04-09T10:10:14Z

@sosek108 Could you add screenshots please? Thanks! 🙏

I've added screenshots for iOS Native and desktop Web as functionality is same at others platforms

sosek108 · 2025-04-09T14:48:28Z

@jjcoffee Please be informed that I'll be out of office until monday

jjcoffee · 2025-04-10T12:51:11Z

Honestly this one I had to guess as I have no access to Expensify Cards page. These information you are looking for should be hidden somewhere under button: Reveal details which is available on Expensify page.

@blimpich Any ideas about this? I can only see the reveal details on the wallet page if I assign a card to another user, on the Expensify Card page as an admin I don't think the details are available.

blimpich · 2025-04-10T17:47:24Z

No I'm not sure. @jjcoffee you were able to show get the card page showing it seems? I'm not familiar with that part of the app, can you give @sosek108 steps for how to setup the app so that they can replicate the screen that you are able to see? Then when they get back on Monday they can look into it more.
if you're referring to the little document icon that is used to indicate if the row is copiable, yes, we want to get rid of that 👍
The intent was to have only read-only rows be copiable. If this turns out to be a big hassle we can come back to it (and involve the design team), but the expectation was that only where the data is immutable should there be copy functionality.

jjcoffee · 2025-04-11T12:25:01Z

@sosek108 Here are the steps to get an Expensify card added, and to get to the same screen as I have:

Go to the Workspace settings->More features and enable Expensify Card.
Open the Expensify Card option in LHN.
Follow the instructions to issue a new card to some user B.
Login as user B.
Go to Settings -> Wallet, and open the card under Assigned cards.
Tap reveal details to get the card number to show.

jjcoffee · 2025-04-11T12:25:35Z

After this commit a component CommunicationsLink is not used anymore. Should I delete it?

@sosek108 Yup, seems fine to me!

jjcoffee · 2025-04-11T12:28:40Z

The intent was to have only read-only rows be copiable. If this turns out to be a big hassle we can come back to it (and involve the design team), but the expectation was that only where the data is immutable should there be copy functionality.

@sosek108 Seems like this would be fairly easy to implement? Only enable copy if the row is not interactive, I guess.

sosek108 · 2025-04-14T11:28:10Z

The intent was to have only read-only rows be copiable. If this turns out to be a big hassle we can come back to it (and involve the design team), but the expectation was that only where the data is immutable should there be copy functionality.

@sosek108 Seems like this would be fairly easy to implement? Only enable copy if the row is not interactive, I guess.

9a3e507

Here is commit where I remove this func for active fields

sosek108 · 2025-04-14T11:28:43Z

After this commit a component CommunicationsLink is not used anymore. Should I delete it?

@sosek108 Yup, seems fine to me!

a8c8177 done here

jjcoffee · 2025-04-14T14:30:09Z

Nice, thanks! I'll have to retest tomorrow, I currently can't sign in.

sosek108 · 2025-04-15T09:07:59Z

@jjcoffee both styling and additional fields are fixed/added

jjcoffee

Thanks for the fixes! LGTM!

OSBotify · 2025-04-15T16:49:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-16T21:39:35Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.1.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-18T20:31:30Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.29-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

sosek108 requested a review from a team as a code owner April 7, 2025 12:40

melvin-bot Bot requested a review from jjcoffee April 7, 2025 12:40

melvin-bot Bot removed the request for review from a team April 7, 2025 12:40

sosek108 mentioned this pull request Apr 7, 2025

[Due for payment 2025-04-25] [$250] Identify and update all read-only push rows to be copiable via long-press or right click #58234

Closed

This comment was marked as resolved.

Sign in to view

blimpich assigned sosek108 Apr 10, 2025

This comment was marked as resolved.

Sign in to view

sosek108 added 13 commits April 15, 2025 10:38

Add long press to copy for ProfilePage

a90c505

Add long press to copy in MoneyRequest view

eb67664

Add long press to copy to workspace overview

d7eb6cb

Add long press to CardDetails

c970373

Add long press to copy to WalletPage

e46afff

Fix lint errors

a1657bb

Add long press functionality to WorkspaceMemberDetailsPage email field

472ef04

Fix lint error

4eb2c9a

Remove CommunicationsLink component as it's not used anymore.

2ad99d2

Remove long press to copy for fields that are not read only

1edfddd

Fix prettier errors

da4fade

add copy function to more fields on MoneyRequestView

d2ad42b

Move rateToDisplay logic from render part

c6b8a13

sosek108 force-pushed the feat/long-press-to-copy branch from 0b5828c to c6b8a13 Compare April 15, 2025 09:06

jjcoffee approved these changes Apr 15, 2025

View reviewed changes

melvin-bot Bot requested a review from blimpich April 15, 2025 13:02

blimpich approved these changes Apr 15, 2025

View reviewed changes

blimpich merged commit a25bc11 into Expensify:main Apr 15, 2025

github-actions Bot mentioned this pull request Apr 16, 2025

Deploy Checklist: New Expensify 2025-04-16 #60369

Closed

87 tasks

nkdengineer mentioned this pull request Apr 17, 2025

Profile - Missing the copy button in the Profile #60411

Closed

8 tasks

Conversation

sosek108 commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Profile page

Workspace overview

Workspace members page

Expense report preview

Card details

Wallet page

Offline tests

QA Steps

Profile page

Workspace overview

Workspace members page

Expense report preview

Card details

Wallet page

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 7, 2025

Uh oh!

jjcoffee commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

jjcoffee commented Apr 8, 2025

Uh oh!

jjcoffee commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

sosek108 commented Apr 9, 2025

Uh oh!

sosek108 commented Apr 9, 2025

Uh oh!

sosek108 commented Apr 9, 2025

Uh oh!

sosek108 commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sosek108 commented Apr 9, 2025

Uh oh!

sosek108 commented Apr 9, 2025

Uh oh!

jjcoffee commented Apr 10, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

blimpich commented Apr 10, 2025

Uh oh!

jjcoffee commented Apr 11, 2025

Uh oh!

jjcoffee commented Apr 11, 2025

Uh oh!

jjcoffee commented Apr 11, 2025

Uh oh!

sosek108 commented Apr 14, 2025

Uh oh!

sosek108 commented Apr 14, 2025

Uh oh!

jjcoffee commented Apr 14, 2025

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

sosek108 commented Apr 15, 2025

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Apr 15, 2025

Uh oh!

github-actions Bot commented Apr 16, 2025

Uh oh!

sosek108 commented Apr 7, 2025 •

edited

Loading

jjcoffee commented Apr 7, 2025 •

edited

Loading

jjcoffee commented Apr 8, 2025 •

edited

Loading

sosek108 commented Apr 9, 2025 •

edited

Loading