Skip to content

[No QA] Fix xargs usage in cleanupDeployBlockers#59751

Merged
jasperhuangg merged 1 commit into
mainfrom
Rory-FixCleanupDeployBlockersV3
Apr 7, 2025
Merged

[No QA] Fix xargs usage in cleanupDeployBlockers#59751
jasperhuangg merged 1 commit into
mainfrom
Rory-FixCleanupDeployBlockersV3

Conversation

@roryabraham

@roryabraham roryabraham commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Explanation of Change

I was misusing xargs before. $1 does not work with xargs. You have to use -I - otherwise the args just get appended to the end of the command. I thought this was working with my local testing:

gh issue list \
    --repo 'Expensify/App' \
    --state all \
    --label DeployBlockerCash \
    --json number \
    --jq '.[].number' \
    | xargs -L1 --max-procs=4 echo "RORY_DEBUG $1"                                                      
RORY_DEBUG  59639
RORY_DEBUG  59615
RORY_DEBUG  59476
RORY_DEBUG  59432
RORY_DEBUG  59417
RORY_DEBUG  59384
RORY_DEBUG  59357
RORY_DEBUG  59340
RORY_DEBUG  59060
RORY_DEBUG  58952
RORY_DEBUG  58771
RORY_DEBUG  58554
RORY_DEBUG  58166
RORY_DEBUG  58165
RORY_DEBUG  58128
RORY_DEBUG  57973
RORY_DEBUG  57968
RORY_DEBUG  57912
RORY_DEBUG  57909
RORY_DEBUG  57415
RORY_DEBUG  57410
RORY_DEBUG  57408
RORY_DEBUG  57156
RORY_DEBUG  56798
RORY_DEBUG  56719
RORY_DEBUG  56700
RORY_DEBUG  56664
RORY_DEBUG  56522
RORY_DEBUG  56500
RORY_DEBUG  56356

But that was just a coincidence since I put "$1" at the end. If you change that to:

gh issue list \                                     
    --repo 'Expensify/App' \
    --state all \
    --label DeployBlockerCash \
    --json number \
    --jq '.[].number' \
    | xargs -L1 --max-procs=4 echo "RORY_DEBUG $1 RORY_DEBUG"                                                     
RORY_DEBUG  RORY_DEBUG 56351
RORY_DEBUG  RORY_DEBUG 56328
RORY_DEBUG  RORY_DEBUG 56327
RORY_DEBUG  RORY_DEBUG 56321
RORY_DEBUG  RORY_DEBUG 56155
RORY_DEBUG  RORY_DEBUG 56148
RORY_DEBUG  RORY_DEBUG 56031
RORY_DEBUG  RORY_DEBUG 56150
RORY_DEBUG  RORY_DEBUG 56029
RORY_DEBUG  RORY_DEBUG 55940
RORY_DEBUG  RORY_DEBUG 55856
RORY_DEBUG  RORY_DEBUG 55733
RORY_DEBUG  RORY_DEBUG 55549
RORY_DEBUG  RORY_DEBUG 55524
RORY_DEBUG  RORY_DEBUG 55523
RORY_DEBUG  RORY_DEBUG 55276
RORY_DEBUG  RORY_DEBUG 55053
RORY_DEBUG  RORY_DEBUG 54942
RORY_DEBUG  RORY_DEBUG 54889
RORY_DEBUG  RORY_DEBUG 54846
RORY_DEBUG  RORY_DEBUG 54757
RORY_DEBUG  RORY_DEBUG 54753
RORY_DEBUG  RORY_DEBUG 54718
RORY_DEBUG  RORY_DEBUG 54697
RORY_DEBUG  RORY_DEBUG 54691
RORY_DEBUG  RORY_DEBUG 54553
RORY_DEBUG  RORY_DEBUG 54523
RORY_DEBUG  RORY_DEBUG 54514
RORY_DEBUG  RORY_DEBUG 54505
RORY_DEBUG  RORY_DEBUG 54503

You'll see the arg is just put at the end. So the proper fix is using the -I flag for xargs:

gh issue list \   
    --repo 'Expensify/App' \
    --state all \
    --label DeployBlockerCash \
    --json number \
    --jq '.[].number' \
    | xargs -L1 -I {} --max-procs=4 echo "RORY_DEBUG {} RORY_DEBUG"
RORY_DEBUG 56351 RORY_DEBUG
RORY_DEBUG 56328 RORY_DEBUG
RORY_DEBUG 56327 RORY_DEBUG
RORY_DEBUG 56321 RORY_DEBUG
RORY_DEBUG 56155 RORY_DEBUG
RORY_DEBUG 56150 RORY_DEBUG
RORY_DEBUG 56148 RORY_DEBUG
RORY_DEBUG 56031 RORY_DEBUG
RORY_DEBUG 56029 RORY_DEBUG
RORY_DEBUG 55940 RORY_DEBUG
RORY_DEBUG 55856 RORY_DEBUG
RORY_DEBUG 55733 RORY_DEBUG
RORY_DEBUG 55549 RORY_DEBUG
RORY_DEBUG 55524 RORY_DEBUG
RORY_DEBUG 55523 RORY_DEBUG
RORY_DEBUG 55276 RORY_DEBUG
RORY_DEBUG 55053 RORY_DEBUG
RORY_DEBUG 54942 RORY_DEBUG
RORY_DEBUG 54889 RORY_DEBUG
RORY_DEBUG 54846 RORY_DEBUG
RORY_DEBUG 54757 RORY_DEBUG
RORY_DEBUG 54753 RORY_DEBUG
RORY_DEBUG 54718 RORY_DEBUG
RORY_DEBUG 54697 RORY_DEBUG
RORY_DEBUG 54691 RORY_DEBUG
RORY_DEBUG 54553 RORY_DEBUG
RORY_DEBUG 54523 RORY_DEBUG
RORY_DEBUG 54514 RORY_DEBUG
RORY_DEBUG 54505 RORY_DEBUG
RORY_DEBUG 54503 RORY_DEBUG

Fixed Issues

$ https://expensify.slack.com/archives/C07J32337/p1744059125407189?thread_ts=1743687795.684829&cid=C07J32337

Tests

I also did a full E2E test of this command, and it worked. I'll be sure to go through and re-add the labels where necessary:

gh issue list \
    --repo 'Expensify/App' \
    --state all \
    --label DeployBlockerCash \
    --json number \
    --jq '.[].number' \
    | xargs --verbose -L1 -I {} --max-procs=4 gh issue edit {} --repo 'Expensify/App' --remove-label DeployBlockerCash
gh issue edit 59639 --repo Expensify/App --remove-label DeployBlockerCash
gh issue edit 59615 --repo Expensify/App --remove-label DeployBlockerCash
gh issue edit 59476 --repo Expensify/App --remove-label DeployBlockerCash
gh issue edit 59432 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59639
gh issue edit 59417 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59476
gh issue edit 59384 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59615
gh issue edit 59357 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59432
gh issue edit 59340 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59384
Updating 1 issues ⣟gh issue edit 59060 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59357
gh issue edit 58952 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59340
gh issue edit 58771 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59417
gh issue edit 58554 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/59060
gh issue edit 58166 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58952
gh issue edit 58165 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58771
gh issue edit 58128 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58554
gh issue edit 57973 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58165
gh issue edit 57968 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58128
gh issue edit 57912 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/58166
Updating 1 issues ⣟gh issue edit 57909 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57973
gh issue edit 57415 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57912
gh issue edit 57410 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57909
gh issue edit 57408 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57968
gh issue edit 57156 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57415
gh issue edit 56798 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57410
gh issue edit 56719 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57156
gh issue edit 56700 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/57408
gh issue edit 56664 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/56798
gh issue edit 56522 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/56719
gh issue edit 56500 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/56700
https://github.com/Expensify/App/issues/56522
gh issue edit 56356 --repo Expensify/App --remove-label DeployBlockerCash
https://github.com/Expensify/App/issues/56664
https://github.com/Expensify/App/issues/56500
https://github.com/Expensify/App/issues/56356

Offline tests

None.

QA Steps

None.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@roryabraham roryabraham requested a review from jasperhuangg April 7, 2025 21:08
@roryabraham roryabraham self-assigned this Apr 7, 2025
@roryabraham roryabraham requested a review from a team as a code owner April 7, 2025 21:08
@melvin-bot melvin-bot Bot removed the request for review from a team April 7, 2025 21:08
@melvin-bot

melvin-bot Bot commented Apr 7, 2025

Copy link
Copy Markdown

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jasperhuangg

jasperhuangg commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@jasperhuangg jasperhuangg merged commit 5253a37 into main Apr 7, 2025
@jasperhuangg jasperhuangg deleted the Rory-FixCleanupDeployBlockersV3 branch April 7, 2025 21:47
@github-actions github-actions Bot mentioned this pull request Apr 7, 2025
Closed
@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.1.24-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

1 similar comment
@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasperhuangg jasperhuangg jasperhuangg approved these changes

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roryabraham @jasperhuangg