[CP Staging] Fix - [Manager McTest] Only Allow Submitting Test Receipt to Manager by JKobrynski · Pull Request #59798 · Expensify/App

JKobrynski · 2025-04-08T10:01:59Z

Explanation of Change

Prevent users from changing recipient if the submitted receipt is a test receipt.

Fixed Issues

$ #59717 #59768
PROPOSAL: N/A

Tests

Log into the app with a fresh account
Click on the FAB and select 'Create expense'
Select "Scan" option (if not selected by default) and click "Try it out" once the tooltip shows up
You will be redirected to the confirmation step, make sure you can't change the recipient (Manager McTest)
Submit the expense
Click on FAB and select 'Create expense' option
Enter some value and proceed to the next step
Select Manager McTest as the recipient
Make sure you can change the recipient

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

web.mov

melvin-bot · 2025-04-08T10:02:05Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-04-08T10:26:53Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

grgia · 2025-04-08T12:45:01Z

tooltip doing weird things hmm

grgia · 2025-04-08T12:46:02Z

I think we can remove the hoverable color style @JKobrynski

grgia

NAB comment

grgia · 2025-04-08T12:57:23Z

Could you also link #59768

grgia · 2025-04-08T14:00:41Z

@@ -733,7 +738,7 @@ function MoneyRequestConfirmationList({
                ...participant,
                isSelected: false,
                isInteractive: !!isCreateExpenseFlow,


Should be this line!

JKobrynski · 2025-04-08T14:11:21Z

@grgia hover style removed!

github-actions · 2025-04-08T14:14:37Z

🚧 @grgia has triggered a test app build. You can view the workflow run here.

github-actions · 2025-04-08T14:41:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/59798-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/59798-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/59798/NewExpensify.dmg	https://59798.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

grgia

Clicking back button goes to the participants page, which still allows the user to select a diff account :'(

grgia · 2025-04-08T15:17:36Z

If in the test receipt flow, the back button should just go back to the create expense / scan page

DylanDylann · 2025-04-08T17:20:24Z

@eVoloshchak Let me review this one because I already took over this project from scratch

jasperhuangg · 2025-04-08T18:40:08Z

@DylanDylann @JKobrynski Please push this one forward with some urgency; this should be treated like an Hourly since it's blocking App deploy.

JKobrynski · 2025-04-08T20:53:03Z

@jasperhuangg @grgia I fixed the back button thing, I also removed that unnecessary double-negation. Let me know if you need anything else to be done here. Just FYI, if anything comes up, I will be fixing it in ~12 hours as it's already very late in my timezone.

jasperhuangg · 2025-04-08T20:54:19Z

I can review this now as this is blocking deploy, no need for C+

jasperhuangg · 2025-04-08T20:54:58Z

Tests well on my local dev env

jasperhuangg · 2025-04-08T20:55:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

We handled it in the thread!

OSBotify · 2025-04-09T00:45:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…7-only-allow-submitting-test-receipt-to-manager [CP Staging] Fix - [Manager McTest] Only Allow Submitting Test Receipt to Manager (cherry picked from commit e6a3e89) (CP triggered by jasperhuangg)

github-actions · 2025-04-09T01:30:10Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-04-09T02:16:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-04-09T04:34:32Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

shubham1206agra · 2025-05-15T08:56:46Z

                isSelected: false,
-                isInteractive: !!isCreateExpenseFlow,
-                shouldShowRightIcon: isCreateExpenseFlow,
+                isInteractive: isCreateExpenseFlow && !isTestReceipt,


This change created a bug. More details - #60649

only allow submitting test receipt to manager

7253dc1

JKobrynski requested a review from a team as a code owner April 8, 2025 10:02

melvin-bot Bot requested review from eVoloshchak and removed request for a team April 8, 2025 10:02

grgia added the CP Staging marks PRs that have been CP'd to staging label Apr 8, 2025

grgia assigned grgia and unassigned grgia Apr 8, 2025

grgia self-requested a review April 8, 2025 10:25

This comment has been minimized.

Sign in to view

grgia previously approved these changes Apr 8, 2025

View reviewed changes

grgia changed the title ~~Fix - [Manager McTest] Only Allow Submitting Test Receipt to Manager~~ [CP Staging] Fix - [Manager McTest] Only Allow Submitting Test Receipt to Manager Apr 8, 2025

grgia reviewed Apr 8, 2025

View reviewed changes

make menu item non interactive

4e66d77

JKobrynski dismissed grgia’s stale review via 4e66d77 April 8, 2025 14:11

grgia reviewed Apr 8, 2025

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList.tsx Outdated

grgia previously requested changes Apr 8, 2025

View reviewed changes

jasperhuangg mentioned this pull request Apr 8, 2025

Expense - Amount not correctly displayed when submitting track expense with test receipt. #59768

Closed

8 tasks

remove double negation, handle back button press

8433c46

jasperhuangg removed the request for review from eVoloshchak April 8, 2025 20:54

jasperhuangg approved these changes Apr 8, 2025

View reviewed changes

jasperhuangg merged commit e6a3e89 into Expensify:main Apr 9, 2025

github-actions Bot mentioned this pull request Apr 9, 2025

Deploy Checklist: New Expensify 2025-04-07 #59756

Closed

melvin-bot Bot mentioned this pull request Apr 9, 2025

[Due for payment 2025-04-17] [Due for payment 2025-04-16] [Manager McTest] Only Allow Submitting Test Receipt to Manager #59717

Closed

nkdengineer mentioned this pull request Apr 22, 2025

[Due for payment 2025-05-14] [$250] Web - To field has a hover effect but it is not clickable #60649

Closed

18 tasks

shubham1206agra reviewed May 15, 2025

View reviewed changes

Conversation

JKobrynski commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

This comment has been minimized.

grgia commented Apr 8, 2025

Uh oh!

grgia commented Apr 8, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Apr 8, 2025

Uh oh!

grgia Apr 8, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

grgia commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Apr 8, 2025

Uh oh!

jasperhuangg commented Apr 8, 2025

Uh oh!

JKobrynski commented Apr 8, 2025

Uh oh!

jasperhuangg commented Apr 8, 2025

Uh oh!

jasperhuangg commented Apr 8, 2025

Uh oh!

jasperhuangg commented Apr 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

github-actions Bot commented Apr 9, 2025

Uh oh!

shubham1206agra May 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JKobrynski commented Apr 8, 2025 •

edited

Loading

grgia commented Apr 8, 2025 •

edited

Loading