[CP Staging] Fix that Emoji Modal is under navigation bar on android#59829
Conversation
|
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@allgandalf Please don't review this one, it is a regression from one of my PR and @ZhenjaHorbach should review it, thanks! |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid.movAndroid: mWeb Chromeandroid-web.moviOS: Native2025-04-08.18.18.21.moviOS: mWeb Safariios-web.movMacOS: Chrome / SafariNA MacOS: DesktopNA |
|
LGTM ! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…gation [CP Staging] Fix that Emoji Modal is under navigation bar on android (cherry picked from commit bc906d7) (CP triggered by AndrewGable)
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 9.1.24-9 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
Explanation of Change
The
keyboardWillHideevent is not triggered on Android when theReportActionContextMenumodal is opened while the keyboard is on the screen.Fixed Issues
$ #59777
PROPOSAL: N/A
Tests
Precondition:
Device navigation is navigation bar instead of gestures.
Offline tests
N/A
QA Steps
same as tests above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
annnnd.webm
Android: mWeb Chrome
a-web.webm
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-08.at.16.14.16.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-04-08.at.16.12.01.mov