[No QA] Only load full policies one-by-one as needed

[roryabraham]

Details

So we want to make sure that whenever a workspace or any of its sub-pages attempts to render, then we'll load the full policy for that workspace. So whenever we navigate to a workspace page (and did not just come from one), then we'll load that full policy.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/181676

Tests

1. Sign into NewDot using an account with a workspace.
2. Go to /settings. Verify using logs or the network console that no full policy is loaded.
3. Click on an existing workspace. Verify using logs or the network console that the full policy is loaded.
4. Refresh the page. Verify using logs or the network console that the full policy is loaded.
5. Click on the back arrow. Verify you are taken back to the settings page.
6. Click on an existing workspace. Verify using logs or the network console that the full policy is loaded.
7. Click on a workspace sub-page. Verify using logs or the network console that no full policy is loaded.
8. Refresh the page on one of the workspace sub-pages. Verify using logs or the network console that the full policy is loaded.
9. Click on the x to close the modal. Verify that the full settings modal closes.

QA Steps

Only regression tests.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

[roryabraham]

Something I missed in this implementation – the WorkspaceInvitePage is in it's own navigator, so if you link directly to the workspace invite page then you're not guaranteed to have a policy loaded. I think this is just an oversight and it should really be in the same navigator as the rest of the workspace pages.

[roryabraham]

Something I missed in this implementation – the WorkspaceInvitePage is in it's own navigator, so if you link directly to the workspace invite page then you're not guaranteed to have a policy loaded. I think this is just an oversight and it should really be in the same navigator as the rest of the workspace pages.

I went ahead and addressed this and moved the WorkspaceInvitePage into the same navigator as the rest of the workspace pages.

[roryabraham]

Updated and ready for review!

[tgolen]

I chatted with Rory 1:1 and suggested the following changes:

1. Change API.getPolicyList() to only accept a single string argument for policyID and throw otherwise (this will remove the need to have a log)
2. Change the HOC so that it passes the policy object to the consumers (this is a more typical pattern for an HOC so it would make it more consistent)
3. Make sure the only pages that need the policy object are the ones using the HOC

[roryabraham]

PR has been updated per @tgolen's comment above ^

[tgolen]

Looks really good. Just this one thing I noticed.

[iwiznia]

You got conflicts

[Gonals]

Looking good overall, but there's a conflict!

[roryabraham]

Conflicts resolved!

[iwiznia]

TIL: Did not know this worked, thought you had to do lodashGet(data, ['policyList', 0], {});

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Gonals in version: 1.1.14-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅