Start generating internal QA checklist with assignments#6102
Merged
Conversation
yuwenmemon
changed the title
yuwenmemon
force-pushed
the
yuwen-internalQAChecklist
branch
from
a2f1687 to
7729245
Compare
yuwenmemon
changed the title
Contributor
Author
|
Removing HOLD! |
Jag96
previously approved these changes
Nov 9, 2021
Jag96
left a comment
Jag96
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will let @roryabraham have a look as well
roryabraham
requested changes
Nov 9, 2021
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
Contributor
|
@yuwenmemon You'll need to recompile actions and update the tests |
Contributor
Author
|
Yeah sorry bad internet - push was hanging |
roryabraham
approved these changes
Nov 10, 2021
Contributor
|
LGTM, thanks @yuwenmemon. Should we hold this till next week? |
Contributor
Author
|
It's not consumer-facing so I don't see a need to 🤷 |
Contributor
|
Okay, sounds good. I'll merge as soon as tests pass. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
70 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀
|
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pullerbearing (@Jag96)
cc @roryabraham
Details
Adds a new Internal QA section to the Staging Deploy checklist for issues tagged "Internal QA"
Fixed Issues
$ #5195
Tests
QA Steps