Fix - The header for track expense is different from regular expenses#61333
Merged
Merged
Conversation
Contributor
Reviewer Checklist
Screenshots/Videos |
Contributor
Contributor
|
And can you show what it looks like if you set a merchant, too? |
Contributor
|
But yeah, that is looking good to me 👍 |
Contributor
|
@shawnborton Here ya go: |
Contributor
|
Sweet, looks good on my end 👍 |
yuwenmemon
approved these changes
May 7, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Performance Comparison Report 📊 (1/12)Significant Changes To Duration
Show details
|
Contributor
Performance Comparison Report 📊 (10/12)Meaningless Changes To Duration (9/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (11/12)Meaningless Changes To Duration (10/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (12/12)Meaningless Changes To Duration (11/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (2/12)Meaningless Changes To Duration (1/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (3/12)Meaningless Changes To Duration (2/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (4/12)Meaningless Changes To Duration (3/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (5/12)Meaningless Changes To Duration (4/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (6/12)Meaningless Changes To Duration (5/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (7/12)Meaningless Changes To Duration (6/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (8/12)Meaningless Changes To Duration (7/11)Show entries
Show details
|
Contributor
Performance Comparison Report 📊 (9/12)Meaningless Changes To Duration (8/11)Show entries
Show details
|
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
90 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.42-0 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.1.43-5 🚀
|
16 tasks
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









Details
Fixed Issues
$ #61196
PROPOSAL: #61196 (comment)
Tests
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop