Only set locale language from preferences#6177
Merged
Merged
Conversation
nickmurray47
requested review from
a team and
MonilBhavsar
and removed request for
Luke9389
Contributor
Author
|
This is ready for review! |
Luke9389
approved these changes
Nov 2, 2021
5 tasks
MonilBhavsar
reviewed
Nov 3, 2021
Contributor
|
Considering it's Saturday for Monil, I'm going to merge this. I think it's fine for these PRs to coexist. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
70 tasks
Contributor
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The method
setLocaleupdates the user's locale NVP to a different language. We were calling it when a user logs in from an account with different language settings, which resulted in them unexpectedly having different language settings.Fixed Issues
$ #6133
Tests / QA Steps
(On an account with internalization beta turned on)
Settings > Preferencesand set toEspanol.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android