Skip to content

Fix Promo colors on login screen for native devices#6185

Merged
roryabraham merged 4 commits into
Expensify:mainfrom
parasharrajat:color-login
Nov 4, 2021
Merged

Fix Promo colors on login screen for native devices#6185
roryabraham merged 4 commits into
Expensify:mainfrom
parasharrajat:color-login

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Nov 3, 2021

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6070

Tests | QA Steps

  1. Launch the app
  2. Observe the PromoColor image on the login page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

image

iPAD

Screenshot 2021-11-03 10:28:29

Android Tablet

Screenshot 2021-11-03 09:47:39

@parasharrajat parasharrajat requested a review from a team as a code owner November 3, 2021 04:18
@MelvinBot MelvinBot requested review from roryabraham and removed request for a team November 3, 2021 04:18
@parasharrajat

Copy link
Copy Markdown
Member Author

Gentle Bump @roryabraham This is ready.

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor thing...

Comment thread src/components/SVGImage/index.native.js Outdated
@@ -0,0 +1,17 @@

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank line

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@roryabraham

Copy link
Copy Markdown
Contributor

Still wonky on iPhone 13 landscape, but I was able to confirm that this PR fixes the issue:

image

It would be nice to have the solid color fill the safeArea on landscape mode, but I think that's out of scope for this.

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests well (at least, fixes the linked issue) 👍

@roryabraham

Copy link
Copy Markdown
Contributor

Going to merge and test this GH extension feature:

image

@parasharrajat

parasharrajat commented Nov 4, 2021

Copy link
Copy Markdown
Member Author

It would be nice to have the solid color fill the safeArea on landscape mode, but I think that's out of scope for this.

Yeah, Good suggestion. I am working on another PR related to login page. I can try to add that there if not much efforts.

@roryabraham roryabraham merged commit f91e49c into Expensify:main Nov 4, 2021
@roryabraham

Copy link
Copy Markdown
Contributor

Nice, that extension Wait for successful checks feature ^ works as long as you keep the tab open

@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants