Skip to content

Fix unread marker displayed consistently on chat after creating new expense and switching reports #61867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 2 commits into from
May 14, 2025
Merged

Fix unread marker displayed consistently on chat after creating new expense and switching reports #61867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
918d827
fix: consistent unread marker on chat after creating new report action
rohit9625 May 12, 2025
c1b5e11
fix: use isCurrentActionUnread to check if last action is unread
rohit9625 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
getFirstVisibleReportActionID,
isConsecutiveActionMadeByPreviousActor,
isConsecutiveChronosAutomaticTimerAction,
isCurrentActionUnread,
isDeletedParentAction,
isReportPreviewAction,
isReversedTransaction,
Expand Down Expand Up @@ -349,7 +350,7 @@ function ReportActionsList({
return;
}

if (isUnread(report, transactionThreadReport)) {
if (isUnread(report, transactionThreadReport) || (lastAction && isCurrentActionUnread(report, lastAction))) {
// On desktop, when the notification center is displayed, isVisible will return false.
// Currently, there's no programmatic way to dismiss the notification center panel.
// To handle this, we use the 'referrer' parameter to check if the current navigation is triggered from a notification.
Expand Down
Loading