Skip to content

Added Spanish translation for example check image and Company types#6190

Merged
timszot merged 2 commits into
Expensify:mainfrom
PrashantMangukiya:prashant-5992
Nov 4, 2021
Merged

Added Spanish translation for example check image and Company types#6190
timszot merged 2 commits into
Expensify:mainfrom
PrashantMangukiya:prashant-5992

Conversation

@PrashantMangukiya

Copy link
Copy Markdown
Contributor

@iwiznia PR is ready for review.

Details

Spanish translation was missing for Company types, and Routing and Bank Account Number example image in VBA flow. So added translation for both.

Fixed Issues

$ #5992

Tests | QA Steps

  1. Set app to spanish
  2. Navigate to bank account flow > Manually set bank account
  3. Check the image example above the routing and bank account number
  4. Enter test credentials and proceed to company step
  5. Click on the company type dropdown

QA Check 1: Now example check image shows in Spanish Or English as per language preference.
QA Check 2: Company Types dropdown will be translated as per language preference.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web.mp4

Mobile Web

MobileWeb.mp4

Desktop

Desktop.mp4

iOS

iOS.mp4

Android

Android.mp4

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner November 3, 2021 15:44
@MelvinBot MelvinBot requested review from timszot and removed request for a team November 3, 2021 15:44
Comment thread src/languages/es.js Outdated
incorporationTypes: {
LLC: 'LLC',
CORPORATION: 'Corp',
PARTNERSHIP: 'Camaradería',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not sound like the correct word, I have no idea what this partnership type of company is or how is it called in spanish... let me post this on slack and get back to you

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use Sociedad

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected and pushed new commit. Thanks.

@PrashantMangukiya

Copy link
Copy Markdown
Contributor Author

@iwiznia It looks like something wrong with E2E automation, as E2E test is failing after 9 minutes. Here is screenshot:

Screenshot 2021-11-03 at 11 45 34 PM

@iwiznia

iwiznia commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

That's odd, can you try:

  • Merging main into this branch
  • Restarting the test
    ?

@PrashantMangukiya

Copy link
Copy Markdown
Contributor Author

It is not showing me any option to restart the test etc. I think someone from review team may have that permission.

@timszot timszot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restarted the tests, will wait to and see what happens.

@timszot timszot merged commit 0c43cf7 into Expensify:main Nov 4, 2021
@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @timszot in version: 1.1.13-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@ogumen

ogumen commented Nov 21, 2021

Copy link
Copy Markdown

The accessibility issues found in this PR:
Web

  1. I assume that not all parts of the app are being translated to Spanish once changing the language in Preferences, the ones that are translated should have lang="es" applied - failure of WCAG SC 3.1.2. Once the entire page is being translated to Spanish - the <html lang="en"> should have "es" value instead (it will be treated under WCAG SC 3.1.1).
    Language of page
    Example of language of parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants