-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[InternalQA] Add drop zone to the reports page #61916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lakchote
merged 22 commits into
Expensify:main
from
callstack-internal:feat/59440-add-dropzone-to-reports-page
May 15, 2025
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
5522ba1
feat; add dropzone to the reports page
koko57 a9466ec
chore: move navigateToParticipantsPage function to IOU ations
koko57 2dd1dbe
fix: prettier
koko57 5493ce1
feat: wip - add file validation
koko57 7116b0c
fix: add loader, move navigateToParticipantsPage to utils
koko57 465ece5
Merge branch 'main' into feat/59440-add-dropzone-to-reports-page
koko57 0c49fcf
feat: save receipt and navigate to participants page
koko57 2b2e593
feat: enable dropzone on the other tabs, change the tab in the backgr…
koko57 ce9342a
fix: resolve conflicts
koko57 21b8ced
fix: prettier
koko57 bef1264
fix: lint
koko57 c62ffc2
fix: enable the feature only for beta
koko57 ef11d9c
fix: show replace receipt icon and text when editing
koko57 c33b3e1
fix: remove console.log
koko57 5e50914
fix: minor fix
koko57 74c9441
fix: minor fix
koko57 3544ab9
fix: change tab after creating the expense
koko57 b312aca
fix: revert podfile change
koko57 b687360
fix: minor fix
koko57 f69912f
fix: uncomment one line
koko57 7e2050c
fix: resolve conflicts
koko57 55ad006
fix: lint
koko57 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should prevent this navigation on mobile. it would also affect the global create flow on search page, i wonder if we want that change.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Global Create - I think having two behaviors for Global Create and Create Expense after drop would be strange, especially since this Create Expense flow should work like it was opened from the Global Create (like it was mentioned in the docs) - but could you please LMK what do you think about it? @lakchote @dannymcclain @shawnborton @dubielzyk-expensify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that we should have a consistent behavior. Let's see what everyone thinks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getusha for the mobile - looks like it doesn't cause any problem
Screen.Recording.2025-05-14.at.15.56.52.mp4
the only thing I've noticed that the query phrase looks strange when changing a tab (but it's from changing the tab)
Screen.Recording.2025-05-14.at.15.45.01.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can always be addressed in a follow-up PR as it's not related to this PR.
cc @luacmartins is this format of the search query expected or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not. I think we have a bug reported for it somewhere. I can't find the link though 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah here it is #61940