Skip to content

Modifies code wrapper style iOS#6197

Merged
NikkiWines merged 1 commit into
Expensify:mainfrom
AlfredoAlc:alfredo-modify-codestyle
Nov 4, 2021
Merged

Modifies code wrapper style iOS#6197
NikkiWines merged 1 commit into
Expensify:mainfrom
AlfredoAlc:alfredo-modify-codestyle

Conversation

@AlfredoAlc

Copy link
Copy Markdown
Contributor

Details

Removes marginTop and increment the height to fix rendering extra white space on codeWrapper.

Fixed Issues

$ #5310

Tests

  1. Open app in iOS.
  2. Send a message with a line of code. Eg.
    Let's try this message with `inline code` & big blocks that `wrap multiple lines containing multiple code blocks`. You would see the difference.
  3. Rotate the device.
  4. It shouldn't render extra white spaces around the code wrappers.

QA Steps

  1. Open app in iOS.
  2. Send a message with a line of code. Eg.
    Let's try this message with `inline code` & big blocks that `wrap multiple lines containing multiple code blocks`. You would see the difference.
  3. Change device orientation to landscape.
  4. It shouldn't render extra white spaces around the code wrappers.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

iOS(iPhone)

iPhone.mp4

iOS(iPad)

iPad.mp4

@NikkiWines NikkiWines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well 👍

@NikkiWines NikkiWines merged commit 9b9844e into Expensify:main Nov 4, 2021
@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @NikkiWines in version: 1.1.13-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants