Skip to content

close Keyboard when opening drawer#6205

Merged
mountiny merged 1 commit into
Expensify:mainfrom
parasharrajat:keyboard-close
Nov 4, 2021
Merged

close Keyboard when opening drawer#6205
mountiny merged 1 commit into
Expensify:mainfrom
parasharrajat:keyboard-close

Conversation

@parasharrajat

@parasharrajat parasharrajat commented Nov 4, 2021

Copy link
Copy Markdown
Member

Details

Fixed Issues

$ #6158

Tests | QA Steps

  1. Edit a message in any chat on mobile.
  2. Click the edit box to show the keyboard.
  3. From the UI back arrow, go back to LHN.
  4. Keyboard should be closed.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

output_file.mp4

Desktop

iOS

Android

output_file.mp4

@parasharrajat parasharrajat marked this pull request as ready for review November 4, 2021 03:55
@parasharrajat parasharrajat requested a review from a team as a code owner November 4, 2021 03:55
@botify botify requested a review from mountiny November 4, 2021 03:55
@MelvinBot MelvinBot removed the request for review from a team November 4, 2021 03:55

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth like butter!

@mountiny mountiny merged commit 97110f0 into Expensify:main Nov 4, 2021
@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat

Copy link
Copy Markdown
Member Author

Sorry, couldn't get the IOS screenshots. I have messed up my network interface on Mac.

@mountiny

mountiny commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

@parasharrajat No worries, for this behaviour we can safely assume it works on iOS too if it works on Android.

@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.13-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants