Skip to content

Make resizeMode dynamic#6206

Merged
deetergp merged 1 commit into
Expensify:mainfrom
CamilaRivera:camilarivera-fix-attachment-image-size
Nov 4, 2021
Merged

Make resizeMode dynamic#6206
deetergp merged 1 commit into
Expensify:mainfrom
CamilaRivera:camilarivera-fix-attachment-image-size

Conversation

@CamilaRivera

@CamilaRivera CamilaRivera commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Details

Make resizeMode dynamic to use the resizeMode with the value 'center' when the image is not zoomed, to allow image to be displayed with a size that matches the real image size.

Note: I didn't add screenshots for Android and IOS because I only modified the version of the component that is used for web and desktop.

Fixed Issues

$ #6076

Tests | QA Steps

  1. Copy this small image of a chilling cat with a sombrero
    image
  2. Add the image as an attachment and check that it doesn't look stretched before clicking "Send"
  3. Send the image to any chat in New Expensify
  4. Click on the image thumbnail, it should open modal with the image
  5. Check that the image is not stretched and is centered

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-11-03 at 10 15 54 PM

Mobile Web

Screen Shot 2021-11-03 at 10 39 28 PM

Desktop

Screen Shot 2021-11-03 at 10 29 41 PM

iOS

Android

@CamilaRivera CamilaRivera requested a review from a team as a code owner November 4, 2021 05:37
@MelvinBot MelvinBot requested review from deetergp and removed request for a team November 4, 2021 05:37

@deetergp deetergp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple, effective fix. Thanks!

@deetergp deetergp merged commit 1fd2531 into Expensify:main Nov 4, 2021
@OSBotify

OSBotify commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.14-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants