[No QA] Add BankAccounts test#6217
Merged
Merged
Conversation
long test add reimbursementAccountTestData clean up tests simplify test cleanup test
marcaaron
force-pushed
the
marcaaron-vbaTests
branch
from
60406dd to
c597b9e
Compare
nkuoch
approved these changes
Nov 11, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
70 tasks
Contributor
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds some unit testing for the
BankAccountsactions file. The tests mostly check that the handling logic when fetching a bank account will direct the user to the correct current step. In addition, I'm planning on refactoring the code around this as a follow up to N6 and having these tests will give some extra protection against any accidental changes to the flow.Fixed Issues
https://github.com/Expensify/Expensify/issues/173363
Tests
Automated
QA Steps
No QA