Tooltip - Workspaces tooltip appears above Workspaces row and overlaps with Workspaces header#62195
Conversation
…and overlaps with Workspaces header
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Straightforward change. LGTM |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-18.at.11.31.18.movAndroid: mWeb ChromeScreen.Recording.2025-05-18.at.11.19.49.moviOS: HybridAppScreen.Recording.2025-05-18.at.11.30.36.moviOS: mWeb SafariScreen.Recording.2025-05-18.at.11.19.07.movMacOS: Chrome / SafariScreen.Recording.2025-05-18.at.11.18.01.movMacOS: DesktopScreen.Recording.2025-05-18.at.11.34.28.mov |
|
Looks good to me if we wanted to just remove it 👍 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/10)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/10)Meaningless Changes To Duration (9/9)Show entries
Show details
|
Performance Comparison Report 📊 (2/10)Meaningless Changes To Duration (1/9)Show entries
Show details
|
Performance Comparison Report 📊 (3/10)Meaningless Changes To Duration (2/9)Show entries
Show details
|
Performance Comparison Report 📊 (4/10)Meaningless Changes To Duration (3/9)Show entries
Show details
|
Performance Comparison Report 📊 (5/10)Meaningless Changes To Duration (4/9)Show entries
Show details
|
Performance Comparison Report 📊 (6/10)Meaningless Changes To Duration (5/9)Show entries
Show details
|
Performance Comparison Report 📊 (7/10)Meaningless Changes To Duration (6/9)Show entries
Show details
|
Performance Comparison Report 📊 (8/10)Meaningless Changes To Duration (7/9)Show entries
Show details
|
Performance Comparison Report 📊 (9/10)Meaningless Changes To Duration (8/9)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.48-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.49-5 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀
|
cc: @dukenv0307 @rayane-d
Explanation of Change
This PR removes the workspace settings tooltip.
Fixed Issues
$ #62141
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop