Skip to content

Make track expenses generate manual submit policies #62239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 7 commits into from
May 22, 2025
Merged

Make track expenses generate manual submit policies #62239

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8f4e87
make track expenses generate manual submit policies
luacmartins May 16, 2025
2f68859
fix logic
luacmartins May 19, 2025
3db7a3f
use correct intent
luacmartins May 19, 2025
b1a73c3
fix lint
luacmartins May 19, 2025
171fed1
add comment
luacmartins May 19, 2025
eab3f9a
rm extra line
luacmartins May 19, 2025
adb58c4
Merge branch 'main' into cmartins-makeTrackManualSubmit
luacmartins May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/libs/actions/Policy/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,9 +1814,13 @@ function buildPolicyData(
const optimisticMccGroupData = buildOptimisticMccGroup();

const shouldEnableWorkflowsByDefault =
!introSelected?.choice || introSelected.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected.choice === CONST.ONBOARDING_CHOICES.LOOKING_AROUND;
!introSelected?.choice ||
introSelected.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ||
introSelected.choice === CONST.ONBOARDING_CHOICES.LOOKING_AROUND ||
introSelected.choice === CONST.ONBOARDING_CHOICES.PERSONAL_SPEND;
Comment thread
luacmartins marked this conversation as resolved.
const shouldSetCreatedWorkspaceAsActivePolicy = !!activePolicyID && allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`]?.type === CONST.POLICY.TYPE.PERSONAL;

// WARNING: The data below should be kept in sync with the API so we create the policy with the correct configuration.
const optimisticData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.SET,
Expand Down
Loading