Skip to content

Fix last payment option is not updated#62302

Merged
stitesExpensify merged 2 commits into
Expensify:mainfrom
bernhardoj:fix/61855-payment-option-is-not-updated
May 20, 2025
Merged

Fix last payment option is not updated#62302
stitesExpensify merged 2 commits into
Expensify:mainfrom
bernhardoj:fix/61855-payment-option-is-not-updated

Conversation

@bernhardoj

@bernhardoj bernhardoj commented May 19, 2025

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #61855
PROPOSAL: #61855 (comment)

Tests

Same as QA Steps

  • Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

  1. Create a new money request on a WS chat
  2. Submit and approve the request
  3. On the expense preview select a payment option different from the default one
  4. Open the expense report
  5. Verify the selected payment option is shown
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4

@bernhardoj bernhardoj requested a review from a team as a code owner May 19, 2025 16:08
@melvin-bot melvin-bot Bot requested a review from ZhenjaHorbach May 19, 2025 16:08
@melvin-bot

melvin-bot Bot commented May 19, 2025

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team May 19, 2025 16:08
@bernhardoj

bernhardoj commented May 19, 2025

Copy link
Copy Markdown
Contributor Author

I'm having problem running the Android

@ZhenjaHorbach

ZhenjaHorbach commented May 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2025-05-19.23.31.47.mov
Android: mWeb Chrome
2025-05-19.23.31.47.mov
iOS: HybridApp
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
web.mov

@ZhenjaHorbach

ZhenjaHorbach commented May 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

As I can see it doesn't work on mobile apps when we return back🧐

2025-05-19.23.15.46.mov

@bernhardoj

bernhardoj commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

It happens on web too if we go back with browser back button. It's expected as we don't want to reorder based on this comment, except when the component is first initialized.

App/src/components/SettlementButton/index.tsx

Lines 229 to 247 in a95171a

// We don't want to reorder the options when the preferred payment method changes while the button is still visible except for component initialization when the last payment method is not initialized yet.
// We need to be sure that onPress should be wrapped in an useCallback to prevent unnecessary updates.
// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [
isLoadingLastPaymentMethod,
iouReport,
translate,
formattedAmount,
shouldDisableApproveButton,
isInvoiceReport,
currency,
shouldHidePaymentOptions,
shouldShowApproveButton,
shouldShowPayWithExpensifyOption,
shouldShowPayElsewhereOption,
chatReport,
onPress,
onlyShowPayElsewhere,
]);

@ZhenjaHorbach

ZhenjaHorbach commented May 20, 2025

Copy link
Copy Markdown
Contributor

Oh
Okay
Thanks for confirmation !

@melvin-bot melvin-bot Bot requested a review from stitesExpensify May 20, 2025 07:14
@ZhenjaHorbach

ZhenjaHorbach commented May 20, 2025

Copy link
Copy Markdown
Contributor

LGTM !

@stitesExpensify stitesExpensify merged commit 55239b9 into Expensify:main May 20, 2025
17 checks passed
@OSBotify

OSBotify commented May 20, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot added the DeployBlockerCash This issue or pull request should block deployment label May 20, 2025
@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Performance Comparison Report 📊 (1/3)

⚠️ Some tests did not pass successfully, so some results are omitted from final report: Open search router TTI, Linking, Money request

Significant Changes To Duration

Name Duration
App start time contentAppeared_To_screenTTI 821.376 ms → 1016.761 ms (+195.386 ms, +23.8%) 🔴
App start time TTI 1510.159 ms → 1678.811 ms (+168.652 ms, +11.2%) 🔴
Show details
Name Duration
App start time contentAppeared_To_screenTTI Baseline
Mean: 821.376 ms
Stdev: 246.374 ms (30.0%)
Runs: 498.0722159999423 529.6102419998497 561.7112929997966 564.5904399999417 568.5776599999517 573.8527719997801 578.1825529998168 585.6282520000823 585.9101840001531 587.2729270001873 594.606732999906 596.7774820001796 597.1755010001361 602.2961789998226 604.5870610000566 621.1973540000618 624.4910550001077 627.0382869997993 628.439660999924 637.1905220001936 640.4177399999462 641.7887140000239 647.1670160000212 652.8009770000353 653.3989729997702 653.5809050002135 659.8062749998644 660.6229719999246 661.4810370001942 663.9891739999875 668.6502370000817 683.7262679999694 693.5090080001391 702.4840110000223 742.5463680000976 764.4067330001853 1003.646914999932 1005.291106000077 1011.4729670002125 1013.8336370000616 1044.0542190000415 1046.9107760000043 1049.4445199999027 1051.7301030000672 1080.6562430001795 1090.0294800000265 1098.649915999733 1118.1949570002034 1126.052643999923 1127.9800729998387 1149.9576829997823 1159.3075379999354 1169.4049030002207 1170.4085809998214 1187.0846400000155 1191.258437000215 1192.8162369998172 1199.8020689999685 1210.500905000139 1226.4685349999927

Current
Mean: 1016.761 ms
Stdev: 224.523 ms (22.1%)
Runs: 557.7796590002254 576.1492490000091 582.7687070001848 589.1532459999435 593.2492999997921 603.3340870002285 624.8044839999638 631.3165110000409 669.0335820000619 670.3901789998636 672.6775009999983 694.8685880000703 708.1297709997743 764.3042870000936 801.8759800000116 820.2192910001613 1029.5094559998251 1036.153191999998 1038.07826999994 1055.2030319999903 1058.9669780000113 1063.5088419998065 1065.8472759998403 1071.1495269997977 1086.6945989998057 1091.910455999896 1099.1168109998107 1100.967987000011 1101.8875359999947 1103.681212999858 1135.9648690000176 1145.1662070001476 1149.0029549999163 1149.8176099997945 1151.6137310001068 1153.5487009999342 1156.5774420001544 1159.8264299998991 1160.5733779999427 1161.5013190000318 1165.5283329999074 1167.871607999783 1169.4237029999495 1171.3940420001745 1171.7947109998204 1173.0966139999218 1181.838917999994 1181.944385000039 1183.7262699999847 1188.1901259999722 1192.7331199999899 1196.0480969999917 1201.4470609999262 1203.3059140001424 1215.7805780000053 1218.7462240001187 1226.6519340001978 1230.5567160001956 1237.0746289999224 1242.202909000218
App start time TTI Baseline
Mean: 1510.159 ms
Stdev: 248.151 ms (16.4%)
Runs: 1171.0722159999423 1174.1825529998168 1220.7112929997966 1228.6102419998497 1229.2961789998226 1231.3989729997702 1231.5904399999417 1237.1755010001361 1251.1973540000618 1259.85277199978 1264.1670160000212 1266.910184000153 1272.0382869997993 1274.7774820001796 1288.606732999906 1297.5776599999517 1305.5809050002135 1305.5870610000566 1311.9891739999875 1312.5090080001391 1317.4177399999462 1335.1905220001936 1345.2729270001873 1350.6502370000817 1351.4910550001077 1352.6282520000823 1356.4810370001942 1373.6229719999246 1382.788714000024 1421.4067330001853 1422.8009770000353 1442.439660999924 1443.8062749998644 1445.4840110000223 1499.5463680000976 1524.7262679999694 1633.8336370000616 1636.4729670002125 1671.4445199999027 1686.291106000077 1735.1949570002034 1760.0294800000265 1765.9107760000043 1768.6562430001795 1776.7301030000672 1784.052643999923 1785.0542190000415 1797.9576829997823 1803.3075379999354 1809.258437000215 1811.646914999932 1819.649915999733 1821.8162369998172 1854.0846400000155 1879.9800729998387 1880.4049030002207 1885.8020689999685 1907.4085809998214 1910.4685349999927 1923.500905000139

Current
Mean: 1678.811 ms
Stdev: 212.594 ms (12.7%)
Runs: 1269.7796590002254 1275.1532459999435 1298.6775009999983 1308.1492490000091 1318.3340870002285 1326.3901789998636 1327.0335820000619 1328.2492999997921 1332.8685880000703 1360.1297709997743 1361.316511000041 1374.7687070001848 1381.8044839999638 1444.3042870000936 1461.8759800000116 1524.2192910001613 1619.5094559998251 1622.07826999994 1629.2030319999903 1636.9669780000113 1639.8472759998403 1652.681212999858 1670.1495269997977 1685.5088419998065 1693.967987000011 1720.9648690000176 1767.7262699999847 1769.5733779999427 1773.5774420001544 1775.5487009999342 1777.1168109998107 1777.8176099997945 1787.1662070001476 1792.910455999896 1796.4237029999495 1797.871607999783 1803.6137310001068 1808.0966139999218 1808.153191999998 1814.1901259999722 1814.5283329999074 1818.7947109998204 1827.7331199999899 1836.3940420001745 1845.3059140001424 1849.8875359999947 1855.7805780000053 1857.944385000039 1860.838917999994 1861.7462240001187 1868.0746289999224 1868.4470609999262 1869.0480969999917 1869.8264299998991 1879.5013190000318 1881.6519340001978 1887.0029549999163 1893.5567160001956 1926.6945989998057 2042.202909000218

@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Performance Comparison Report 📊 (2/3)

Meaningless Changes To Duration (1/2)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 87.017 ms → 87.828 ms (+0.810 ms, +0.9%)
App start time nativeLaunch 27.017 ms → 26.103 ms (-0.914 ms, -3.4%)
App start time appCreation 79.417 ms → 77.383 ms (-2.033 ms, -2.6%)
App start time runJsBundle 324.383 ms → 320.175 ms (-4.208 ms, -1.3%)
App start time appCreationEnd_To_contentAppeared 491.322 ms → 466.017 ms (-25.305 ms, -5.2%)
App start time regularAppStart 0.022 ms → 0.022 ms (+0.000 ms, +2.2%)
App start time (CPU) 152.869 % → 152.655 % (-0.214 %, ±0.0%)
App start time (FPS) 59.680 FPS → 59.213 FPS (-0.467 FPS, +0.8%)
App start time (RAM) 381.184 MB → 388.008 MB (+6.823 MB, +1.8%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.812 % → 26.544 % (-1.268 %, -4.6%)
Report typing Composer typing rerender count 1.000 renders → 0.733 renders (-0.267 renders, -26.7%) 🟢
Report typing Message sent 457.914 ms → 454.062 ms (-3.852 ms, -0.8%)
Report typing (CPU) 79.937 % → 79.445 % (-0.492 %, -0.6%)
Report typing (FPS) 59.837 FPS → 59.831 FPS (-0.006 FPS, ±0.0%)
Report typing (RAM) 447.461 MB → 447.851 MB (+0.390 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 17.605 % → 17.505 % (-0.100 %, -0.6%)
Chat opening Chat TTI 1031.657 ms → 1013.038 ms (-18.619 ms, -1.8%)
Chat opening (CPU) 163.534 % → 162.948 % (-0.586 %, ±0.0%)
Chat opening (FPS) 59.346 FPS → 59.588 FPS (+0.242 FPS, ±0.0%)
Chat opening (RAM) 390.436 MB → 390.612 MB (+0.177 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.396 % → 32.793 % (-0.604 %, -1.8%)
Show details
Name Duration
App start time nativeLaunchEnd_To_appCreationStart Baseline
Mean: 87.017 ms
Stdev: 10.692 ms (12.3%)
Runs: 68 69 69 70 71 72 72 72 74 74 75 76 78 79 80 80 82 82 82 83 83 84 85 85 85 85 86 86 87 87 87 88 88 89 90 91 91 92 92 92 92 92 92 94 95 96 96 97 98 98 100 100 101 101 106 107 108 113

Current
Mean: 87.828 ms
Stdev: 11.360 ms (12.9%)
Runs: 62 66 69 73 74 75 75 76 77 78 78 79 79 80 81 81 82 82 82 82 83 83 84 84 85 85 86 86 87 87 88 88 88 89 89 89 90 90 90 91 91 92 93 93 93 93 99 100 100 103 103 103 104 105 109 110 114 116
App start time nativeLaunch Baseline
Mean: 27.017 ms
Stdev: 3.855 ms (14.3%)
Runs: 21 21 21 22 22 22 23 23 23 23 23 23 24 24 24 24 24 25 25 25 25 25 25 25 25 26 26 26 26 27 27 27 27 27 27 27 28 28 28 28 29 29 29 30 30 30 30 30 30 31 32 33 33 33 33 34 34 35 37

Current
Mean: 26.103 ms
Stdev: 3.561 ms (13.6%)
Runs: 21 21 21 22 22 22 22 22 22 23 23 23 23 24 24 24 24 24 24 24 24 24 24 25 25 25 25 25 25 25 25 26 26 26 27 27 27 27 27 27 27 28 28 28 28 29 29 29 29 29 29 31 32 33 33 34 35 36
App start time appCreation Baseline
Mean: 79.417 ms
Stdev: 12.529 ms (15.8%)
Runs: 56 57 59 59 61 62 62 63 65 65 68 69 69 70 70 70 71 71 72 73 74 74 75 75 75 76 77 77 77 77 77 79 81 81 82 83 83 83 86 87 88 88 89 89 89 89 89 90 91 92 92 93 93 96 96 96 100 102 102 110

Current
Mean: 77.383 ms
Stdev: 12.234 ms (15.8%)
Runs: 52 55 57 58 60 63 64 64 65 65 66 67 67 68 68 69 70 70 70 71 71 73 74 74 75 76 76 76 76 77 77 77 77 77 78 78 81 81 81 82 82 82 82 84 85 85 86 86 86 88 88 91 91 92 97 98 98 98 109 109
App start time runJsBundle Baseline
Mean: 324.383 ms
Stdev: 27.494 ms (8.5%)
Runs: 274 274 278 278 283 283 285 285 288 288 289 289 294 294 296 296 297 297 299 299 300 300 300 300 302 302 304 304 305 305 305 305 306 306 308 308 310 310 310 310 311 311 313 313 313 313 314 314 315 315 317 317 318 318 319 319 319 319 320 320 320 320 321 321 321 321 324 324 325 325 328 328 328 328 330 330 330 330 333 333 334 334 335 335 336 336 340 340 342 342 344 344 345 345 345 345 346 346 347 347 350 350 354 354 355 355 358 358 361 361 365 365 368 368 387 387 398 398 401 401

Current
Mean: 320.175 ms
Stdev: 15.538 ms (4.9%)
Runs: 292 292 292 292 294 294 295 295 296 296 298 298 298 298 299 299 303 303 304 304 306 306 306 306 306 306 307 307 308 308 310 310 311 311 311 311 312 312 312 312 314 314 315 315 316 316 316 316 319 319 319 319 321 321 322 322 322 322 322 322 323 323 323 323 324 324 324 324 326 326 326 326 327 327 327 327 328 328 328 328 328 328 328 328 329 329 330 330 332 332 333 333 333 333 335 335 337 337 338 338 339 339 344 344 346 346 346 346 350 350 350 350 350 350
App start time appCreationEnd_To_contentAppeared Baseline
Mean: 491.322 ms
Stdev: 45.443 ms (9.2%)
Runs: 381 418 423 427 429 431 432 433 438 448 449 450 454 457 461 461 462 465 471 471 473 474 477 478 480 482 486 486 489 490 493 493 493 496 500 500 506 507 508 511 514 514 516 519 519 522 522 527 528 533 535 536 557 562 563 569 578 581 610

Current
Mean: 466.017 ms
Stdev: 46.322 ms (9.9%)
Runs: 400 406 409 410 411 412 414 420 423 423 425 428 429 431 432 432 434 435 435 440 442 442 443 444 444 446 449 450 451 451 453 453 456 458 459 465 465 468 468 472 474 477 493 496 502 506 511 512 522 526 527 534 535 538 544 553 568 571 578
App start time regularAppStart Baseline
Mean: 0.022 ms
Stdev: 0.002 ms (11.4%)
Runs: 0.015950000379234552 0.01778100011870265 0.01847400004044175 0.018553999718278646 0.019245999865233898 0.019245999865233898 0.019286999944597483 0.019530999939888716 0.019611999858170748 0.019694000016897917 0.019816000014543533 0.019816000014543533 0.01985699962824583 0.019897999707609415 0.020060000009834766 0.02010100008919835 0.02010100008919835 0.020182000007480383 0.020223000086843967 0.020223000086843967 0.020263999700546265 0.020264000166207552 0.020427000243216753 0.0204670000821352 0.020793000236153603 0.02083300007507205 0.020913999993354082 0.02103699976578355 0.021076999604701996 0.021118000149726868 0.021240000147372484 0.02128100022673607 0.021321999840438366 0.021402999758720398 0.021524999756366014 0.021525000222027302 0.021606999915093184 0.022216000128537416 0.022379999980330467 0.02254199981689453 0.022828000131994486 0.0235190000385046 0.023599999956786633 0.023641000036150217 0.02380299987271428 0.02416999964043498 0.024576999712735415 0.02465900033712387 0.02522800024598837 0.025268999859690666 0.025674999691545963 0.0262449998408556 0.026366999838501215 0.026529999915510416 0.026569999754428864 0.027424999978393316

Current
Mean: 0.022 ms
Stdev: 0.003 ms (11.4%)
Runs: 0.018188999965786934 0.018432999961078167 0.0186769999563694 0.018757999874651432 0.01883900025859475 0.018839999567717314 0.019001999869942665 0.01920600002631545 0.019367999862879515 0.019448999781161547 0.0197350000962615 0.0197759997099638 0.02001999970525503 0.020182000007480383 0.020223000086843967 0.020264000166207552 0.02038499992340803 0.020589000079780817 0.02083300007507205 0.020874000154435635 0.020874999929219484 0.0210359999909997 0.0211990000680089 0.021200000308454037 0.02136299991980195 0.021687999833375216 0.021809999831020832 0.02181000029668212 0.021890999749302864 0.021891999989748 0.022053999826312065 0.022298000287264585 0.022419999819248915 0.0224609998986125 0.022500999737530947 0.02254199981689453 0.022583000361919403 0.023193999659270048 0.02364099957048893 0.02372199995443225 0.023843999952077866 0.023924999870359898 0.024210999719798565 0.024373000022023916 0.0244140001013875 0.024495000019669533 0.02449600026011467 0.024536000099033117 0.024536000099033117 0.024739000014960766 0.025350000243633986 0.02567500015720725 0.026082000229507685 0.026978000067174435 0.02783200005069375 0.029826000332832336
App start time (CPU) Baseline
Mean: 152.869 %
Stdev: 7.847 % (5.1%)
Runs: 137.8437519062161 138.08338287503503 138.1952999147162 139.95805375934054 140.1396701649956 141.93390212807685 143.06491929818978 143.19736934348674 143.85243913937884 144.83810157462852 144.8406519256722 145.2233454950846 145.70486114946453 147.71713147410358 147.73536628937774 147.7370517928287 147.8140770252323 148.71420747880268 148.74082160344548 148.7769556693859 149.2633103947845 149.84161138007295 150.03182060835775 150.1382765531062 150.35653628188498 150.394255314073 150.5428829944283 151.1832279535878 151.21603145318588 153.00834431269215 153.69994830808386 153.71903878646748 153.72111553784865 153.73306772908364 153.82573217080264 154.7448774288139 154.94071146245065 155.45388436266177 155.67643222953845 156.64593751564976 157.89148017149842 157.92142053030364 158.6637876185023 158.7767981290613 158.85628742514976 158.9399346890544 159.31863727454908 159.62480516588735 159.6868686868687 159.8023786282049 161.10574402456965 161.7113932144281 162.51685324514085 162.59212402353558 164.7623176077995 165.28122742147983 165.610849193877 166.57057654075547 167.30263949275823 168.93674507310865

Current
Mean: 152.655 %
Stdev: 7.723 % (5.1%)
Runs: 136.50209676580062 138.85174066592683 139.8379796682833 140.7446881438158 141.64708885740782 142.603237079615 143.34036536146147 143.93271169354836 144.46499566040293 144.46647566777048 144.56952761144382 145.74103585657372 146.37102845255524 147.05292734583952 147.0653041207735 147.77231935423197 148.10508231623768 148.82486280124076 149.14209827357226 149.18121436468877 149.62896609819373 150.00340812269246 150.49667994687906 150.7448296194775 151.35588053719658 151.3708256407828 151.64613351397352 152.05330288430437 152.46083153716324 152.72475663294526 153.04769121312097 153.06849359988527 153.0841037200423 153.53538554159604 153.54016068260196 153.7249273034276 154.01868417092777 155.02892250821466 155.03170335569226 155.1598610112899 155.23771733641155 155.60926494699171 155.62785984540898 156.29952202348497 156.77641312463118 158.2898510467468 158.82740447957843 159.4334914889067 159.70187386725638 160.58250497017892 160.63824424045907 160.65792688369896 161.43790849673198 163.68640673500272 165.2568092371048 165.52522572696955 168.10734440812917 169.2898371593486 173.68924302788852
App start time (FPS) Baseline
Mean: 59.680 FPS
Stdev: 0.593 FPS (1.0%)
Runs: 58.026352843432925 58.02760188435667 58.193269254103335 58.19502524863847 58.43719413624911 58.54708231315323 58.70628508171919 59.037994192110354 59.165540059464156 59.22665811566835 59.26437617087639 59.367770219844544 59.541784467534406 59.63494631878405 59.83358207779447 59.892466466133506 59.929316171182506 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 59.213 FPS
Stdev: 1.063 FPS (1.8%)
Runs: 56.86455771166854 57.2787984210811 57.43026754526644 57.438766930903284 57.50203711687379 57.51299675399485 57.536956968693 57.547953997767195 57.553552197533214 57.5818849904257 57.607692061229635 57.74867158147254 57.76348421789373 58.17985796351343 58.21364650671449 58.349701546458284 58.42645719931941 58.43106422412737 58.454748958983124 58.877715968324075 59.12316964838794 59.49648360009051 59.854975174092715 59.87679365215682 59.89814305050948 59.91037389289554 59.92135521553592 59.96431525309075 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
App start time (RAM) Baseline
Mean: 381.184 MB
Stdev: 8.637 MB (2.3%)
Runs: 362.603515625 366.73046875 369.2057291666667 369.955078125 370.0260416666667 370.357421875 370.6015625 371.228515625 371.3971354166667 371.443359375 371.482421875 371.8203125 372.326171875 372.501953125 372.916015625 373.017578125 373.7734375 374.107421875 374.484375 374.5 375.1953125 376.0390625 377.197265625 377.484375 377.484375 378.2252604166667 378.515625 378.57421875 382.099609375 382.6796875 383.4127604166667 383.8203125 383.8658854166667 384.373046875 385.0768229166667 385.125 385.1471354166667 385.4791666666667 385.736328125 385.7955729166667 386.1158854166667 386.3736979166667 386.380859375 387.0703125 387.4609375 387.7916666666667 388.4401041666667 388.623046875 389.32421875 389.4049479166667 391.19921875 391.2265625 392.4466145833333 392.9583333333333 393.3958333333333 393.7109375 394.1484375 395.14453125 396.4287109375 397.60546875

Current
Mean: 388.008 MB
Stdev: 8.802 MB (2.3%)
Runs: 371.1875 371.8984375 372.236328125 374.525390625 375.6953125 376.0846354166667 376.18359375 376.5205078125 377.4140625 377.5078125 379.453125 379.640625 379.78125 380.0872395833333 381.9700520833333 383.197265625 383.2096354166667 383.349609375 384.0299479166667 384.7395833333333 385.2981770833333 385.3515625 385.5247395833333 386.1067708333333 386.2734375 386.6848958333333 386.9010416666667 387.2291666666667 387.3684895833333 387.7330729166667 388.1302083333333 388.3802083333333 388.9127604166667 390.0833333333333 390.4856770833333 390.98046875 391.07421875 391.3229166666667 391.3567708333333 391.3776041666667 391.69921875 391.7434895833333 391.8190104166667 391.9833984375 392.1041666666667 392.59375 392.9986979166667 393.98046875 395.4921875 397.42578125 398.8645833333333 401.06640625 401.3854166666667 402.0677083333333 403.3619791666667 403.9479166666667 404.0729166666667 404.9713541666667 405.5859375
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 27.812 %
Stdev: 3.038 % (10.9%)
Runs: 22 22.1 22.8 23.3 23.4 23.4 24 24 24.4 24.6 24.7 24.7 25 25.3 26 26 26 26 26.6 26.6 26.6 27 27 27.1 27.1 27.1 27.3 27.3 28 28 28 28 28 28 28.1 28.8 29 29 29.1 29.2 29.2 29.3 29.8 30 30 30 30.3 30.7 31 31.1 31.9 32 32 32.7 33.1 33.1 33.3 35

Current
Mean: 26.544 %
Stdev: 3.144 % (11.8%)
Runs: 20 21.2 21.3 21.3 21.7 22.9 23.3 24 24 24 24.3 24.6 24.6 24.6 24.6 24.6 24.6 24.7 24.7 24.7 25 25.2 25.3 25.3 25.3 25.9 25.9 26 26 26 26 26 26.1 26.1 26.1 26.6 26.6 27 27.2 27.3 27.9 28.1 28.1 28.7 29 29 29 29.4 29.9 29.9 30 30 30.6 30.8 31 31.9 33.1 33.8 35.3
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 0.733 renders
Stdev: 0.442 renders (60.3%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

Performance Comparison Report 📊 (3/3)

Meaningless Changes To Duration (2/2)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 87.017 ms → 87.828 ms (+0.810 ms, +0.9%)
App start time nativeLaunch 27.017 ms → 26.103 ms (-0.914 ms, -3.4%)
App start time appCreation 79.417 ms → 77.383 ms (-2.033 ms, -2.6%)
App start time runJsBundle 324.383 ms → 320.175 ms (-4.208 ms, -1.3%)
App start time appCreationEnd_To_contentAppeared 491.322 ms → 466.017 ms (-25.305 ms, -5.2%)
App start time regularAppStart 0.022 ms → 0.022 ms (+0.000 ms, +2.2%)
App start time (CPU) 152.869 % → 152.655 % (-0.214 %, ±0.0%)
App start time (FPS) 59.680 FPS → 59.213 FPS (-0.467 FPS, +0.8%)
App start time (RAM) 381.184 MB → 388.008 MB (+6.823 MB, +1.8%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 27.812 % → 26.544 % (-1.268 %, -4.6%)
Report typing Composer typing rerender count 1.000 renders → 0.733 renders (-0.267 renders, -26.7%) 🟢
Report typing Message sent 457.914 ms → 454.062 ms (-3.852 ms, -0.8%)
Report typing (CPU) 79.937 % → 79.445 % (-0.492 %, -0.6%)
Report typing (FPS) 59.837 FPS → 59.831 FPS (-0.006 FPS, ±0.0%)
Report typing (RAM) 447.461 MB → 447.851 MB (+0.390 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 17.605 % → 17.505 % (-0.100 %, -0.6%)
Chat opening Chat TTI 1031.657 ms → 1013.038 ms (-18.619 ms, -1.8%)
Chat opening (CPU) 163.534 % → 162.948 % (-0.586 %, ±0.0%)
Chat opening (FPS) 59.346 FPS → 59.588 FPS (+0.242 FPS, ±0.0%)
Chat opening (RAM) 390.436 MB → 390.612 MB (+0.177 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.396 % → 32.793 % (-0.604 %, -1.8%)
Show details
Name Duration
Report typing Message sent Baseline
Mean: 457.914 ms
Stdev: 58.976 ms (12.9%)
Runs: 347.3732500001788 355.4515780005604 359.0651049995795 367.172364000231 371.45373499952257 374.55065899994224 374.5686440002173 377.16072599962354 380.1490079993382 388.4142660005018 389.73779299948364 390.7092279996723 394.3454180005938 395.7976080002263 401.7606610003859 406.671875 409.0516759995371 409.6278900001198 411.12239600066096 428.2267660005018 433.46390799991786 438.1004229998216 441.1861979998648 445.875284999609 449.2409260002896 452.2604159992188 453.5790610006079 459.5397140001878 462.3461509998888 463.84757499955595 466.49666399974376 470.21748900040984 471.953735999763 477.5429690005258 478.1784260002896 487.05834999959916 489.13175499998033 489.275839000009 489.2979330001399 491.4567470001057 493.64896599948406 496.61958799976856 497.5480959992856 498.5555419996381 503.08524600043893 503.9033609991893 505.2744549997151 509.92781599983573 518.7868659999222 520.1252439999953 522.1727700000629 523.0687669999897 523.691487999633 529.8000090001151 530.1495770001784 530.6968179997057 532.0724290004 552.1916510006413 567.765503000468 573.284953000024

Current
Mean: 454.062 ms
Stdev: 59.314 ms (13.1%)
Runs: 350.3379720002413 353.24104900006205 363.5695389993489 366.15450099948794 369.83333399984986 370.271199000068 374.2925220001489 375.25386600010097 379.5059810001403 381.6736660003662 384.037150000222 390.5002030003816 393.26245100051165 394.744630000554 396.08862299937755 397.0555020002648 397.3447270002216 401.5501310005784 401.89017800055444 407.1560469996184 429.49072299990803 431.5988360000774 445.0169679997489 445.6480719996616 445.8853769991547 446.8957110000774 449.43871999997646 457.76940999925137 457.9129640003666 460.5150549998507 460.80851299967617 466.1490890001878 467.1652430007234 469.5230299998075 469.655923999846 474.89501900039613 475.98376500047743 478.3234459999949 478.8439539996907 479.2593189999461 488.06392399966717 489.76237000059336 496.80135099962354 497.6099450001493 497.84798200055957 498.72062199935317 502.6988530000672 503.9373779995367 512.4252119995654 519.8669440001249 520.9603679999709 527.6411549998447 530.968871999532 531.7668059999123 532.0933839995414 536.0500900000334 542.7378749996424 551.1535649998114 554.4709479995072 569.5960290003568
Report typing (CPU) Baseline
Mean: 79.937 %
Stdev: 20.882 % (26.1%)
Runs: 51.43253872490948 52.860312394391435 55.43398559156643 55.783034660051094 55.8517161473124 56.44967049281382 56.525911011587816 56.85154092066631 57.22614945495323 58.04139473066998 58.407862129177765 59.256983961332594 60.85535891914197 61.58720871904817 61.87624348681151 62.254738352267374 62.43960992740048 62.675206320431506 64.52242303431748 65.30118050646075 66.04933408286831 66.52759920695652 66.85161395147283 66.98372481211008 67.63218644211386 68.17883037888033 69.4072524450163 70.48623334423051 71.13186588631059 71.88126495934793 73.2143286337129 73.81515420231167 78.71296162652428 80.18237066253613 81.95484421376753 83.06362488200828 86.29903564498076 87.56541082255752 88.67983526859703 89.28659554983228 91.75888550024604 92.40372209949574 93.02560341974156 97.43961102271497 99.0697269299524 99.42814905335158 100.30832392556368 101.59235137122141 101.82896079211889 102.65775795844228 103.03021942342001 103.59546113894918 104.36809417019019 104.64214191207857 114.68041960430833 116.67382635411886 116.91101660183935 118.93512549843868 125.14386596878316 125.19863681426204

Current
Mean: 79.445 %
Stdev: 19.750 % (24.9%)
Runs: 51.15017328410751 53.56719809292547 54.611034221161994 54.91361566865637 55.39660634178953 56.25758919961756 56.45561287890808 57.04105155573068 57.088075059117614 57.15306986364983 57.31218221763366 59.26027380019639 59.82819425980912 59.88732060094427 59.956547126351005 60.82846749461846 62.27393057751732 62.773342571779615 63.44883073851507 64.79744645199692 64.92364600278748 65.99050568720604 66.02265004268573 66.73750512940757 67.90113529949926 68.0210880358361 70.01343416400675 71.43661039199608 72.31225525894385 73.87190845956859 73.89723570809005 79.04200044674677 81.42644250440634 83.09523910979375 85.32558153506407 85.37684115682286 88.60248009251491 91.04546175744525 91.96296960480112 93.13177511034638 93.39931422033608 96.36214838843192 96.39940646239025 96.47423557988242 96.845581703514 97.01159060196608 97.46386910364834 99.20435347446455 100.43407532220205 102.05947264461878 102.57361358979168 103.52815258303659 103.68810770735772 103.75074551883326 105.06001876353928 106.10136679457511 113.09813883634813 115.00194488901265 116.72790111876623 117.39793262097515
Report typing (FPS) Baseline
Mean: 59.837 FPS
Stdev: 0.146 FPS (0.2%)
Runs: 59.44152343323922 59.51195164853655 59.56058006200525 59.605586963207585 59.61727224169861 59.62587889605116 59.63180237454283 59.63890321315753 59.65085307749257 59.662921754113846 59.665095249535916 59.6680776592933 59.683031449871855 59.74226598214282 59.74808586217889 59.75324278826012 59.754540118462536 59.771190052496095 59.77916200357929 59.78310483038448 59.79372189510796 59.79991705090112 59.81679445883975 59.81829872854015 59.82906289725573 59.838152823165494 59.85138695381583 59.861454580849106 59.865416131280554 59.87930845746717 59.885366884304695 59.8854312244982 59.900485823480274 59.90624516656202 59.9078251508511 59.921218303006846 59.9324347008801 59.93525675495581 59.93844819632265 59.94495221974848 59.94713353110771 59.9490189438111 59.957827058516976 59.972758509555334 59.97595256861205 59.97752382105446 59.97864999112022 59.99407308759091 59.996215708823044 59.99727904750282 59.99728130476152 59.99978416372196 59.99989027220736 59.999991591099445 59.999994322069014 60 60 60

Current
Mean: 59.831 FPS
Stdev: 0.147 FPS (0.2%)
Runs: 59.419640902559934 59.49485141663806 59.50179279440764 59.563910445236914 59.57338345694656 59.58073475441847 59.615510739990206 59.66064431484448 59.6796681707599 59.6832036410652 59.708646220423724 59.72229388632281 59.724474093467784 59.74718118583599 59.750934762804114 59.768887808349916 59.777000812021804 59.783490729295345 59.78922133773104 59.79359376304681 59.79410237837025 59.807600583950205 59.81170854575887 59.8236941166537 59.83938093989338 59.84333719538387 59.84425876723036 59.85525618375288 59.85723039814443 59.862311447932996 59.870061922981385 59.884315558007614 59.886230931234586 59.88688519605715 59.90008325945592 59.90655715173204 59.91010794733178 59.91512344575656 59.916290259191825 59.92418808702583 59.92801309393285 59.929338713121716 59.9452637847703 59.9537969011435 59.976293464201234 59.98969594388671 59.99633539860225 59.997615104195816 59.99798550197082 59.99813659156447 59.99846059210796 59.999505314524086 59.99995223387743 59.99995614758585 59.99997431667877 59.999985812928855 60
Report typing (RAM) Baseline
Mean: 447.461 MB
Stdev: 7.834 MB (1.8%)
Runs: 433.80887276785717 433.85558363970586 433.9908854166667 434.6825747282609 435.98963341346155 437.1234130859375 438.08671875 438.6009680706522 439.14911684782606 439.4074966755319 439.71890625 440.05140625 440.1964666193182 440.549375 441.42687136627904 442.2788722826087 442.59247819767444 442.5951450892857 443.05869140625 443.35472074468083 444.1349609375 444.95694247159093 445.3383556547619 445.92841569767444 446.5265625 446.7952473958333 447.185791015625 447.35770089285717 447.4119395380435 447.98511904761904 448.1683843085106 448.23809523809524 448.2841331845238 448.3297601744186 448.5386904761905 448.95424107142856 449.19396033653845 449.25322690217394 449.6431995738636 450.1020275297619 450.3904296875 450.6626838235294 451.5320811170213 452.5396569293478 452.8765285326087 454.0774890988372 454.91592684659093 455.390625 455.4107638888889 456.6732421875 457.7319647606383 457.7474254261364 457.8203125 458.0571614583333 461.3434375 461.82718211206895 462.78440824468083 468.111400462963

Current
Mean: 447.851 MB
Stdev: 7.488 MB (1.7%)
Runs: 433.20985704787233 434.03681848404256 434.1262466755319 434.3578869047619 438.23028273809524 438.37890625 439.32691592261904 439.4390980113636 440.20885970744683 440.5027173913044 440.5279381793478 440.5641983695652 440.59933035714283 440.73937136627904 440.89265625 442.32005208333334 443.0128472222222 443.20703125 443.5203598484849 443.66965553977275 443.839453125 443.8933423913044 443.98153409090907 444.3011968085106 444.47154017857144 445.01899245689657 445.8916440217391 445.9152434593023 447.6834239130435 447.81795058139534 448.6607921511628 448.92705305232556 448.97002377717394 449.7768229166667 450.28125 450.4805743243243 450.69935825892856 451.09818892045456 451.3067336309524 452.0283627717391 452.0364583333333 452.15824854651163 452.3556385869565 452.8035857371795 452.9752038043478 453.1586277173913 453.3611111111111 454.27921195652175 454.3293918918919 454.8408203125 456.96494654605266 457.74387428977275 458.39835069444445 458.5286754261364 458.6453804347826 459.03076171875 459.85509072580646 460.4647623697917 461.3544921875 461.8334099264706
Report typing (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Report typing (CPU/UI) Baseline
Mean: 17.605 %
Stdev: 3.758 % (21.3%)
Runs: 12.1 12.2 12.2 12.5 12.6 12.7 12.8 12.8 12.8 12.9 12.9 13.1 13.1 13.6 13.6 13.8 13.8 14.1 14.6 14.8 14.9 15.3 15.4 16.3 16.9 17.2 17.2 18 18.2 18.6 18.6 18.8 19.1 19.2 19.4 19.5 19.6 19.6 20 20 20.1 20.3 20.3 20.4 20.4 20.4 20.4 20.5 20.6 21.2 21.3 21.3 21.5 21.5 21.8 22.1 22.5 22.5 23.9 28.5

Current
Mean: 17.505 %
Stdev: 3.629 % (20.7%)
Runs: 11.1 11.3 11.5 11.7 11.9 12.2 12.4 12.7 12.9 13.1 13.1 13.1 13.2 13.7 14.6 14.9 14.9 15 15.1 15.1 15.3 15.4 15.5 15.6 16.1 16.2 17.1 17.2 17.7 18.5 18.8 18.8 19 19.2 19.2 19.9 20 20.1 20.2 20.3 20.3 20.5 20.6 20.6 20.6 20.6 20.8 20.8 20.8 20.9 21.1 21.2 21.3 21.3 21.8 22 22.1 22.2 22.6 24.6
Chat opening Chat TTI Baseline
Mean: 1031.657 ms
Stdev: 255.181 ms (24.7%)
Runs: 702.3080649999902 702.935507000424 711.9741219999269 752.2779950005934 761.1053059995174 766.7590339994058 769.7214770000428 792.1081960005686 792.5962319998071 801.1558840004727 802.6372890006751 815.0568040004 819.8854580000043 825.9210620000958 833.0905759995803 836.0799569999799 836.3678799998015 837.4157720003277 842.5496829999611 848.6362720001489 858.7021080004051 870.0203459998593 872.6475020004436 873.2361659994349 879.9490969991311 882.949585000053 927.3698740005493 930.1979170003906 937.7744140001014 947.540690000169 948.2202149992809 952.0393880000338 953.348022999242 993.1435139998794 1017.1331789996475 1064.0537109998986 1089.405476999469 1132.4576429994777 1153.2944339998066 1154.3474939996377 1166.4488530000672 1191.8455410003662 1193.6531989993528 1194.135050999932 1199.983601999469 1201.5703940000385 1209.8379319999367 1213.8593760002404 1229.7486579995602 1251.060628999956 1253.2386480001733 1259.8108729999512 1307.798380999826 1314.6305750003085 1377.5173750007525 1381.9744060002267 1470.3411060003564 1709.0856130002066 1733.9524750001729 1750.510377000086

Current
Mean: 1013.038 ms
Stdev: 184.878 ms (18.2%)
Runs: 538.7492680000141 702.8294679997489 733.8922529993579 756.5138349998742 787.9699309999123 800.9744060002267 828.7251789998263 831.4758310001343 840.0099279992282 861.2317719999701 865.5195309994742 874.5549719994888 877.9029129995033 878.0041100000963 881.3590909997001 885.8659269995987 886.0917149996385 887.9932059999555 892.3505050009117 896.163371999748 911.338175999932 920.3473720001057 923.7397870002314 928.262085000053 930.537313000299 936.6395269995555 946.3638509996235 949.5068370001391 961.3082280000672 967.764038999565 975.9195149997249 992.3653570003808 1017.1579190008342 1025.4990240000188 1062.5809340002015 1106.1716719996184 1107.3625900000334 1154.4113369993865 1156.2670910004526 1161.0794280003756 1161.9875489994884 1170.2333579994738 1184.702351999469 1185.5434579998255 1193.9903170000762 1197.1259770002216 1197.9388839993626 1202.101562999189 1221.0076500000432 1243.424804999493 1269.409221000038 1276.630413000472 1276.7338870000094 1285.3275560000911 1297.954346000217 1343.211141999811 1393.0689700003713
Chat opening (CPU) Baseline
Mean: 163.534 %
Stdev: 4.835 % (3.0%)
Runs: 155.02433893779332 155.17246987506476 155.5513195000067 155.72461552857314 156.50967663805625 158.0251196453291 158.04022194485563 158.40674654430623 158.69783806127407 159.1054703146641 159.20279819407077 159.4809815561456 159.62970472650554 159.66027315687737 159.6835203632956 159.78092578366773 160.4650896003067 160.62600427398124 160.8170754903652 161.02911552711905 161.20775856980148 161.38580228306654 161.4185850651483 161.92531448833196 161.9742687224867 162.54661947998343 162.66942760595637 163.09145872239475 163.69049193328675 163.76531739941456 164.11997253832314 164.40562420284508 164.43868015350176 164.56486551395875 164.71226430180488 164.77616303019016 164.84585111956085 164.96838697335232 164.99487020727082 165.294619650912 165.39388874168185 165.59304106202498 165.8635205495707 165.90743226818918 166.28910592437197 166.5243219824202 167.4489198122868 167.6834390567636 168.26061343937698 168.3252914070159 169.00878700669344 169.16639337242918 169.73986924249164 170.66368513497804 173.30894861692127 173.42446412917218 173.904485257545 177.02926990475274

Current
Mean: 162.948 %
Stdev: 4.483 % (2.8%)
Runs: 151.21807651087894 153.29763803274687 154.21759561330944 155.72378000963036 156.06215611627712 157.07998420022605 158.27141779512618 158.3183955681188 159.09044938104864 159.27126371806133 159.2808839562873 159.5080813365676 159.65694116562668 160.0105850052573 160.28905646122155 160.33151545787067 160.39719655427987 160.95549798582735 161.37743125878364 161.4259115435516 161.5512976179838 161.64170083192448 161.6652829389772 162.00684004749414 162.0958556311393 162.3537471257018 162.67476690138315 162.75411311088746 162.83247397938308 163.03725488247076 163.32136693803827 163.44742998013 163.72416246777027 163.8692399763218 163.98709788297447 164.02523440640363 164.0451018948885 164.44433898058372 164.61521036283943 164.61990705794986 164.6309697296187 164.85146883984808 165.40820626915587 165.52254388540413 165.97023934720863 166.39088847052778 166.63006056756032 166.63123261021755 166.9613602458952 167.35724018190103 168.1020467109884 168.66369059101743 169.199929786285 169.49591344019737 170.04791371186803 170.13500750884938 172.63882247237342 173.83911721846218
Chat opening (FPS) Baseline
Mean: 59.346 FPS
Stdev: 0.656 FPS (1.1%)
Runs: 57.798711588401055 57.96548443599417 58.00532318044033 58.08289716238686 58.33926952773864 58.45910289340204 58.52644001009327 58.573562892513706 58.578181079242185 58.64275040398231 58.66366118322376 58.71341884353012 58.739936639512926 58.76911442467603 58.87516480729135 58.89201274736846 58.97328855341127 59.00215897057807 59.01295022659751 59.016437180300485 59.021310975271945 59.06368331323432 59.12585642484773 59.166573734759616 59.180912612751435 59.20595795900242 59.24377288289447 59.315486418104946 59.33546476354941 59.422971342954234 59.50845701536022 59.71947932731662 59.77489912658503 59.79992119092375 59.85500741368103 59.88177802609294 59.88267554482909 59.94557315733247 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 59.588 FPS
Stdev: 0.519 FPS (0.9%)
Runs: 57.99366456227889 58.22440925392489 58.74052878353212 58.77553171231445 58.78548136672502 58.79333602672368 58.805919076095314 58.970799791326115 58.998733076594796 59.02994993470828 59.08354414300836 59.087438256626235 59.108741607640226 59.118194265311935 59.16367120258584 59.1804704711793 59.185962095726815 59.24572242415166 59.350443055361076 59.37019901461335 59.38593794977801 59.41892717965997 59.428798651520296 59.4867160980819 59.5843408833241 59.68658029791629 59.883257142371576 59.920201842471556 59.93072937015276 59.9422810949492 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Chat opening (RAM) Baseline
Mean: 390.436 MB
Stdev: 7.832 MB (2.0%)
Runs: 374.16238839285717 377.755859375 379.2408854166667 380.25234375 380.8470052083333 382.43046875 382.528125 382.650390625 382.79296875 382.93798828125 383.390625 383.459375 384.11865234375 384.18896484375 384.2900390625 384.49609375 384.50703125 385.01484375 385.02880859375 385.20859375 385.52421875 385.63623046875 386.22421875 386.642578125 386.825 387.099609375 387.23671875 387.30234375 388.3756510416667 389.18671875 389.36640625 389.6236979166667 389.69140625 389.966796875 390.5171875 390.83637152777777 390.87890625 392.0950520833333 394.26339285714283 394.459375 394.753125 395.63037109375 396.025 396.73359375 396.81171875 397.130859375 397.63828125 397.9173177083333 398.228515625 398.5611979166667 398.58705357142856 398.7994791666667 399.00390625 399.1685267857143 402.458984375 402.5864955357143 402.8912760416667 403.38671875 404.990234375 413.77734375

Current
Mean: 390.612 MB
Stdev: 7.347 MB (1.9%)
Runs: 376.5484375 377.1060267857143 377.205078125 378.3020833333333 379.065625 379.48046875 379.7024739583333 379.7650669642857 380.37332589285717 380.6412760416667 381.14296875 384.49560546875 384.833984375 385.88125 386.1162109375 386.208984375 386.3287760416667 386.89501953125 386.9114583333333 387.4853515625 387.56171875 387.6067708333333 387.9947916666667 388.1689453125 388.5359375 388.7259114583333 389.075 389.6979166666667 390.82769097222223 391.4329427083333 391.7037760416667 391.8489583333333 392.2819010416667 392.5338541666667 393.028125 393.263671875 393.41796875 393.6015625 394.20703125 394.4401041666667 394.47265625 394.628125 394.65869140625 394.678515625 395.4017857142857 396.697265625 397.5286458333333 397.76841517857144 397.849609375 398.9296875 399.0615234375 399.29966517857144 399.48984375 399.61328125 400.39453125 401.2174479166667 401.82578125 402.146484375 402.73716517857144 403.896484375
Chat opening (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
Chat opening (CPU/UI) Baseline
Mean: 33.396 %
Stdev: 2.129 % (6.4%)
Runs: 28.5 29.1 29.5 29.5 29.8 30.3 30.4 30.9 31 31.5 31.5 31.5 32.2 32.2 32.4 32.4 32.5 32.6 32.6 32.7 32.7 32.8 32.9 33 33 33.2 33.2 33.2 33.4 33.4 33.5 33.5 33.6 33.7 34 34 34.4 34.6 34.7 34.9 34.9 35 35 35.1 35.1 35.2 35.3 35.4 35.5 35.5 35.7 35.9 35.9 36.1 37.4 37.5 38.3

Current
Mean: 32.793 %
Stdev: 1.661 % (5.1%)
Runs: 29.6 30 30 30.1 30.2 30.4 30.7 30.8 31 31.1 31.2 31.3 31.6 31.7 31.8 31.8 31.8 31.9 32 32.1 32.1 32.2 32.3 32.3 32.3 32.4 32.4 32.5 32.6 32.7 32.7 32.8 33.1 33.1 33.1 33.3 33.6 33.6 33.6 33.7 33.8 33.9 33.9 34 34 34.4 34.6 34.7 34.9 34.9 35 35.1 35.1 35.3 35.5 35.5 37.1

@github-actions

github-actions Bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@github-actions github-actions Bot mentioned this pull request May 21, 2025
Closed
@github-actions

github-actions Bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.48-0 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions

github-actions Bot commented May 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.48-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.49-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot Bot mentioned this pull request May 23, 2025
Closed
16 tasks
@github-actions

github-actions Bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.50-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stitesExpensify stitesExpensify stitesExpensify approved these changes

+1 more reviewer

@ZhenjaHorbach ZhenjaHorbach ZhenjaHorbach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DeployBlockerCash This issue or pull request should block deployment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bernhardoj @ZhenjaHorbach @OSBotify @stitesExpensify