padding using wrapperStyle#6237
Merged
timszot merged 1 commit intoNov 5, 2021
Merged
Conversation
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
…ns_Floating_Button padding using wrapperStyle (cherry picked from commit 3d22037)
Contributor
|
🚀 Cherry-picked to staging by @francoisl in version: 1.1.14-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
70 tasks
Contributor
Contributor
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
PR #6196 caused a regression, so fixing the regression using the solution already provided here. First just passing the style using
wrapperStyleFixed Issues
$ #5906
$ #6232
Tests & QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-11-05.at.12.26.57.PM.mov
Desktop
Screen.Recording.2021-11-05.at.12.31.40.PM.mov