fix: track expense disappears after delete offline#62470
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-05-23_16.50.26.mp4Android: mWeb Chromeandroid-chrome-2025-05-23_16.53.14.mp4iOS: HybridAppios-app-2025-05-29_17.00.56.mp4iOS: mWeb Safariios-safari-2025-05-29_17.05.38.mp4MacOS: Chrome / Safaridesktop-chrome-2025-05-23_15.30.41.mp4MacOS: Desktopdesktop-app-2025-05-23_15.37.40.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
|
@jjcoffee I updated. |
|
Thanks! I'll have to retest tomorrow - having iOS build problems at the moment 😞 |
jjcoffee
left a comment
There was a problem hiding this comment.
Nice, tests well! LGTM!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/3)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (2/3)Meaningless Changes To Duration (1/2)Show entries
Show details
|
Performance Comparison Report 📊 (3/3)Meaningless Changes To Duration (2/2)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
Still flaky |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.55-0 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.56-2 🚀
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.58-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀
|
Explanation of Change
Fixed Issues
$ #60638
PROPOSAL:
Tests
Precondition: Account has self DM. Has
tableReportViewbetaOffline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-05-21.at.17.09.11.mov
Android: mWeb Chrome
Screen.Recording.2025-05-21.at.17.10.04.mov
iOS: Native
Screen.Recording.2025-05-21.at.17.16.28.mov
iOS: mWeb Safari
Screen.Recording.2025-05-21.at.17.17.29.mov
MacOS: Chrome / Safari
Screen.Recording.2025-05-21.at.17.18.07.mov
MacOS: Desktop
Screen.Recording.2025-05-21.at.17.18.41.mov