Private domain onboarding - Add verify button on the OTP screen#62489
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@Expensify/design Does this look good to you?
Test-Vid: 22.05.2025_00.02.58_REC.mp4 |
|
We want some more padding between the error and the buttons (red square). Maybe like 8-12px. And I don't think we want the X to dismiss the error message on this one. cc @Expensify/design for check of gut |
|
Agree that we want a little more spacing there, 8 or 12 sounds great. In terms of dismissibility... I'm actually not too sure what the right answer is there? I guess if you clear the error, you just stay on the screen and get to try again, right? I could go either way! |
|
Yes, clearing the error, clears the code input field and remove error state(red coloring). |
|
@allroundexperts Can you please update the styles? |
|
Sure. I can update the styles. |
|
Just FYI, @shawnborton The same margin bottom for error ( |
|
Updated @parasharrajat @shawnborton 
|
| pendingAction={validatePendingAction} | ||
| errors={canShowError ? finalValidateError : undefined} | ||
| errorRowStyles={[styles.mt2, styles.textWrap]} | ||
| errorRowStyles={[styles.mv2, styles.textWrap]} |
There was a problem hiding this comment.
This is not a good idea as this will add more gap in existing screen. Here is one bug caused with this change.
The gap issue is present when skip button is visible. As the margin from confirm button is not applied to the error due to skip Button.
A way to solve this would be to only apply this margin bottom when the skip button is visible. But please check validate and test this before making the change.
|
The mock above looks good but curious what you think about the latest comment here from Rajat. |
|
@parasharrajat Updated. 
|
|
@shawnborton do you approve of the design? |
|
Feels pretty good to me, consider it approved! cc @Expensify/design for extra approval if needed :) |
|
iOS: Page should be scrollable to allow seeing whole content. 26.05.2025_18.27.59_REC.mp4 |
|
@parasharrajat The bug is fixed. Screen.Recording.2025-05-28.at.4.50.12.AM.mov |
|
Android: Noticed that there is no bottom margin between the button and the screen. Offline view.
Online View. 31.05.2025_20.59.42_REC.mp4ioS: Similarly, on iOS, as the content grows(when we have code requested messages and errors on the screen). Bottom margin reduces. Even on scrolling, the full bottom margin is not revealed. Expected: For all mobile platforms, we should have a consistent margin bottom even when the offline indicator is shown. IF there is not much space, we should see the full margin on scroll. 31.05.2025_21.12.30_REC.mp4 |
|
@parasharrajat Fixed. 
|
Screenshots🔲 iOS / native02.06.2025_17.07.48_REC.mp4🔲 iOS / Safari02.06.2025_17.12.50_REC.mp4🔲 MacOS / Desktop31.05.2025_21.57.38_REC.mp4🔲 MacOS / Chrome31.05.2025_21.28.04_REC.mp4🔲 Android / Chrome31.05.2025_21.25.22_REC.mp4🔲 Android / native02.06.2025_17.22.38_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
I noticed that work-email screen and this screen have the different gap between the two buttons. @shawnborton. What is the correct one? How did it slip through design checks? 3 screens, 3 gaps.
|
|
cc: @allroundexperts |
|
Anyway, this is no blocker for this PR as the other 2 screens are out of the scope of this PR. I fix those separately if needed? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.55-0 🚀
|
Good spotting. The correct spacing between the buttons should be |
|
Agree with that Jon! |
|
OK, I will directly create a PR for this or do we want to go through bug reporting/proposal/solution cycle? |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.56-2 🚀
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.1.58-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀
|
6 participants
Explanation of Change
This PR adds a verify button on the OTP screen for the private domain onboarding flow.
Fixed Issues
$ #60818
PROPOSAL: N/A
Tests
Verify that after changing the first digit, the code input field will move to the next digit.
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Verify that after changing the first digit, the code input field will move to the next digit.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop