[No QA] Only post to slack when job was successful

[tgolen]

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/183630

Tests

The next time there is a deploy failure, we can verify there was no success message posted

QA Steps

None

cc @roryabraham

[roryabraham]

LGTM

[aldo-expensify]

Looks good to me.

NAB: just a doubt, there is no message on slack on failure, right?

[tgolen]

@aldo-expensify There is a message for the failure, yeah. It's higher up in the file:

App/.github/workflows/platformDeploy.yml

Lines 350 to 372 in 300decb

	postSlackMessage:
	name: Post a Slack message when any platform fails to build or deploy
	runs-on: ubuntu-latest
	if: ${{ failure() }}
	needs: [android, desktop, iOS, web]
	steps:
	- uses: 8398a7/action-slack@v3
	name: Job failed Slack notification
	with:
	status: custom
	fields: workflow, repo
	custom_payload: |
	{
	channel: '#announce',
	attachments: [{
	color: "#DB4545",
	pretext: `<!subteam^S4TJJ3PSL>`,
	text: `💥 ${process.env.AS_REPO} failed on ${process.env.AS_WORKFLOW} workflow 💥`,
	}]
	}
	env:
	GITHUB_TOKEN: ${{ github.token }}
	SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }}

[aldo-expensify]

@aldo-expensify There is a message for the failure, yeah. It's higher up in the file:

Cool, I missed it!, thanks

[yuwenmemon]

NAB: just a doubt, there is no message on slack on failure, right?

I didn't see this show up when the successful message was displayed:
https://expensify.slack.com/archives/C07J32337/p1635813884219300

Are we sure the fail message posts in #deployer?

[tgolen]

Are we sure the fail message posts in #deployer?

Well, according to that action, the fail message posts to #announce.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅