Add debounce on SearchAutocompleteInput

[sosek108]

Explanation of Change

This PR provides debounce effect of 300 ms to SearchAutocompleteInput main goal is to minify API calls and rerenders while user is actively typing.

Fixed Issues

$ #62106
PROPOSAL:

Tests

1. Login to an account with a lot of report history.
2. Open Search via loupe icon
3. Try to write some query
4. Observe

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Login to an account with a lot of report history.
2. Open Search via loupe icon
3. Try to write some query
4. Observe

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[sosek108]

Before change: Three API requests visible

After change: Only one API request

[c3024]

A performance test is failing likely due to fewer renders.

[parasharrajat]

I can review this PR as I am assigned to the related issue #59262 (comment)

[c3024]

@parasharrajat , sure! Go ahead.

Let me know if you cannot.

[sosek108]

Honestly I think this failing test is fail negative. Look for my screens:

SearchInputSelectionWrapper before changes:

After changes:

There are more renders during tests as there are more hooks in new implementation. This makes sense. But tests does not take into account that we have less API calls so fewer Onyx updates which causes additional rerenders.

[mountiny]

@parasharrajat can you please review now? thanks!

[parasharrajat]

Yes, doing in few minutes.

[parasharrajat]

BUG:Web: Sometimes Cursor jumps back and typed charactors are deleted.

Steps:

1. Type chars slowly in sync with debounce time.
2. You will have to try a few times to get this.

23.05.2025_00.41.47_REC.mp4

[parasharrajat]

BUG: Android: Same as before, the last typed character blinks.

Steps;

1. Type Hy is normal speed.

23.05.2025_00.44.26_REC.mp4

[sosek108]

@parasharrajat I will investigate letter blinking. The pointer shift issue is on main already so this is not related to my change. I suspect that this is related to markdown and parser functionality. This also causes problem with text selection on iPhone

[parasharrajat]

Ok, great. Let's get that character blinking fixed.

[sosek108]

The problematic line is here

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 197 in 409e68e

setTextInputValue(updatedUserQuery);

SearchRouter sets back value of our input to the value it recieved via debounced callback. This overwrites your input for brief moment until new debounced callback is called.

Example:

1. you hit `ha`
2. debounced callback is send after 300ms
3. in the exact time you hit new letter to write `hay`. This is scheduled to send after 300ms
4. `SearchRouter` parses callback from step 2 and overwrites value to `ha` -> you see that
5. Callback from step 3 is called.

I'll push commit to try move some logic to SearchInput

[sosek108]

Unfortunately this is not easy. Doing so repaired blinking issue but introduced others issues.

[sosek108]

@parasharrajat I think I did find good solution for that. I've pushed my update

[parasharrajat]

Reviewinfg in 15 minutes.

[parasharrajat]

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

[parasharrajat]

@sosek108

Web: I noticed that on the Reports search page, sometimes the search text in the autocomplete list is not in sync with the search value.

Check the last few seconds of the vid. On staging, it quickly updates to the search value but here it takes time, seems like waiting for the search to complete. I couldn't get the staging build to run locally on this PR to compare that, but letting you know.

27.05.2025_20.33.50_REC.mp4

[sosek108]

@parasharrajat It does not replicate on my side. Could you please share onyx state with me?

Could you also verify if this occurs on this Draft PR? #62962

[parasharrajat]

Sure, let me check. which key's value do you want?

[sosek108]

@parasharrajat I've added one quick change. Could you please test it?

edit: no, it's not good. Previous error showed up. This debounce is tricker than I could assume. Please focus on another PR's. This one needs my attention

[mountiny]

@sosek108 do you htink we should keep this open or close?

[sosek108]

We can close this PR