Skip to content

fix: missing route in help content #62640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inimaga merged 1 commit into from
Jun 1, 2025
Merged

fix: missing route in help content #62640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ROUTES.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1873,6 +1873,8 @@ const ROUTES = {
getRoute: (contentType: string, backTo?: string) => getUrlWithBackToParam(`referral/${contentType}`, backTo),
},
SHARE_ROOT: 'share/root',
SHARE_ROOT_SHARE: 'share/root/share',
SHARE_ROOT_SUBMIT: 'share/root/submit',
SHARE_DETAILS: {
route: 'share/share-details/:reportOrAccountID',
getRoute: (reportOrAccountID: string) => `share/share-details/${reportOrAccountID}` as const,
Expand Down
17 changes: 14 additions & 3 deletions src/libs/Navigation/linkingConfig/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type {LinkingOptions} from '@react-navigation/native';
import type {RouteConfig} from '@libs/Navigation/helpers/createNormalizedConfigs';
import createNormalizedConfigs from '@libs/Navigation/helpers/createNormalizedConfigs';
import type {RootNavigatorParamList} from '@navigation/types';
import CONST from '@src/CONST';
import NAVIGATORS from '@src/NAVIGATORS';
import ROUTES from '@src/ROUTES';
import type {Screen} from '@src/SCREENS';
Expand Down Expand Up @@ -1746,9 +1747,19 @@ const config: LinkingOptions<RootNavigatorParamList>['config'] = {
[NAVIGATORS.SHARE_MODAL_NAVIGATOR]: {
initialRouteName: SCREENS.SHARE.ROOT,
screens: {
[SCREENS.SHARE.ROOT]: {path: ROUTES.SHARE_ROOT},
[SCREENS.SHARE.SHARE_DETAILS]: {path: ROUTES.SHARE_DETAILS.route},
[SCREENS.SHARE.SUBMIT_DETAILS]: {path: ROUTES.SHARE_SUBMIT_DETAILS.route},
Comment on lines -1750 to -1751

@289Adam289 289Adam289 Jun 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I believe that this pr caused a regression. I've opened pr with a fix #63249

Screen.Recording.2025-06-02.at.16.52.21.mov

[SCREENS.SHARE.ROOT]: {
path: ROUTES.SHARE_ROOT,
screens: {
[CONST.TAB.SHARE.SHARE]: {
path: ROUTES.SHARE_ROOT_SHARE,
exact: true,
},
[CONST.TAB.SHARE.SUBMIT]: {
path: ROUTES.SHARE_ROOT_SUBMIT,
exact: true,
},
},
},
},
},
},
Expand Down
Loading