fix: ComposeBox - When you click on the mention again, extra characters appear. by Krishna2323 · Pull Request #62642 · Expensify/App

Krishna2323 · 2025-05-23T11:03:38Z

Explanation of Change

Fixed Issues

$ #60804
PROPOSAL: #60804 (comment)

Tests

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

Verify that no errors appear in the JS console

Offline tests

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

QA Steps

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…rs appear. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-05-23T15:48:05Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-05-23T19:58:19Z

        EMPTY_COMMENT: /^(\s)*$/,
        SPECIAL_CHAR: /[,/?"{}[\]()&^%;`$=#<>!*]/g,
        FIRST_SPACE: /.+?(?=\s)/,
+        SPECIAL_CHAR_MENTION_BREAKER: /[,/?"{}[\]()&^%;`$=<>!*]/g,


In the preview PR, we were using SPECIAL_CHAR which counts # as the end of the mention. However, we can add mentions using both @ and #, so we need to create a new regex for the mention breaker to resolve #61961.

hoangzinh · 2025-05-26T11:06:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-27.at.21.43.48.mov

Android: mWeb Chrome

Screen.Recording.2025-05-27.at.20.50.10.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-05-27.at.21.16.29.mov

iOS: mWeb Safari

Screen.Recording.2025-05-27.at.20.52.46.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-26.at.19.22.08.web.mov

MacOS: Desktop

Screen.Recording.2025-05-27.at.20.46.08.desktop.mov

OSBotify · 2025-05-28T16:18:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-05-29T16:42:53Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.54-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…60804_pr2" This reverts commit 21e6224, reversing changes made to d2ce7f5.

[CP Staging] Revert #62642 "fix: ComposeBox - When you click on the mention again, extra characters appear"

[CP Staging] Revert #62642 "fix: ComposeBox - When you click on the mention again, extra characters appear" (cherry picked from commit 80d86d8) (cherry-picked to staging by francoisl)

hoangzinh · 2025-05-29T23:18:51Z

oh no, there is another regression bug. cc @Krishna2323

Krishna2323 · 2025-05-29T23:21:33Z

@hoangzinh, I'll raise another PR today 🥲😭

dangrous · 2025-05-30T14:19:17Z

Augh - this is trickier than expected haha. Let's keep trying!

github-actions · 2025-06-02T19:29:58Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.54-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-02T19:56:22Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:51:13Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T20:03:38Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-04T16:19:52Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 added 2 commits May 23, 2025 16:25

fix: ComposeBox - When you click on the mention again, extra characte…

6d75fab

…rs appear. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix ESLint.

b0ef9e0

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review May 23, 2025 15:48

Krishna2323 requested a review from a team as a code owner May 23, 2025 15:48

melvin-bot Bot requested review from hoangzinh and removed request for a team May 23, 2025 15:48

Krishna2323 mentioned this pull request May 23, 2025

[Due for payment 2025-07-07] [$250] ComposeBox - When you click on the mention again, extra characters appear #60804

Closed

8 tasks

Krishna2323 commented May 23, 2025

View reviewed changes

hoangzinh approved these changes May 27, 2025

View reviewed changes

melvin-bot Bot requested a review from dangrous May 27, 2025 15:39

dangrous approved these changes May 28, 2025

View reviewed changes

dangrous merged commit 21e6224 into Expensify:main May 28, 2025
17 of 19 checks passed

github-actions Bot mentioned this pull request May 29, 2025

Deploy Checklist: New Expensify 2025-05-29 #63061

Closed

89 tasks

BlameGPT mentioned this pull request May 29, 2025

Chat - Last name remains in the composer after selecting user from suggestion list #63097

Closed

8 tasks

francoisl added a commit that referenced this pull request May 29, 2025

Revert "Merge pull request #62642 from Krishna2323/krishna2323/issue/…

ba24abe

…60804_pr2" This reverts commit 21e6224, reversing changes made to d2ce7f5.

francoisl mentioned this pull request May 29, 2025

[CP Staging] Revert #62642 "fix: ComposeBox - When you click on the mention again, extra characters appear" #63100

Merged

49 tasks

melvin-bot Bot added Reviewing Has a PR in review Weekly KSv2 labels May 29, 2025

Julesssss added a commit that referenced this pull request May 29, 2025

Merge pull request #63100 from Expensify/francois-revert-62642

80d86d8

[CP Staging] Revert #62642 "fix: ComposeBox - When you click on the mention again, extra characters appear"

BlameGPT mentioned this pull request May 30, 2025

[Due for payment 2025-06-11] [Due for payment 2025-06-09] Tags - Subtags are missing for dependant/independant tags when there are less than 15 #63135

Closed

8 tasks

github-actions Bot mentioned this pull request Jun 2, 2025

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

Conversation

Krishna2323 commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 23, 2025

Uh oh!

Krishna2323 May 23, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented May 28, 2025

Uh oh!

github-actions Bot commented May 29, 2025

Uh oh!

hoangzinh commented May 29, 2025

Uh oh!

Krishna2323 commented May 29, 2025

Uh oh!

dangrous commented May 30, 2025

Uh oh!

github-actions Bot commented Jun 2, 2025

Uh oh!

github-actions Bot commented Jun 2, 2025

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

github-actions Bot commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented May 23, 2025 •

edited

Loading

hoangzinh commented May 26, 2025 •

edited

Loading