Re-add autoFocus prop for ExpensiText components#6300
Merged
Conversation
roryabraham
approved these changes
Nov 15, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
36 tasks
70 tasks
Contributor
|
🚀 Deployed to staging by @roryabraham in version: 1.1.14-5 🚀
|
|
The accessibility issues found in this PR:
|
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.15-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@roryabraham will you please review this?
Details
This is a regression from 2231d55, we just need to ensure that autoFocus is still included.
Fixed Issues
$ #6298
Tests/QA
+button and selectRequest MoneyorSend MoneyNextWhat's It Forinput on the following screen autoFocuses and you can see both the label and the placeholderTested On
Screenshots