[No QA] Upgrade prettier to 3.5.3 by roryabraham · Pull Request #63118 · Expensify/App

roryabraham · 2025-05-30T01:34:15Z

Explanation of Change

For #62801 I'm writing unit tests for a script that runs prettier. The way the tests work, I make the script generate translation files in a temporary directory. Prettier is used to format the output files, and that well-formatted output is critical to making the tests clear.

So, why is this PR needed? Because I need to run prettier programatically (so that I can format files in another directory with the config from this project), and because Prettier 2 doesn't ship with .d.ts files. An alternate solution would be to just install @types/prettier, but I figure we might as well just upgrade prettier.

Fixed Issues

$ n/a

Tests

Just code formatting - should have no effect on runtime logic. The prettier check that runs on this PR should be sufficient testing.

Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

None.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-30T01:34:19Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-05-30T01:34:41Z

@JS00001 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2025-05-30T04:38:13Z

When it rains it pours ... Validate GitHub Actions is failing on main, created a separate PR to fix it: #63125

roryabraham · 2025-05-30T04:42:39Z

not sure why the prettier check is failing (on unused style searcher, not even on prettier. It produces different results when I run it locally in the vm, and fails on my mac saying there's some kind of memory corruption

JS00001 · 2025-05-30T13:06:45Z

You've got merge conflicts, and it looks like you're going to have to fix eslint for all the touched files 🫠

# Conflicts: # src/libs/SearchUIUtils.ts # src/pages/home/report/PureReportActionItem.tsx

roryabraham · 2025-05-30T17:52:58Z

Ok @JS00001:

GitHub Actions Validate failure was coincidence and has been fixed on main
style check is problematic and has been disabled. created [Due for payment 2025-08-15] Fix/rebuild unused style searcher #63192 to re-enable it after fixing it
re:changed files check, I think we should ignore it for now and just merge. Because this PR changes a ton of files, doing those refactors will substantially increase the risk of this currently-very-low-risk PR.

JS00001 · 2025-05-30T18:24:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

melvin-bot · 2025-05-30T18:28:23Z

@JS00001 looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

JS00001 · 2025-05-30T18:30:32Z

See here: #63118 (comment)

We merged w/ eslint failing because this affected a ton of files in the project (prettier changes), and there would be more risk of breaking things by messing w/ a bunch of files

roryabraham · 2025-05-30T18:37:52Z

Just to clarify, only the changed files ESLint check was failing

OSBotify · 2025-05-30T18:38:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-02T19:58:16Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.55-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T12:53:07Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.56-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

github-actions · 2025-06-03T20:05:32Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.1.58-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-04T16:21:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.1.58-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Upgrade prettier and run change

217f21f

roryabraham self-assigned this May 30, 2025

roryabraham requested review from a team as code owners May 30, 2025 01:34

melvin-bot Bot requested a review from JS00001 May 30, 2025 01:34

melvin-bot Bot removed the request for review from a team May 30, 2025 01:34

roryabraham added 3 commits May 29, 2025 20:29

Commit remnant diff

b0b8444

Remove accidentally committed files

073c26e

Rebuild gh actions

1cc8396

roryabraham changed the title ~~[No QA] Upgrade prettier and run change~~ [No QA] Upgrade prettier to 3.5.3 May 30, 2025

MacroLens mentioned this pull request May 30, 2025

[NO QA] Fix 62656 lint changed #62993

Merged

51 tasks

JS00001 previously approved these changes May 30, 2025

View reviewed changes

roryabraham added 3 commits May 30, 2025 10:34

Merge branch 'main' into Rory-BumpPrettier

4a10883

# Conflicts: # src/libs/SearchUIUtils.ts # src/pages/home/report/PureReportActionItem.tsx

Re-run prettier after merge

5b7557a

Remove unused style searcher check

8b84d7d

roryabraham dismissed JS00001’s stale review via 8b84d7d May 30, 2025 17:46

JS00001 approved these changes May 30, 2025

View reviewed changes

JS00001 merged commit ebcd248 into main May 30, 2025
28 of 30 checks passed

JS00001 deleted the Rory-BumpPrettier branch May 30, 2025 18:28

melvin-bot Bot added the Emergency label May 30, 2025

JS00001 removed the Emergency label May 30, 2025

This was referenced May 30, 2025

Investigate workflow job failing on main: prettier / Prettier check #63203

Closed

Deploy Checklist: New Expensify 2025-06-02 #63263

Closed

Conversation

roryabraham commented May 30, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 30, 2025

Uh oh!

melvin-bot Bot commented May 30, 2025

Uh oh!

roryabraham commented May 30, 2025

Uh oh!

roryabraham commented May 30, 2025

Uh oh!

JS00001 commented May 30, 2025

Uh oh!

roryabraham commented May 30, 2025

Uh oh!

JS00001 commented May 30, 2025

Reviewer Checklist

Uh oh!

Uh oh!

melvin-bot Bot commented May 30, 2025

Uh oh!

JS00001 commented May 30, 2025

Uh oh!

roryabraham commented May 30, 2025

Uh oh!

OSBotify commented May 30, 2025

Uh oh!

github-actions Bot commented Jun 2, 2025

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

github-actions Bot commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants