Skip to content

[No QA] Fix gh actions schema validation #63125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
May 30, 2025
Merged

[No QA] Fix gh actions schema validation #63125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f22be2
Stop skipping workflows that are passing lint
roryabraham May 30, 2025
cc76bf6
Add descriptions for workflow_call outputs
roryabraham May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/scripts/validateActionsAndWorkflows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ done

for ((i=0; i < ${#WORKFLOWS[@]}; i++)); do
WORKFLOW=${WORKFLOWS[$i]}

# Skip linting e2e workflow due to bug here: https://github.com/SchemaStore/schemastore/issues/2579
if [[ "$WORKFLOW" == './workflows/e2ePerformanceTests.yml'
|| "$WORKFLOW" == './workflows/testBuild.yml'
|| "$WORKFLOW" == './workflows/deploy.yml' ]]; then
continue
fi

ajv -s ./tempSchemas/github-workflow.json -d "$WORKFLOW" --strict=false &
ASYNC_PROCESSES[${#ACTIONS[@]} + i]=$!
done
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/buildAndroid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,13 @@ on:

outputs:
AAB_FILE_NAME:
description: Name of the AAB file produced by this workflow.
value: ${{ jobs.build.outputs.AAB_FILE_NAME }}
APK_FILE_NAME:
description: Name of the APK file produced by this workflow.
value: ${{ jobs.build.outputs.APK_FILE_NAME }}
APK_ARTIFACT_NAME:
description: Name of the APK artifact.
value: ${{ jobs.build.outputs.APK_ARTIFACT_NAME }}

workflow_dispatch:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/testBuildHybrid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@ on:

outputs:
ANDROID_LINK:
description: The link to the Android build.
value: ${{ jobs.androidHybrid.outputs.S3_APK_PATH }}
IOS_LINK:
description: The link to the iOS build.
value: ${{ jobs.iosHybrid.outputs.IOS_PATH }}

env:
Expand Down